Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp3615305pxb; Tue, 7 Sep 2021 03:50:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxn7dzdELOqnjM4V4vOvZpsPXhnYqLK+KYHx0LQZhEWLvAef4Aq6T1a6Vrnd+YbOW/BUAAi X-Received: by 2002:a02:3b58:: with SMTP id i24mr8940608jaf.144.1631011802926; Tue, 07 Sep 2021 03:50:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631011802; cv=none; d=google.com; s=arc-20160816; b=F9a9ue8SfjNnhPH0Rpqg89mS3vbKdEtFw2ySUF+pSeCk542zuM4W/dmGSzKGjZDTME lgdvIODtFkhc8hoiwR5jw+LUdRD5qRMYIp6u2wl/tkPmKG7+wER7Im3Kv29W7ahu/oSA WjS/q9eNYP8ZA2ACZvKZsVVfim6Yoiozc6m5kPa9PTul3bJ83OM7X0SLg/5DLpUwE99q pTwo2KNb6BZ/LiaveQJGAnBjthR3EfuVj7C7P2YZw7rY6QKq4RQURQ7gGyTu/OnSWmCY o26xZUuNdW7VERNFoXRDFBpDKExyIfbGZ1wxpWS0FECf6y084t4ZRMn0NKjH/AFOzgm5 k69A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=0lEHRp9RVZruXFRyj3O2UNGVIAi8zooypFTJKD7Bh+Q=; b=IV7cLb4Rnid97rzIHfzgsItaGbB7or4KsJx5DgSHNXiHqmkBnW7Xo7B28LowJnIzcn V43JZwQg0Gm5iCDudYf7Iko3GExwcSs18qAjjO+3HLsgp1XKnZNDToa6i/2eZskcB8jB NAr59v+temlY+U3ZoAtCnpQu3gcnd3Ae4X7nznh7BNJyjeDzwYrYyExQHVl4ZgAy1PaX 6QylxYM/oznMx4VtAQ0ASDPO9uTxNf0YfZ0pN7Rapi+N0sqEhzE/eXv0FvscD7xc78Hi jCAepm/V++4dx9vK3PzoyjsQdjHJKi+41enZx3xiA8Liv/+CcD1EUW3/5TgCqALZhD04 R1WA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=qzUbiDog; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r13si10395274ilo.33.2021.09.07.03.49.51; Tue, 07 Sep 2021 03:50:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=qzUbiDog; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245666AbhIGK3X (ORCPT + 99 others); Tue, 7 Sep 2021 06:29:23 -0400 Received: from smtp-relay-canonical-1.canonical.com ([185.125.188.121]:58974 "EHLO smtp-relay-canonical-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245750AbhIGK3W (ORCPT ); Tue, 7 Sep 2021 06:29:22 -0400 Received: from localhost (1.general.cking.uk.vpn [10.172.193.212]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id A17E53F106; Tue, 7 Sep 2021 10:28:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1631010494; bh=0lEHRp9RVZruXFRyj3O2UNGVIAi8zooypFTJKD7Bh+Q=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=qzUbiDogJk/qrbWcv63BZLtFTmBLBI6fqRT3d4wqf9tVB6mxDIUq/qWtVNgcX7dB+ TaatYDD1Rw7S8CZL0jxk50ojKSTgZ3VwsYHVk53XgSjA1eLYs9hqZHwTxQfn2C5PLS QGPPm1Loqc9f5fxt6motPj1QsFvsbBLpvdoVkQB5WWHOr96Tb00F+MGp2nc/hD/VBa Yfr7xny09Ikrx3YJuZmX4wOSxgfkqxFzU7N51BNYgqBKBHbzA85LNZboNS9Xr+DeqL 8S7ZHTVuRTMkZl7zrV5195QpLUV0IblJhdMo2vwyI0ZZMAesy345OxpjroTc/Cx71o GjPdWj6JOmjpg== From: Colin King To: Alexander Aring , Stefan Schmidt , "David S . Miller" , Jakub Kicinski , linux-wpan@vger.kernel.org, netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ieee802154: Remove redundant initialization of variable ret Date: Tue, 7 Sep 2021 11:28:14 +0100 Message-Id: <20210907102814.14169-1-colin.king@canonical.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The variable ret is being initialized with a value that is never read, it is being updated later on. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- net/mac802154/iface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac802154/iface.c b/net/mac802154/iface.c index 1cf5ac09edcb..323d3d2d986f 100644 --- a/net/mac802154/iface.c +++ b/net/mac802154/iface.c @@ -617,7 +617,7 @@ ieee802154_if_add(struct ieee802154_local *local, const char *name, { struct net_device *ndev = NULL; struct ieee802154_sub_if_data *sdata = NULL; - int ret = -ENOMEM; + int ret; ASSERT_RTNL(); -- 2.32.0