Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp3628304pxb; Tue, 7 Sep 2021 04:10:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz6mELG/kLLmJfZtO0LTKPcOLKz6NR7qAhh0Sf1eQD1ApwDJCmxDBfVdjz8Gd3aYQQ7LUmI X-Received: by 2002:a5d:9c89:: with SMTP id p9mr13259638iop.13.1631013056621; Tue, 07 Sep 2021 04:10:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631013056; cv=none; d=google.com; s=arc-20160816; b=ALzs6/4hRG4oEpZxgIf4RFmy4BW5DpNsQmeth1xOETi7JGd3mqjjHVqcKWJWuAdSyJ UIzCSAUajCNL3Um7Acdw4c2SzD0JgK96UOObem0iJR55z5ejdsv13/FXal5BHZg3OpLz vl1uNW74Nr3QgwRrSIUowEml2eqx+NC9kCrYqNXkUnO/XONI+RgIEPSmv+/nWCUqPxf1 i7EKYxqs+zFsojvJQfqvbC+yMlrHqhlsd5VwpHMoHs4Ef8no6mYi9md+aPkQCWhmGmCQ 3r+nokyHnwSvqxPKxHuUHWEDqw/6xjnKZv5L//G3RcwVPWTu8TnN0JSgaybqWAHqlBfH gnCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=5zF7FrF9V3AncSdXcy8cFb4c8MGP7SY6V76Vkh/I5bQ=; b=Pbb1pESTksfvemMNgPxH23tV/UlRNapR6X6nqJffnHe8jHbNdIVJ2U9wCixb3MOoDd DN9BSwwWqW/pKnLgn7QvLFVFnA57eo3RCbGcf0kg35FMDKC9TYoJN/GBgg2wG9qO/rFW pQSAyhafZmbzBGaeUpIF8Qi7O4+zaa0NZ3k5yTqNYmFFrJ3m+Tfv8qrjyvvVotEa3Pl1 xY45b4OFK0WGwnGMEKNSeBQrmE9m1Ka66znlEmTGOh0KEX3g2v6eJN3GC7NO+hG9axLk VXdYCX2ZCYl5hCsPKZ2OEKE6AxA/ezRSszHs2S0qtwUBc4GJmJ0sDH2MuemRpoiWL0F8 C1cA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=L1brJSz1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p5si9378876iop.30.2021.09.07.04.10.44; Tue, 07 Sep 2021 04:10:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=L1brJSz1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245295AbhIGLKX (ORCPT + 99 others); Tue, 7 Sep 2021 07:10:23 -0400 Received: from smtp-relay-canonical-0.canonical.com ([185.125.188.120]:57404 "EHLO smtp-relay-canonical-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241914AbhIGLKU (ORCPT ); Tue, 7 Sep 2021 07:10:20 -0400 Received: from localhost (1.general.cking.uk.vpn [10.172.193.212]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id 604E63F042; Tue, 7 Sep 2021 11:09:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1631012953; bh=5zF7FrF9V3AncSdXcy8cFb4c8MGP7SY6V76Vkh/I5bQ=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=L1brJSz1lVzNGXriF1B/m2YyEUenrHe2nm19rbgu24d4GKSKk9V8OUThntl55BvVw e3ARqvpd+MI3qXRGxzuoVIDAmMEMhJSt8cMtyBw4h/oy4b3I06y2DdDdpp6nEupOew TQUXw197fe4FVSZ/GkzOTAE7Q33gscTwourCjxM+v7lwNPghYO9tZAyzIWAM1qtTaI NskiXGDUfBUTmLjxlU5IJR3cPr5UTInqR/STuSg2lzva618EVAZvw1hWkHezHedILF RbONCzotdC9uzF9rMxBOuqZ7Vc5jmJl6Ej9G5Qp9B9kWy8gTv+5Cf/IlEY3PyZzOPA QzXGpIb42eSMA== From: Colin King To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Xinhui.Pan@amd.com, David Airlie , Daniel Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/radeon/ci_dpm: Remove redundant initialization of variables hi_sidd, lo_sidd Date: Tue, 7 Sep 2021 12:09:13 +0100 Message-Id: <20210907110913.15499-1-colin.king@canonical.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The variables hi_sidd and lo_sidd are being initialized with a values that are never read, they are being updated later on. The assignments are redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/gpu/drm/radeon/ci_dpm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/ci_dpm.c b/drivers/gpu/drm/radeon/ci_dpm.c index f0cfb58da467..ac006bed4743 100644 --- a/drivers/gpu/drm/radeon/ci_dpm.c +++ b/drivers/gpu/drm/radeon/ci_dpm.c @@ -390,8 +390,7 @@ static int ci_min_max_v_gnbl_pm_lid_from_bapm_vddc(struct radeon_device *rdev) static int ci_populate_bapm_vddc_base_leakage_sidd(struct radeon_device *rdev) { struct ci_power_info *pi = ci_get_pi(rdev); - u16 hi_sidd = pi->smc_powertune_table.BapmVddCBaseLeakageHiSidd; - u16 lo_sidd = pi->smc_powertune_table.BapmVddCBaseLeakageLoSidd; + u16 hi_sidd, lo_sidd; struct radeon_cac_tdp_table *cac_tdp_table = rdev->pm.dpm.dyn_state.cac_tdp_table; -- 2.32.0