Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp3727647pxb; Tue, 7 Sep 2021 06:24:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkENJ8PKhMjmVfPsIsFoFbpiGgrWVw2CWAOk+R7g1BinTfC93mx9hcsPg7f/A0VL5l4Em2 X-Received: by 2002:a17:907:766e:: with SMTP id kk14mr18475797ejc.339.1631021061889; Tue, 07 Sep 2021 06:24:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631021061; cv=none; d=google.com; s=arc-20160816; b=ZBCosXOBGvIvlVwvuMJYho7jRFn6iCfvfGjmm2OvFS9qzGhFjXWs3o8YRU/8CfV6Pj U63lFwRUEx2lRAnnwkvXsEbrPJ3MHmfZkg/wpG4dJWAshp4XymziqAdOjyyq5YShTMsi tsGdRkJQrE4z7LHkkCQN1E8WGfAdbr0bhqfOAchOi5rDk7SjUZweeD2powlIb+aztq+K +iFzZE6YHlqoK1WjkAeSvIaE9nJ7oR/+xQJV3x72yY4psRccacdU4l4T3yfIdXUxkjug eCGYNUheT1IZKkpgLZBeuMJu7aimp0lxUR+XTO5W4yX4gl/QMDstiGr38SiPBzBsZqUI UAbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=GjAuECmb4x/wgMblqLwLdx3l5JuBZplnPik7A/fooiM=; b=qudrVEV15mv2vJvidcjEaRKY7SVw8+9Dn2ck83esVVk6qBYV5eZoNqyOBkp+7q6CRG sexpkk25sT2FJGbBxMF3sMaTIBjnOcaq/uBSAZNzleVsmRxlk71Wwmevo7XoK9OoxAp+ v/Um6Hq+cIeuOIVjBCVSxqyfy/T+DoTc2DLy6anIGC1jj6KH+JZthovj/c9W7Z1ReDu3 xW3ohxGpVemReKk8Cz4+gs/Vcn2PYq4xNH8YZXuLaUV/nUTy/0Qz7TgJerIrXwmNTqme KLUa/Hu4CaL546vOM4RdtSqbgtEaL3VJEcbdh5kbIDOXc3bmNhKhI/VaoEEZyvaBtfhc Qalw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mMkwAK0R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p28si9880815ejn.248.2021.09.07.06.23.58; Tue, 07 Sep 2021 06:24:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mMkwAK0R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344465AbhIGMvd (ORCPT + 99 others); Tue, 7 Sep 2021 08:51:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:56206 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344461AbhIGMvc (ORCPT ); Tue, 7 Sep 2021 08:51:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A0E3A610C9; Tue, 7 Sep 2021 12:50:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631019026; bh=eE7IcVilEeLSkeD9jdj8PAa18oA0xgkkm+nApsk0DZk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=mMkwAK0Rz3SOyZykHhBCwE0VBctxlyV5+MgeG+U850enODi2uT/+M2Rq2hug7fwPl qy4h25ZnvOAPLKLXHZyBaldi9EAflsZ6d1zQh/rDC2USXMObmmSCAuB+SOEwnbO83o Ihj4oSxY0GNGNk9BAyC8fKuXSbNtgdDFOBGPXo2SG5VY6k17zTLG0PL+cH3YcZlKyI UC/O1TSbses582KUDzHUTUOkexan8c21j/WHDYTGdsOMe+7j/jE/gnsmntNYB1Sqrd swgW2TS6bWkXz+XDJ+JLi1FGMbE2C9mO3staTvxg60WI05XLVsQGS1gbdjb0vesW/C skvdDHMn9SFrQ== Received: by mail-ed1-f53.google.com with SMTP id q3so13771959edt.5; Tue, 07 Sep 2021 05:50:26 -0700 (PDT) X-Gm-Message-State: AOAM530a4xfavdU0Ezwq/YbD+0CHbRYNYRXzEwTQGVyXfNXYV1jzuHvq J0mG3DO+cgy47u+K4c0uI2Rbo6yFMjFQunXGfw== X-Received: by 2002:aa7:c514:: with SMTP id o20mr18319405edq.318.1631019025305; Tue, 07 Sep 2021 05:50:25 -0700 (PDT) MIME-Version: 1.0 References: <1630661377-31244-1-git-send-email-shengjiu.wang@nxp.com> <1630661377-31244-4-git-send-email-shengjiu.wang@nxp.com> In-Reply-To: From: Rob Herring Date: Tue, 7 Sep 2021 07:50:13 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 3/4] dt-bindings: remoteproc: Add fsl,imx-dsp-rproc binding document To: Shengjiu Wang Cc: Shengjiu Wang , Daniel Baluta , Ohad Ben-Cohen , Bjorn Andersson , Sascha Hauer , Fabio Estevam , Shawn Guo , NXP Linux Team , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , Sascha Hauer , linux-arm-kernel , Mathieu Poirier , "open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 3, 2021 at 9:58 PM Shengjiu Wang wrote: > > Hi Rob > > On Sat, Sep 4, 2021 at 12:50 AM Rob Herring wrote: > > > > On Fri, Sep 3, 2021 at 11:42 AM Rob Herring wrote: > > > > > > On Fri, 03 Sep 2021 17:29:36 +0800, Shengjiu Wang wrote: > > > > Define the compatible string and properties needed by imx_dsp_rproc > > > > driver. > > > > > > > > Signed-off-by: Shengjiu Wang > > > > --- > > > > .../remoteproc/fsl,imx-dsp-rproc.yaml | 131 ++++++++++++++++++ > > > > 1 file changed, 131 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/remoteproc/fsl,imx-dsp-rproc.yaml > > > > > > > > > > Reviewed-by: Rob Herring > > > > I take that back. What's the difference with this binding and > > Documentation/devicetree/bindings/dsp/fsl,dsp.yaml? > > Some devices, but two kinds of driver. one for remoteproc > framework, another one is for ALSA. > So should I merge fsl,imx-dsp-rproc.yaml to fsl,dsp.yaml? You can have 100 drivers for all I care, but it's 1 DT binding for 1 piece of h/w. Rob