Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 7 Sep 2021 10:13:52 -0400
From:   Alan Stern <stern@rowland.harvard.edu>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: ehci: Simplify platform driver registration
Message-ID: <20210907141352.GA571275@rowland.harvard.edu>
References: <20210907123002.3951446-1-linux@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210907123002.3951446-1-linux@roeck-us.net>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Tue, Sep 07, 2021 at 05:30:02AM -0700, Guenter Roeck wrote:
> Use platform_register_drivers() and platform_unregister_drivers() to
> register and unregister ehci platform drivers. This simplifies the code
> and prevents the following build errors seen with sparc:allmodconfig.
> 
> drivers/usb/host/ehci-hcd.c:1301: error:
> 	"PLATFORM_DRIVER" redefined
> drivers/usb/host/ehci-sh.c:173:31: error:
> 	'ehci_hcd_sh_driver' defined but not used
> 
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> v2: Explicitly include platform_device.h.
>     The ps3 driver is not a platform driver, so we still have
>     to handle it separately.

Acked-by: Alan Stern <stern@rowland.harvard.edu>