Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp3802485pxb; Tue, 7 Sep 2021 07:55:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxDTdpqrsEGIUGuEciVJTJuvN9ylmizusgaZT6yUs3zpFGvh6aVbtCJcBxYz5beOK+4i67u X-Received: by 2002:a17:906:1b14:: with SMTP id o20mr19829282ejg.154.1631026504675; Tue, 07 Sep 2021 07:55:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631026504; cv=none; d=google.com; s=arc-20160816; b=rrLAWNYMVeY9hCn+WKf01y92mx7t986KdTBw4xhwtIzbeFqIyMF6nizC3WGcob9l+7 9rTOGziDdYzsJMRFZ9M+URRzdhh3M6zOX5RdMbmMKc0VnPnGiEEdDtSeyEyWd9ilw9yc t1+/0MVUF+vFcC+nTNzr9WaXM4B/ji43KCIRB0spD8/pLidadEwkY0fz/b05jKVV7cVC vCaRVusn264RRZcexozcVUJtMdRwfFzm/FypdPOS2LzKWM04XyedYrqqa/7Ij+LVmcw5 Rx2OUqFiilGvMWSaqXfovRW7SiwxR2wdg0yKE4mu1TrUNH6cEyRd0fK4lhNkPhSAuK4W 7Eew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:dkim-signature:date; bh=fYYAhddDemABUotAB/OBIyzAeMlEp/qZ4ORFFCRB3UM=; b=UX1RXjhjrF/fyvG9HAxaFCdliXr+N+iaSwdPJrMgy2HY2HppAzDuCTZlwiFRUcaqEI grOmOxor0ksz8ssjSQ40VolVuJLuIG2SNHXDiAzHetKUCjSiQMGuZn1nBsGbmN/u5G9U OhcqPLPf9JhaIQZa3xrbBpfHPLYOdNCyouOmHhSTddJRwUGiNI1Vjs07RVbgrQHGkTLW CDhKs9R+4OdcmFhdWRX0rSUeDOr0XFVyXGrtfeYfR1Yn0CNKBqcSLXfX/Z0kWnpKr6Zn FRyhaVLwjVof3T73JvvjzFZV1cF3siLBKA6/YBmL+mqLq98ZkqeE441LKsed41tH6Kit 1mNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=VgWipVka; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dh19si10778847edb.198.2021.09.07.07.54.40; Tue, 07 Sep 2021 07:55:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=VgWipVka; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244725AbhIGOxr (ORCPT + 99 others); Tue, 7 Sep 2021 10:53:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231362AbhIGOxq (ORCPT ); Tue, 7 Sep 2021 10:53:46 -0400 Received: from todd.t-8ch.de (todd.t-8ch.de [IPv6:2a01:4f8:c010:41de::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77180C061575; Tue, 7 Sep 2021 07:52:40 -0700 (PDT) Date: Tue, 7 Sep 2021 16:52:38 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=weissschuh.net; s=mail; t=1631026359; bh=rBR2zR4qYK5bAv6dYBRzzsHRiX1WFHqQpOc1+JsquVI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VgWipVkapyOEVwkfXw+q6eXUANQ9cUfmpjzqHwb4QWB25rRkA3+bF/T+Z5SqBAKwD /5C5jJSOgfjDbtrQ7H4Ia4YP8ZfXNzBzNxpvVyD8/K4b47ZXTxqzMvNA/4yCGMKY3t Dh9Si6RIr6Jf78amtbnYa3FsB5kg80tnhGA8ABnE= From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Daniel Thompson Cc: Lee Jones , Jingoo Han , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] backlight: propagate errors from get_brightness() Message-ID: References: <20210907124751.6404-1-linux@weissschuh.net> <20210907131005.vvaitvcllbte37zp@maple.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210907131005.vvaitvcllbte37zp@maple.lan> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-09-07T14:10+0100, Daniel Thompson wrote: > On Tue, Sep 07, 2021 at 02:47:51PM +0200, Thomas Weißschuh wrote: > > backlight.h documents "struct backlight_ops->get_brightness()" to return > > a negative errno on failure. > > So far these errors have not been handled in the backlight core. > > This leads to negative values being exposed through sysfs although only > > positive values are documented to be reported. > > > > Signed-off-by: Thomas Weißschuh > > Reviewed-by: Daniel Thompson Thanks! Thomas