Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760802AbWLHSNs (ORCPT ); Fri, 8 Dec 2006 13:13:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760801AbWLHSNs (ORCPT ); Fri, 8 Dec 2006 13:13:48 -0500 Received: from tmailer.gwdg.de ([134.76.10.23]:46990 "EHLO tmailer.gwdg.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760788AbWLHSNr (ORCPT ); Fri, 8 Dec 2006 13:13:47 -0500 Date: Fri, 8 Dec 2006 19:03:00 +0100 (MET) From: Jan Engelhardt To: Josef Sipek cc: "Josef 'Jeff' Sipek" , linux-kernel@vger.kernel.org, torvalds@osdl.org, akpm@osdl.org, hch@infradead.org, viro@ftp.linux.org.uk, linux-fsdevel@vger.kernel.org, mhalcrow@us.ibm.com Subject: Re: [PATCH 26/35] Unionfs: Privileged operations workqueue In-Reply-To: <20061208174306.GA22299@filer.fsl.cs.sunysb.edu> Message-ID: References: <1165235468365-git-send-email-jsipek@cs.sunysb.edu> <1165235471170-git-send-email-jsipek@cs.sunysb.edu> <20061205195013.GE2240@filer.fsl.cs.sunysb.edu> <20061206173245.GA23405@filer.fsl.cs.sunysb.edu> <20061208021714.GA14363@filer.fsl.cs.sunysb.edu> <20061208160038.GA17707@filer.fsl.cs.sunysb.edu> <20061208174306.GA22299@filer.fsl.cs.sunysb.edu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Report: Content analysis: 0.0 points, 6.0 required _SUMMARY_ Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1155 Lines: 36 On Dec 8 2006 12:43, Josef Sipek wrote: >> On Dec 8 2006 11:00, Josef Sipek wrote: >> >> +void __unionfs_mkdir(void *data) >> +{ >> + struct sioq_args *args = data; >> + struct mkdir_args *m = &args->mkdir; >> + >> + args->err = vfs_mkdir(m->parent, m->dentry, m->mode); >> + complete(&args->comp); >> +} >> >> >> The members of m (i.e. m->*) are not modified as for as __unionfs_mknod goes. >> >> vfs_mknod may only modify the members of m->parent (i.e. m->parent->*) >> > >> >Yes they are. The return value is passed through a member of m. >> >> Where - where do you see that m->parent, m->dentry or m->mode are modified? >> (The original submission is above.) > >args->err is modified. If args is declared const, gcc complains. I never said making "args" const, but rather [-> http://lkml.org/lkml/2006/12/5/210 ] I said: "Care to make that: const struct mknod_args *m = &args->mknod;?" -`J' -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/