Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Niklas Cassel <Niklas.Cassel@wdc.com>
To:     Jens Axboe <axboe@kernel.dk>
CC:     Bart Van Assche <bvanassche@acm.org>,
        Damien Le Moal <Damien.LeMoal@wdc.com>,
        Paolo Valente <paolo.valente@linaro.org>,
        Ming Lei <ming.lei@redhat.com>,
        Niklas Cassel <Niklas.Cassel@wdc.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH 0/2] don't call io scheduler callbacks for passthrough
 requests
Thread-Topic: [PATCH 0/2] don't call io scheduler callbacks for passthrough
 requests
Thread-Index: AQHXo/O1SmyNM8u59EWUacCSWXPwmA==
Date:   Tue, 7 Sep 2021 14:21:54 +0000
Message-ID: <20210907142145.112096-1-Niklas.Cassel@wdc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?yM8FrrizDfsNEFfoAT6jq8xeKgczVQ72HkgBjFi0QnGwIuHoQH8HF6ZyhQ?=
 =?iso-8859-1?Q?sQ+Mq8s6RFNJI0NIF+pgHQgIX/0ccElql1PzGBssKEx99J+FKgMnQeG6Ir?=
 =?iso-8859-1?Q?+ehrJz3TMQ0qvdkgxY3vEZiLM1sd8EXatPPhGlBJguYDOMlszSv3kLRf2d?=
 =?iso-8859-1?Q?E0KwfT5mGs/VZTbgT6M791vK/Eo9SMfLNKW3OEHgyBfAklW9UF3cZjOHsP?=
 =?iso-8859-1?Q?EE6IyE4LF/g9FXD36oj1tjpCCzm9VM7C6snbJLCHwlUazQA/2FXRJJ0BAP?=
 =?iso-8859-1?Q?Q95tflWGY/5e2oD56uetHsBS3e/1fgzJYPsEmjSinms93vpnclxbo6fR0y?=
 =?iso-8859-1?Q?GmYj+Ptb3ig4fxaYmjDh82OKrrcj5YiiZAuGrGIe28aPlTQfCsvkZzD6Ht?=
 =?iso-8859-1?Q?WVDQYTo9LyUf7j7T0dnM+91Kf1I+b3OWaITc8ej9wAVD9IHtNccIJTx3sn?=
 =?iso-8859-1?Q?C7+6VYednGxjZp8mzHfiuW6SIdxy/dxhVYnox3bzeqDpjvjeG0BwDp/8V1?=
 =?iso-8859-1?Q?AwuACESZ8xqdycRmdbEhg1q0uxyPjoaOzn22xkqJwqY60ue5RDeaGqGhkT?=
 =?iso-8859-1?Q?B7NJ9XD7UliFLiaP2EMUoRjv5WjNlsxFZLXlFGTT1YaBxd9cslF36wjFKM?=
 =?iso-8859-1?Q?OjSrYu6uSA9Q2uISDW5PUBehEwUR0G9CF9ZdfuGd3qHUVwHwNnxNwCFfCb?=
 =?iso-8859-1?Q?xVLM5fdg2X8CDOr70xzviOzND3HdPnEi4Hy4lOWCtIaZLILcjRxKNzl4rO?=
 =?iso-8859-1?Q?PsM4AFVTGLqs1ixlRIvnYppASxBvcMl4SFmoUKk2fp7RKW7lprDTYOcbJX?=
 =?iso-8859-1?Q?dvwhwXVBhPdNPHoBKsaqyIa1GeTdN4AvXTBZPFtFY04ZGxzWuk3L18sZnF?=
 =?iso-8859-1?Q?CpscLoxUml1MnT4XaYJTiDdizDNhERVOaNMXCsT58cgnk6e+A447RPHWHP?=
 =?iso-8859-1?Q?oKks6Vvjj2cr6coILB411JJqZF7KMUK/+uFTfLFBqNcXC3bTk4CaBu1ikN?=
 =?iso-8859-1?Q?I/c/Tl5HdJhNL31PGkCVd0Z/r9DTkfe78BLgmcjsiYTJN2d97MyQ4nFgrG?=
 =?iso-8859-1?Q?sEVAsLEQhteZKZb11WcCZEKjvx4n3qk0KhZz9+BsE32CdU0/b7usum8AyY?=
 =?iso-8859-1?Q?pdlKLI5riDI1et2ceYmaoYVRQFp2NqjuJeQwcNTh1YSEFweGcwkkrkpwAA?=
 =?iso-8859-1?Q?f8zHDlbfSydj2G4oOz4bJAKYuN7OcQi28fx5cPIXWguvdy2YAwYKt01gDy?=
 =?iso-8859-1?Q?UIcnWad+dPa5/xzjLUm0LQX9GP1Inyelzxq/ezkp5QZMIAJi3LgSmphcMe?=
 =?iso-8859-1?Q?8ADmjQU98gZZLTuUMOeXTOsSlOOhkKzjeMsdrnuk1f5cITC/4wfQ6QIoVA?=
 =?iso-8859-1?Q?q3JKD893nNPDH9jf5OqD21UXcn7RxUNA=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR04MB7158.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 188ea190-c8d1-42f7-bab9-08d9720ad7c0
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2021 14:21:54.2775
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OYn9hipk9xnDQ40AF0EZonEn2+PpN65FRxBwRIAZFucuh4lkDdP9Eqq6lghj3hqwQTEdtREaSTv2my9RQnZ8Vw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR04MB7382
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Niklas Cassel <niklas.cassel@wdc.com>

Recently, there were some extra "dummy" data added into mq-deadline
rq->elv.priv, that was added for the solve purpose of working around
quirky behavior in blk-mq (which called the scheduler callbacks even
for requests that bypassed the scheduler).

Fix blk-mq to not call the I/O scheduler callbacks for passthrough requests=
,
since they will later bypass the I/O scheduler anyway.

This way, we can remove unnecessary logic in mq-deadline that was added to
deal with this quirky behavior.

BFQ should be able to perform a similar cleanup, if they wish, and should
then be able to drop this comment from the code:
https://github.com/torvalds/linux/blob/v5.14/block/bfq-iosched.c#L6456-L646=
2

Considering that I'm quite unfamiliar with the BFQ code, I'd rather
someone who is a bit more familiar with BFQ performs that cleanup.


Kind regards,
Niklas

Niklas Cassel (2):
  blk-mq: don't call callbacks for requests that bypassed the scheduler
  Revert "mq-deadline: Fix request accounting"

 block/blk-mq.c      |  7 ++++++-
 block/mq-deadline.c | 16 +++++-----------
 2 files changed, 11 insertions(+), 12 deletions(-)

--=20
2.31.1