Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Minchan Kim <minchan.kim@gmail.com>
Date:   Tue, 7 Sep 2021 10:00:35 -0700
From:   Minchan Kim <minchan@kernel.org>
To:     Jaewon Kim <jaewon31.kim@samsung.com>
Cc:     Christoph Hellwig <hch@infradead.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        YongTaek Lee <ytk.lee@samsung.com>,
        "jaewon31.kim@gmail.com" <jaewon31.kim@gmail.com>
Subject: Re: (2) [PATCH] zram_drv: allow reclaim on bio_alloc
Message-ID: <YTeas6sPrvQKmUHG@google.com>
References: <YTXTe3U8RrvSAynl@infradead.org>
 <20210906052926.6007-1-jaewon31.kim@samsung.com>
 <CGME20210906052847epcas1p1f53f1ad04ad785d53f64eef150969c34@epcms1p6>
 <20210906091448epcms1p6bcc1f11b0da18e215219e6868ed07914@epcms1p6>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210906091448epcms1p6bcc1f11b0da18e215219e6868ed07914@epcms1p6>
Precedence: bulk

Hi Jaewon,

On Mon, Sep 06, 2021 at 06:14:48PM +0900, Jaewon Kim wrote:
> > 
> > 
> >--------- Original Message ---------
> >Sender : Christoph Hellwig <hch@infradead.org>
> >Date : 2021-09-06 17:39 (GMT+9)
> >Title : Re: [PATCH] zram_drv: allow reclaim on bio_alloc
> > 
> >On Mon, Sep 06, 2021 at 02:29:26PM +0900, Jaewon Kim wrote:
> >> The read_from_bdev_async is not called on atomic context. So GFP_NOIO is
> >> available rather than GFP_ATOMIC. If there were reclaimable pages with
> >> GFP_NOIO, we can avoid allocation failure and page fault failure.
> >> 
> >> Reported-by: Yong-Taek Lee <ytk.lee@samsung.com>
> >> Signed-off-by: Jaewon Kim <jaewon31.kim@samsung.com>

Looks reasonable to me.
Feel free to add after dealing with Christoph's comment.

Acked-by: Minchan Kim <minchan@kernel.org>

Thank you.

> >> ---
> >>  drivers/block/zram/zram_drv.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >> 
> >> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> >> index fcaf2750f68f..53be528a39a2 100644
> >> --- a/drivers/block/zram/zram_drv.c
> >> +++ b/drivers/block/zram/zram_drv.c
> >> @@ -587,7 +587,7 @@ static int read_from_bdev_async(struct zram *zram, struct bio_vec *bvec,
> >>  {
> >>          struct bio *bio;
> >>  
> >> -        bio = bio_alloc(GFP_ATOMIC, 1);
> >> +        bio = bio_alloc(GFP_NOIO|__GFP_HIGHMEM, 1);
> > 
> >Passing __GFP_HIGHMEM to bio_alloc does not make any sense whatsoever.
> > 
> Correct, let me remove __GFP_HIGHMEM if I send v2 patch.
> Thank you