Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210830172820.2840433-1-jiancai@google.com> <20210906150625.GA1228692@p14s>
In-Reply-To: <20210906150625.GA1228692@p14s>
From:   Doug Anderson <dianders@chromium.org>
Date:   Tue, 7 Sep 2021 10:51:53 -0700
Message-ID: <CAD=FV=Ukx_PRpfnLXEBajtts78ays=6+nGb+CRVn76xjyNkn5A@mail.gmail.com>
Subject: Re: [PATCH v2] coresight: syscfg: fix compiler warnings
To:     Mathieu Poirier <mathieu.poirier@linaro.org>
Cc:     Jian Cai <jiancai@google.com>, Mike Leach <mike.leach@linaro.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Matthias Kaehlcke <mka@chromium.org>,
        Manoj Gupta <manojgupta@google.com>,
        Luis Lozano <llozano@google.com>, coresight@lists.linaro.org,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        clang-built-linux <clang-built-linux@googlegroups.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Leo Yan <leo.yan@linaro.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Mon, Sep 6, 2021 at 8:06 AM Mathieu Poirier
<mathieu.poirier@linaro.org> wrote:
>
> On Mon, Aug 30, 2021 at 10:28:19AM -0700, Jian Cai wrote:
> > This fixes warnings with -Wimplicit-function-declaration, e.g.
> >
> > drivers/hwtracing/coresight/coresight-syscfg.c:455:15: error:
> > implicit declaration of function 'kzalloc' [-Werror,
> > -Wimplicit-function-declaration]
> >         csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev),
> >                              GFP_KERNEL);
> >
> > Fixes: 85e2414c518a ("coresight: syscfg: Initial coresight system configuration")
> > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> > Signed-off-by: Jian Cai <jiancai@google.com>
> > ---
> >
> > Changes v1 -> v2:
> >   Format the commit message and add Fixes and Reviewed-by tag.
> >
> >  drivers/hwtracing/coresight/coresight-syscfg.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
>
> I have applied this patch to my local tree.  I will push it to the coresight-next
> branch when 5.15-rc1 is published next week.

Out of curiosity, does the fact that it'll be in coresight-next mean
that this will target v5.15 or v5.16? I usually think of "-next"
branches as targeting one major version later, so I'd assume v5.16?
...but it would be nice if this warning could get fixed somewhere in
v5.15.

Thanks and sorry if this was obvious and I just didn't know.

-Doug