Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 3/3] namei: Standardize callers of filename_create()
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210901175144.121048-1-stephen.s.brennan@oracle.com>
 <20210901175144.121048-4-stephen.s.brennan@oracle.com>
 <YTfH6RW+3+5kVD+y@zeniv-ca.linux.org.uk>
From:   Stephen Brennan <stephen.s.brennan@oracle.com>
Message-ID: <7e6cfce8-7fad-a55f-c1b6-47db62da4344@oracle.com>
Date:   Tue, 7 Sep 2021 13:35:12 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <YTfH6RW+3+5kVD+y@zeniv-ca.linux.org.uk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzFzNHpyZkVORkgxblM4V3hJdlhpUGZxVzczS2NWT0lXV0piNXNjMzBOTm44?=
 =?utf-8?B?S0dHSWY2MlZteS9CN2pPOXlVdDNsbEl5ZEZ0SVpodUhTdEZjSGZKRTNXS0FG?=
 =?utf-8?B?YmFNdkNHRjVpTHZtSHYxQWtkd2l2eU9Bb1BBdVpiazZyZEJpa2xvZGhKNmIv?=
 =?utf-8?B?NFVUbHBMZjRnMGtQcDJlNFpQdkwvSzZYZisxL2FTRG14UWZqeVJaWEE2dVUw?=
 =?utf-8?B?RDdyQVQ2cEMzTzVDdVhjbUJvUEdUNEFvdXNsY21NbTRVNHdqQk5tVEZDL2Iw?=
 =?utf-8?B?OENGTFIzUnI0eFB4Ykc1K0ZEOHMreTdjYlp3RU9RbkJ6UG5NY3lzblAyd1hh?=
 =?utf-8?B?Y1lSS0JIZzNmcDlEQmN3MUhtOUs5emcvaWtjeThwSGpNWDZnQUErZjBGLzgy?=
 =?utf-8?B?dWZibjFWSjZxUzVsSkpTNzMwaHlwcFFpSEVHaVZpSjBrMVA0RFlpQ3AzbzFJ?=
 =?utf-8?B?RUZXQXhnaC9zQ2V4eWtWSXVLNjZiQlZlTm04ZU5ZRHgvWDJHK2RmbEkxQVVF?=
 =?utf-8?B?QTR2T3FXRjlmRDROMk50TnFNZzlTMHlTVzFFWGozK0MrMXE4MmRNaUt4R0JI?=
 =?utf-8?B?dFRWQkRaNGEvMnczQzVucWVodkt3K0RHemhHcnRlcitwNWZ3Q0s2M3ZqVmtL?=
 =?utf-8?B?aG9pQ3dxQXZzYjVYVkdUU3dFM1dzUEtvQWNnZ2NZYXJyaFRaRmFjQWl4MFFr?=
 =?utf-8?B?aVVHRDFxTDR6Z3d3UTJGeEl1by9sZU1BVkVIdmpLVk4zZlB2STVpSHJSU25h?=
 =?utf-8?B?MDFNRlZhMCt6ejUyZUYrTjdueUU4aGQ0M3c1dU40d2I1ajU5LzlZbFJ4NW9L?=
 =?utf-8?B?N2JQMS9aSDVuS1NlSDF2endWbTNFNmR4dFREekgrdklKZVdNM09QZktxS21x?=
 =?utf-8?B?bUxRbE94MkVpSjBRc1VFVEVxQjYybEVNMVozWjZKMnNRRGJaODg1aWJNeFZ6?=
 =?utf-8?B?OGlZV1AzbTQwKzNkQjNDY08rZmdPcW9CcSswNE1yOW16bTZOWms5dThQNmhL?=
 =?utf-8?B?Y2V1M1VDVFRBMklpaEFWNGY4RUYrQnZ5ZlVRR3pDV1UrYVErTDRrR2NxbUlI?=
 =?utf-8?B?SWFXaEkwZi9hY3REY3BQM082Rm5ERENkT3czWW9na1lJVHZINzN4N3M3ZGx2?=
 =?utf-8?B?SVVGV1Y1R2pCZXNOVWp4VHhrQ1U1WTk3dndTb3U2MzBXWjl3amNwa0VtZ3Mw?=
 =?utf-8?B?Q2ZqM3VnSUZVeVpleDUyaVRKSE9LeE1LcjY1SDNJWm84OTM3U2k0elh6eVJV?=
 =?utf-8?B?ampOQUFzT29kTW1CSUdZZkJWYTZZU1daWGliZWNENDltbW96TmhhMDNPdEVq?=
 =?utf-8?B?N3l0b2JyY3RZazBWU1Y1TDloa09MeGRJWWcvSWJRWEI2WDJPRS8weGQ1RzU1?=
 =?utf-8?B?d0gySGdtMkZMTkVvdUpaYnNGVlJIL3RQdHdmMUM4M1NRMWxDVSsyT0pRTTU5?=
 =?utf-8?B?VFNUSHR5YTJIYWxBdUhHWmpIdG9HckNTOVhzRzRlcC9jaS9MYVB6YmtCb1JB?=
 =?utf-8?B?Vk1MWDVzRnV3cnJ5a01iMjdDZElKZ25JbUs0TS9nN0h2WC9HOUhjUmd2WHo2?=
 =?utf-8?B?VnA0emJJQUR6ZjVON3djRENYOWRPb01Gcy9rNTQ1UGlmSXlmY0xVc2pjdVBN?=
 =?utf-8?B?b0NaOXlFY28xVEVTcnFjdzdpZVpNME0weFFmWk81RVZtWk9tMi90cUk0M0ho?=
 =?utf-8?B?SkRrQlIrWmF6RlNWaUh0dzMzVndzc0tqR1JIdFUvRjF6cHF2bnluUXR4cEoz?=
 =?utf-8?Q?C9oPhhQ4Mv9CDVRJhHD+2+UMr3Kj+tE7CMFNwQT?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c3859d0-f1fe-468b-afc1-08d9723efecf
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4166.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 20:35:13.9144
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vY9YycuG0ZOLlEVojfFztOUFVh8aqq7WdQZSXrH2tRxoSItfc54SXJVyojC0Nq57ZUWqNZHc53HEgVdTV4efFqeM11q94z+uXN9QaQWIQRs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB3783
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10100 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0
 malwarescore=0 spamscore=0 mlxscore=0 phishscore=0 mlxlogscore=999
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109030001 definitions=main-2109070130
X-Proofpoint-ORIG-GUID: RuC-r-upw0GHNEx7sPaUAjZIItOzO-Zz
X-Proofpoint-GUID: RuC-r-upw0GHNEx7sPaUAjZIItOzO-Zz
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/7/21 1:13 PM, Al Viro wrote:
> On Wed, Sep 01, 2021 at 10:51:43AM -0700, Stephen Brennan wrote:
>>   inline struct dentry *user_path_create(int dfd, const char __user *pathname,
>>   				struct path *path, unsigned int lookup_flags)
>>   {
>> -	return filename_create(dfd, getname(pathname), path, lookup_flags);
>> +	struct filename *filename;
>> +	struct dentry *dentry;
>> +
>> +	filename = getname(pathname);
>> +	dentry = filename_create(dfd, getname(pathname), path, lookup_flags);
>> +	putname(filename);
>> +	return dentry;
> 
> Leaks, obviously...
> 

Ouch, thanks for the catch. I'll send v2 shortly.