Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Stephen Brennan <stephen.s.brennan@oracle.com>
To:     Alexander Viro <viro@zeniv.linux.org.uk>
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] namei: fix use-after-free and adjust calling
 conventions
In-Reply-To: <20210907205043.16768-1-stephen.s.brennan@oracle.com>
References: <20210907205043.16768-1-stephen.s.brennan@oracle.com>
Date:   Tue, 07 Sep 2021 14:44:51 -0700
Message-ID: <87r1e0rrfw.fsf@stepbren-lnx.us.oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MvqbMbet8c6ijG2cc2CqSbb+jp267B1iJwrdbNXxHviYCdtIhfU13rcS3E4L?=
 =?us-ascii?Q?xfUoxE7TVVSdDVIQv04FTOdurtk6Useaq2mykUaknwLkYQk/AzandTCZZJOP?=
 =?us-ascii?Q?oc278dszaGUE54ucnDbObyLujOPp7Ru0RH4Z4i4NWN8D1Be1crs1unvSvrtL?=
 =?us-ascii?Q?JMOg3tBxfATLMyicte3/yZqEsKCRySXgLDj6lJEet6R7wwX1B4G+SN++9PxC?=
 =?us-ascii?Q?5mSTD74eLVOhyDDJTTFAj9R1PYPp2i4G1AYkCuZMxa19PkRTwiXZ1JL+0fkN?=
 =?us-ascii?Q?/fPNf7S3kfcvlrIjeWfv0gkl5sSrxPPiI+OT1Eu3U01/AZzm0vrN+gY+IcrV?=
 =?us-ascii?Q?AB+cvkkw0OksyZy12FwdpkZ9At9v3IRCbmYhmKMOQjt6sgnCd/IY+tdPo6Vf?=
 =?us-ascii?Q?PtPANgWV3mRP5LCVa+7c+9GzgnJk8tNgkiJBoQT8VvS7rLXdHbrTULul1bQv?=
 =?us-ascii?Q?zEZ3tPtVI7pJcFOAmljj9YvVKhc/Hr9FtpM6whqop+pAmK3zEf9mij0zieq/?=
 =?us-ascii?Q?Tv4KKFHI05cdIlgLT82WwdEQxys1r38RvzJRUlhiSBIgoJc0tDXg3gKoZEUF?=
 =?us-ascii?Q?zrxDe0rEKKiyGWht5PJGMNDqLTX8goIhmIVffoIDX8x2YCc6S2DWZGw7AiOU?=
 =?us-ascii?Q?WRR2RWnjrmezQ2yE2kqZV4GlrQSe8IFYO4kdiLQm30aoaL/k34rDRzKi9OPA?=
 =?us-ascii?Q?U8KAe5orybblHLiU+RmTkPIv9/FM5caicMKMxrcKJXvkfd2LG2q+vHM4SCbc?=
 =?us-ascii?Q?gLUcUX/74fzpEk8AL3EtngW8IzHJrNfNX7E1cVfDd+j5d3Yiak1W7d6CS2c4?=
 =?us-ascii?Q?ijve6mWlYsy5olTTCqMfyhY4e4iCuXBLjOs7auMTWj1Nz7Fkk2nkRPIVeu7z?=
 =?us-ascii?Q?+n1+YBCyO1cuuxadJ3X+nGFySe8QkbEIwf28IzNLN58TUzjgPDkYOOpTDWWo?=
 =?us-ascii?Q?36x5zlxW8pchexjwnBlSN76buLbz+KjHPlq02HRQZgtesHHKd/HuUUIQemX3?=
 =?us-ascii?Q?RRlxlBAnYAe+WgAqOSVAV2znQpk8NfBgVImGisky+rb7580THuKTTuJJOdpZ?=
 =?us-ascii?Q?Sth6oe6wW0ybMIP8q6vXss1+oqyS83xv2dvgUroe8FGH99rrbIyC2UnBo9JX?=
 =?us-ascii?Q?AUzkFmNI68fC1JOwCbL5gdao0x5WHFny8AyhwYLx9sgpWY9/SWAVx+NN4Knf?=
 =?us-ascii?Q?Vo+Rn4446aT4PcjHfFMvDxJ8zSv9WOcicQunMMpos1ApDqWRwyp+BDhHYh/K?=
 =?us-ascii?Q?srQ1xBPxvA3Z/wDZuDHTeXNmJfSPVPKfDuNyUUFyun9wC9PAwIW1kRo2Va74?=
 =?us-ascii?Q?nUaGqefFWyropQIUcIEg94Ev?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e35cbdf6-1d10-4eb3-2ae4-08d97248b996
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4166.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 21:44:52.7604
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Nyx86XafqHds+OlsSugBGdZvTAylgQGJqDKgCdPiFLWaA/hXXN9qheoNixE8c61Dx9D1AgTfVgRvOCaZJW0TCpAE5w7zQ6iA5r1hDRsWFOE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4199
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10100 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0
 mlxscore=0 adultscore=0 phishscore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001
 definitions=main-2109070136
X-Proofpoint-ORIG-GUID: A1iHeVVWqay795EXZnpDGoIAzTpB9Cob
X-Proofpoint-GUID: A1iHeVVWqay795EXZnpDGoIAzTpB9Cob
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Stephen Brennan <stephen.s.brennan@oracle.com> writes:
> Drawing from the comments on the last two patches from me and Dmitry,
> the concensus is that __filename_parentat() is inherently buggy, and
> should be removed. But there's some nice consistency to the way that
> the other functions (filename_create, filename_lookup) are named which
> would get broken.
>
> I looked at the callers of filename_create and filename_lookup. All are
> small functions which are trivial to modify to include a putname(). It
> seems to me that adding a few more lines to these functions is a good
> traedoff for better clarity on lifetimes (as it's uncommon for functions
> to drop references to their parameters) and better consistency.
>
> This small series combines the UAF fix from me, and the removal of
> __filename_parentat() from Dmitry as patch 1. Then I standardize
> filename_create() and filename_lookup() and their callers.
>
> v2: Fix double getname in user_path_create()
>
> Stephen Brennan (3):
>   namei: Fix use after free in kern_path_locked
>   namei: Standardize callers of filename_lookup()
>   namei: Standardize callers of filename_create()

Please ignore this! I missed some feedback from Al and will send a v3.

>
>  fs/fs_parser.c |   1 -
>  fs/namei.c     | 126 ++++++++++++++++++++++++++-----------------------
>  2 files changed, 66 insertions(+), 61 deletions(-)
>
> -- 
> 2.30.2