Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp109991pxb; Tue, 7 Sep 2021 19:11:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwEcD1kT87ybi2Cc/a9EeEA/Oo3nlvHYFYZoNH3vwztPq8+Hiqh9kMRRAKoLxTMo1nuA+NT X-Received: by 2002:a05:6402:4247:: with SMTP id g7mr1360078edb.287.1631067109135; Tue, 07 Sep 2021 19:11:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631067109; cv=none; d=google.com; s=arc-20160816; b=RRD1tuI5fMdsG1uxgHtpAhdxk+lv4vGrYQob8L32s/DRt22umdyclOYExpsA9805IK GjJgu8sRhFXomWRehbvoyk2Tf6PzalIcrXmSXJLq2jvCFo/1A/iLoAPPMWoEDoKy1ko2 HvpvkTpk9nLfJf9KKzKL2lShhow/5CcbusPco47Zjy8VYylRuWCPRDOJiHiXsZsQX38g 9Lgc805A250y66n6JhQ1EGBfW0S5EQrDDcabEWEsixTunwttxlhYBSrP6xhv2/WikVV6 vckdaRPc5U5/kF41iXWx3swf5uNzI/GCiFO7wo5DGITLQeByiqXmTgapvT7sTTl1LEW0 31Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=/mucwWCk5V2oAMyBRw4ZkKLq5X0v3EODG85wHDA+v/A=; b=ZSIoUXsWkzTDGhFm71fP3piHDMrkN7C4wQYyRJeLLqH8G6LAemxxFpCJlQZ84KRiLi EJEl8y2WFNeJvopG7ernCn7gl9rJyTDr91SdQLeT3T6j5Lcz7uiQOKLLP4ktb7X4ZG8p Y6j2TbYc3mNjmXs2NFFGHcq4IU4vUDo77tWtHEPq9RmnPu1muGABBsQwz4MIIABwce3Z gGi3F3eGexquHMMqLtzrqXZIeBQIpkd59Ldcb4dzcch3+3XAUjAsbwNM+su5HkbE5a2M WoDVQvGcumyqEjo97PppnlKd4Z26MLNRMSIGQHJOjpGXpjpzHy4oSlepU9ZgzE1BNoyx HWSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ht11si734703ejc.559.2021.09.07.19.11.03; Tue, 07 Sep 2021 19:11:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235450AbhIHBS1 (ORCPT + 99 others); Tue, 7 Sep 2021 21:18:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:41444 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231577AbhIHBSZ (ORCPT ); Tue, 7 Sep 2021 21:18:25 -0400 Received: from rorschach.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9D8C461131; Wed, 8 Sep 2021 01:17:17 +0000 (UTC) Date: Tue, 7 Sep 2021 21:17:14 -0400 From: Steven Rostedt To: qiang.zhang@windriver.com Cc: bristot@redhat.com, bristot@kernel.org, mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] trace/osnoise: Fix missed cpus_read_unlock() in start_per_cpu_kthreads() Message-ID: <20210907211714.696cca61@rorschach.local.home> In-Reply-To: <20210831022919.27630-1-qiang.zhang@windriver.com> References: <20210831022919.27630-1-qiang.zhang@windriver.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 31 Aug 2021 10:29:19 +0800 qiang.zhang@windriver.com wrote: > From: "Qiang.Zhang" > > When start_kthread() return error, the cpus_read_unlock() need > to be called. > > Fixes: c8895e271f79 ("trace/osnoise: Support hotplug operations") > Cc: # v5.14+ FYI, no need to add the "# v5.14+", as it also breaks my scripts. The "Fixes:" tag is now used to know what stable releases it needs to be applied to (if any). Daniel, that goes for you too, as you suggested it ;-) -- Steve