Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Zhang, Qiang" <Qiang.Zhang@windriver.com>
To:     Steven Rostedt <rostedt@goodmis.org>
CC:     "bristot@redhat.com" <bristot@redhat.com>,
        "bristot@kernel.org" <bristot@kernel.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] trace/osnoise: Fix missed cpus_read_unlock() in
 start_per_cpu_kthreads()
Thread-Topic: [PATCH v2] trace/osnoise: Fix missed cpus_read_unlock() in
 start_per_cpu_kthreads()
Thread-Index: AQHXng/wEiXsIqQmAkaGQHjRJAFSz6uZYmMAgAAVa30=
Date:   Wed, 8 Sep 2021 02:34:46 +0000
Message-ID: <BL1PR11MB5478CF84562E63476BB1472AFFD49@BL1PR11MB5478.namprd11.prod.outlook.com>
References: <20210831022919.27630-1-qiang.zhang@windriver.com>
 <20210907211714.696cca61@rorschach.local.home>
In-Reply-To: <20210907211714.696cca61@rorschach.local.home>
Accept-Language: en-001, zh-CN, en-US
Content-Language: aa
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WctGETJ61iigU54zIbbqUikWqiSdKvveamT30rFUfUIQHnxBPmua3BmqRGV/?=
 =?us-ascii?Q?Xg+4Cg8BME2HqZoL68BflljEJfxfR5+nbmdWI4D3Z7eYFxv0A3MWZH8kHTQ6?=
 =?us-ascii?Q?SLqrqbHvZgiA2AgpJWC2y6Lon9szdalsJ4usbiksTkxQXvWrt29Oo93E/twc?=
 =?us-ascii?Q?z092QWf3zyPG8EDle97DWJN3+IMb9BIU0VCcKbC7HNC/5bto4XGgZX8AEEko?=
 =?us-ascii?Q?AzJTJy0nZH5WHYNfqf0fWZCy1C/ZMuE4maQaEqKpEJuIo4/NGQIweFZPZQA1?=
 =?us-ascii?Q?hHEIOVoklX1rM7dnovZrGnVWTVE4AkuHzJOJ2kTSPcEH4cjV4B7GviXtxCgN?=
 =?us-ascii?Q?qpbw7dMFUO6D9voNJ/V4pu3dkebYmQ/VMgZn3O5PrnSapn5Fg3ZUaWaClu5/?=
 =?us-ascii?Q?xuxrOsgWfNgwbPk4VDec8WN4XPAe2xtb9hzj/Le+umwlb8WOWLsggm5Ih+Ho?=
 =?us-ascii?Q?IvrAvqztAOTLhJD3dJbjVLxPpsvLYPW4lB/RrgjvtfSlXJ9Gx8s7EqCYvWWr?=
 =?us-ascii?Q?qp21lOEc44vnhfHOrZnX4qvNKXHuoMT2IPs5PrAM/vVt/POUPslxSNqN0BFe?=
 =?us-ascii?Q?+UKpih2kmmpxL9Yo8YcPJMYofM+1H2wyd2UtM5G2RKt0mz60Wo8POd+uKa80?=
 =?us-ascii?Q?vp3+dpmWrxCUokV6LE78RB4qlowE8IALNsTPQPxCzitepQ7J0oPPX5F/sq54?=
 =?us-ascii?Q?6DFQUbpwyD/QrK68JhekQNdTwmb4OhOR7K+6AuBNzoyIHBqPQQ8O7A/famoV?=
 =?us-ascii?Q?rHC8DhHr1uWO8LMWUuhiLvuf15ZquPbi7mmqdy0AAxwozyRd71Vz04g1lOwx?=
 =?us-ascii?Q?J/90HdSrCvm+SHcYP0Gq013jh8PAibZd5GyHiQ/n1rNVnD1IRCLoKg7cHJdC?=
 =?us-ascii?Q?QLkMEJEyAn1cSVGm9yTb+IRzl6OQM4oohz6MNTdgj9WM+0wylVnTqnmNfWfM?=
 =?us-ascii?Q?ueDtDSkKFpq3gRe2R4zuG8TgtyTiofqS4ejj5EOvULwfzGQBkLSWEYDJNCSe?=
 =?us-ascii?Q?vIHAWaRmkK4RvR1pYogwrF6hHUcD2yy50B8tLJF8WVesazrMxdGhKIjVfxs3?=
 =?us-ascii?Q?WNG9AmGmg5TCKOmUVzq3Au4n9jIQShLsQfmeJHylJcIEMVbAOoTCOjMxOSAh?=
 =?us-ascii?Q?us2chPfaKCKx/tQCB4UMEuhd7KFY+siTxWAWJg/+GSV6zGG+bP/OXLEXtXrg?=
 =?us-ascii?Q?dsT9DMvMv9DH25X+XLD5Ir0TEYNu7xObAaWhsjIG8zxBQu0XQk0ZXBVj5HZV?=
 =?us-ascii?Q?0kJ3LWHmevyAIELzkdzxWfeTO7AzwNc/1Vmx9f39bfK876ECHxr1px50KdkF?=
 =?us-ascii?Q?Pnk=3D?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5478.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c98794eb-7ab2-474f-17ee-08d972713938
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2021 02:34:46.5130
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dyG/V0EgjkdlGANyL/CyJhv+W9Oe5N59662R+b77YANWuBgBLHbQ2rwSmPlp1lCLEpO6LIQPw41QHXMlsXI0W/QirVzVdw4Am5ILdHl6FpM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5478
X-Proofpoint-ORIG-GUID: KbdTirhsStdF7-zXFDQYUHfq-7kpvL2e
X-Proofpoint-GUID: KbdTirhsStdF7-zXFDQYUHfq-7kpvL2e
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-09-07_08,2021-09-07_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0
 spamscore=0 adultscore=0 phishscore=0 clxscore=1015 mlxlogscore=885
 priorityscore=1501 impostorscore=0 lowpriorityscore=0 mlxscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109030001 definitions=main-2109080014
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

=0A=
=0A=
________________________________________=0A=
From: Steven Rostedt <rostedt@goodmis.org>=0A=
Sent: Wednesday, 8 September 2021 09:17=0A=
To: Zhang, Qiang=0A=
Cc: bristot@redhat.com; bristot@kernel.org; mingo@redhat.com; linux-kernel@=
vger.kernel.org=0A=
Subject: Re: [PATCH v2] trace/osnoise: Fix missed cpus_read_unlock() in sta=
rt_per_cpu_kthreads()=0A=
=0A=
[Please note: This e-mail is from an EXTERNAL e-mail address]=0A=
=0A=
On Tue, 31 Aug 2021 10:29:19 +0800=0A=
qiang.zhang@windriver.com wrote:=0A=
=0A=
> From: "Qiang.Zhang" <qiang.zhang@windriver.com>=0A=
>=0A=
> When start_kthread() return error, the cpus_read_unlock() need=0A=
> to be called.=0A=
>=0A=
> Fixes: c8895e271f79 ("trace/osnoise: Support hotplug operations")=0A=
> Cc: <stable@vger.kernel.org> # v5.14+=0A=
=0A=
>FYI, no need to add the "# v5.14+", as it also breaks my scripts. The=0A=
>"Fixes:" tag is now used to know what stable releases it needs to be=0A=
>applied to (if any).=0A=
>=0A=
Thanks Steve=0A=
I will resend v3.=0A=
 =0A=
=0A=
>Daniel, that goes for you too, as you suggested it ;-)=0A=
>=0A=
>-- Steve=0A=