Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp254912pxb; Tue, 7 Sep 2021 23:54:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzv7ax5RaIFE/WuHGbwrfNRv0C3xrr13MWJ+X+b+JbBwkvH6m7ofJYf1UlPBBJssaBJsdmB X-Received: by 2002:a17:907:75f5:: with SMTP id jz21mr2545119ejc.95.1631084074942; Tue, 07 Sep 2021 23:54:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631084074; cv=none; d=google.com; s=arc-20160816; b=BYo44dqQt1cm6BW0GCwKl8etQye1p4T6YOIX9VMDl2KtJ0NNqJtgoy2bucHqcLgslO ynh0RS2fEBQeP0WRiUeCinbQmOuoPX8CeO6j0SVXPu+bzOWmlXKZii/9pFkNOsAx5HBQ CBPW65fjZ35+UwEkqtQ+anhG8PgwjcDB+c0Q+P2I71sMEKyF6eVeZzPT2ldmV6Q00EAa rxCsoSgClwKf2MI85DW6zhHz57lhRdWGh0yHzxoivbhBoWrgBehxQVPSpmWQcNcG9gnO BdWyYuBd+0Yo/0Gpa1wIknNhqhw0WDneh/7Qxo9NegsIl7LVljaEV3iAx+OSHyd2IG6u JQnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=dBfrdwNivWqqlCKmJ0ASZqHL/mKJ+iqsG8FTGZNie28=; b=mNAr0wyRsCy3Jm5Lpogj6iSTwImh/lTIZxh8fkaRKIG5fWHjL1e67gCJY85rknhdcc Otpna6HoDzSjYXA4VIGkfJaJHAx17x/qW5hzXnkIDcrGaSveEtvz09abuHRaiAP57zCc ZtukowT+vcqZ+LZLlO6vbU2+EN5kXrYp16gF4wbRQMBunqZCqZj6EOs3BcRE6O7ae8RG hEVT4uJeRKBtlbSzdZwfynCUu4/N7TS4BKtfnVHbg7dJ+4uC8p2CZO3J741C6OoZgmEl 1IrbbFYGi9l2z6QpUzPE1lJpkvVz5hObM5ao2aYHcBhiz725N8XvO2FG5JxMuCN9fcaq cogg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=D6unVWGG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 10si1161122ejq.273.2021.09.07.23.54.10; Tue, 07 Sep 2021 23:54:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=D6unVWGG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347808AbhIHGxU (ORCPT + 99 others); Wed, 8 Sep 2021 02:53:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347778AbhIHGxT (ORCPT ); Wed, 8 Sep 2021 02:53:19 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3959EC061575 for ; Tue, 7 Sep 2021 23:52:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dBfrdwNivWqqlCKmJ0ASZqHL/mKJ+iqsG8FTGZNie28=; b=D6unVWGGt0nhN9vNLt5bPN4XJ6 H5YeTJ6wPEjXfqN4OQvde23ebXYK4ScG4iV7RuMd/m2BDecE+805+QIOyDDJIjDMyQpo4eYaj4QmT F5gpCSBn3mbFzriE/4gNmiFAEKCw8EFJTlqjfosMVn+/7NyuTmPOcaj/pSI3twWgrK3D3gLCgPrMe ka5oWI1awXDsLFEZBWksAMt1lCG3nYEk5JDPx/M4rxdsFFQs1qr52K4DUKb7c+e381aB2rZA5g8eZ E72vmwrF3bYOH4V0FUjxdhgtQPxBvK92pTAIHZbOja/YjfQKbYEWK4Z0FzwpkGP7d/t2qsuf7If0X 4CAEntbw==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNrPl-008Ztv-5x; Wed, 08 Sep 2021 06:50:43 +0000 Date: Wed, 8 Sep 2021 07:50:33 +0100 From: Christoph Hellwig To: Jan Beulich Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 02/12] swiotlb-xen: fix late init retry Message-ID: References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> <778299d6-9cfd-1c13-026e-25ee5d14ecb3@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <778299d6-9cfd-1c13-026e-25ee5d14ecb3@suse.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 07, 2021 at 02:04:47PM +0200, Jan Beulich wrote: > The commit referenced below removed the assignment of "bytes" from > xen_swiotlb_init() without - like done for xen_swiotlb_init_early() - > adding an assignment on the retry path, thus leading to excessively > sized allocations upon retries. > > Fixes: 2d29960af0be ("swiotlb: dynamically allocate io_tlb_default_mem") > Signed-off-by: Jan Beulich > Cc: stable@vger.kernel.org Looks good, Reviewed-by: Christoph Hellwig