Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp262116pxb; Wed, 8 Sep 2021 00:07:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwB1qXPCpAl9LjrSAFQL8kIoa3xa00nnFMg9W8djhs3IfUPb9Rsh2hclYdSWow3OAQPsFxK X-Received: by 2002:a92:da87:: with SMTP id u7mr1677711iln.297.1631084824008; Wed, 08 Sep 2021 00:07:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631084824; cv=none; d=google.com; s=arc-20160816; b=xVH9AyCg8dvCDPJ0H2NgMmp1Ekb4fM05iVtgj2hOIgp6SrnrvKISvwH+kqhhhMNlSl sifv/ut0fGXMRINFSDczi6TGl3lST88PrKlnP+Z7kZH420re2NOVRvSqeED6m8f7MQqk JofuVb/Vv460i+9sAJIcCwJEJD7gRAlwknvqcjUjkOH6cZdy21vHvkYT2SvSID5F+2Rz FlgJGTBJCBEE+JgkFaZvLVj54aJzsFFomLfUhlmKEkfKtDdXnvGFR3H2rcNDTkqQG7Wl dXPcoDS3jY9PpXt1+jX4osiFBGr052mG3oSxKeDH7l4S6IDW59/87HFdB3Vke3WYttHN hT4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=u0jDPhGZwBkm+JMr6omQzYQizJyYgqZlwoU/jhm0G5s=; b=dFF2y93Rw2KZ9KjmQWkXvQmA6ImuW5DGc3Z0+zQeJRQ30P+zi8Guj09AmZi0WMh/OU RTZ303snbd/RbFtx9dMvsYP7GWlJtJlY57z8SMDNdd41pcp7UtnSGYUmfV4P8HjyaPjh rarbuQqGFSD/aRAJegsLsMWpGbi8GVXW1WWj8ew+o37X4wCAwRKggbY+oVAvYtuL3deC N+bwU5snnk+2NnOhiuvCwrhxQLtXTy0J1kN5mgf5aNzqFbH6eLxxis08pMp1TNpX57Kb I7q77gSdMowKCSe87pwqGJnKn/pgfwlTOAXxR7bYrdVYDfzJPjwMjK97JxCjanhI/YhF Qktw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=MlbsyzCd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a3si1210875ioc.79.2021.09.08.00.06.52; Wed, 08 Sep 2021 00:07:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=MlbsyzCd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234704AbhIHHHB (ORCPT + 99 others); Wed, 8 Sep 2021 03:07:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234575AbhIHHG6 (ORCPT ); Wed, 8 Sep 2021 03:06:58 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA7F4C061575 for ; Wed, 8 Sep 2021 00:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=u0jDPhGZwBkm+JMr6omQzYQizJyYgqZlwoU/jhm0G5s=; b=MlbsyzCdFKeIEDRfx1McK2amJc sZxrTxkScG/1WgXYGHD4V+bhWBRDZcajEMfSC3Rwh7B9lDj5xGPybecP4NGCxlvEnCQ5dAOw/mvQC Ne+YzN2biFxXb0cqjqdD5AOk5OTnSO86XUY8fGrf5F9OLSg1zVss0ee990dy8gbMeXRwV80gqaQDr AB/je8uC8iu7fwxs1wpvfFnQHp9bbN0RhMh1Yv+PeKByy9sQeiTX39GFwbTWNr1IIAGhJtTj1RjEi nMjgdiOKSed2JDSqDn7hI5nd+A9lN6PF4SsxMBk0Yvlq7ucqDs2VuYNkj6v52X1Qm7lpLLWu3Xn5N JDT+ugtg==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNrdA-008aSO-K1; Wed, 08 Sep 2021 07:04:35 +0000 Date: Wed, 8 Sep 2021 08:04:24 +0100 From: Christoph Hellwig To: Jan Beulich Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 08/12] swiotlb-xen: arrange to have buffer info logged Message-ID: References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> <2e3c8e68-36b2-4ae9-b829-bf7f75d39d47@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2e3c8e68-36b2-4ae9-b829-bf7f75d39d47@suse.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 07, 2021 at 02:07:21PM +0200, Jan Beulich wrote: > I consider it unhelpful that address and size of the buffer aren't put > in the log file; it makes diagnosing issues needlessly harder. The > majority of callers of swiotlb_init() also passes 1 for the "verbose" > parameter. > > Signed-off-by: Jan Beulich Looks good, Reviewed-by: Christoph Hellwig