Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 8 Sep 2021 09:27:19 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     minyard@acm.org, zweiss@equinix.com, andrew@aj.id.au,
        openipmi-developer@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ipmi: kcs_bmc: Fix a memory leak in the error handling
 path of 'kcs_bmc_serio_add_device()'
Message-ID: <20210908062719.GO1957@kadam>
References: <ecbfa15e94e64f4b878ecab1541ea46c74807670.1631048724.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ecbfa15e94e64f4b878ecab1541ea46c74807670.1631048724.git.christophe.jaillet@wanadoo.fr>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rVurFlD6Q/cjlddJ87QccdWPy1gtKumck4ubq1XKZ1/Ufvr0QMtZxeKwxXxu?=
 =?us-ascii?Q?JlytW1Tyy59PyunEDYId70pNmBIilWbILUtIeoMEyynCvMLQ4N7OzRIxKSdm?=
 =?us-ascii?Q?knn5Btnq2LTKg51o6qswz5DHdQ0QIdaoTtOCmTLkTs7EXES87qRi4bk2tU9c?=
 =?us-ascii?Q?oSB8YS0tJHsmrO9IkpASceY1LXYdzORp+NlE62o9IQ6qGBAoNNXF6xi0BxSc?=
 =?us-ascii?Q?1szsmzAYIwbasxE1jdWeVh+mPBsIT8YvFKfwbpxJJX6kMvM/9qayEWkdGXZX?=
 =?us-ascii?Q?dl/ZnXYl+J5XpXf/pKZHRi4wNAqx7tAZhHoAyOaFCSm6yzMNPj7JfV/NxN0X?=
 =?us-ascii?Q?tDgf4h30kUtwSxG7OWAfC9+AewW0Xe4ImEJCJheGhST78QEMLfcFymEujEs3?=
 =?us-ascii?Q?ExeQwGRj35pp158+r/l0OC6h+n7ykXsmsN338oZ6WYZNkbneY5kORtMnsRdj?=
 =?us-ascii?Q?ztESqFG89MzJaxieU742x+cWC9uIX8ZCOH3O/VRBIu9SBFRZHLB1SFK5jhHf?=
 =?us-ascii?Q?SBTSeF0Bk0mgCJlMf040oLwf89HTmOIVzY2qQ7/8IFC7ixgPcwlOIp7FycA6?=
 =?us-ascii?Q?tQnCpre0CQKT2eQNDNrm8xursXfeF0Gh4RrJ/yzQDPf+qd4DGU+BFVeSVlWX?=
 =?us-ascii?Q?B+afpqt6wuIvPMc+/Tm/B0Pg5qol0e9ii7TKwEA3Qk+29xa0iJpJcKEhfgXY?=
 =?us-ascii?Q?Hty6kkBwn6MP5KFjHKJeyH++Lu8oq/rSb+HEO4iU0KmO19BgHFETqSEukatb?=
 =?us-ascii?Q?bqduwAuKSAAT3ZKRx5RLdQJxU+44w9sxa6n+qOsgGKQNo9rZMWTwN2oXx09I?=
 =?us-ascii?Q?xxwIVUOt4eo6X9AHOWXqyLwBJZyrKHcRcay/TdRgTYZnpL2sY2KO8ZoBPQX3?=
 =?us-ascii?Q?m7TZRpKwvu9Y56PkdyPMU8U95mwOXB16SpiEoAZVh25TxzG3L4MUIl0oT8EX?=
 =?us-ascii?Q?5EQrUseKxg0RfqVpS2fCTvf/iPS8BWY/7DuJVDB5kmTasdSDyuBs4k/WPHVo?=
 =?us-ascii?Q?RmWHMtV3BOQCy4iHn4Cgx+1yRJjBZRbKOyTxQ1yt6phym2out2pmYclecRzU?=
 =?us-ascii?Q?KGimdu98qcoG2185ywEjzwROWqRCdGDSz/r0P0ARe5Ql9z1PcTF4acoAf640?=
 =?us-ascii?Q?CZx4SaaN5H+VqpW9SV0eQVU5zd9Y6WUSXoVj03Jbbf20e0/CmVys3+W7G2p1?=
 =?us-ascii?Q?qEpqXHBKXyIVKDBrJHKN5+RtCKk7vRU7ICPTOvdYPeYqM1mpxz9aq/CV1wYa?=
 =?us-ascii?Q?r0pTTsjnqWhmAKcDpItzvs5+Zb4YuLyESy8voUY93UHPeGvdSIJdJETUzb7g?=
 =?us-ascii?Q?6AttJbZNoAJXLRXvnxwZz421?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d19af84a-0188-44ca-d983-08d97291c4ee
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1001MB2358.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 06:27:45.4115
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C00XZ87Lqt5pSE2b9O++Q/wySCesOg97+LNrlZdKlF4EplUmPw69XcEEFPEjNzZKa+lsxnsWFp4iTawd3Ij20+ho6M3A4G/CTVZ9b12o2T0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1001MB2263
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10100 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0
 malwarescore=0 mlxscore=0 spamscore=0 bulkscore=0 mlxlogscore=999
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109030001 definitions=main-2109080039
X-Proofpoint-GUID: GCHg7ar5y3i5wj_k-JM_7HUoMxgkX4gz
X-Proofpoint-ORIG-GUID: GCHg7ar5y3i5wj_k-JM_7HUoMxgkX4gz
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 07, 2021 at 11:06:32PM +0200, Christophe JAILLET wrote:
> In the unlikely event where 'devm_kzalloc()' fails and 'kzalloc()'
> succeeds, 'port' would be leaking.
> 
> Test each allocation separately to avoid the leak.
> 
> Fixes: 3a3d2f6a4c64 ("ipmi: kcs_bmc: Add serio adaptor")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/char/ipmi/kcs_bmc_serio.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/char/ipmi/kcs_bmc_serio.c b/drivers/char/ipmi/kcs_bmc_serio.c
> index 7948cabde50b..7e2067628a6c 100644
> --- a/drivers/char/ipmi/kcs_bmc_serio.c
> +++ b/drivers/char/ipmi/kcs_bmc_serio.c
> @@ -73,10 +73,12 @@ static int kcs_bmc_serio_add_device(struct kcs_bmc_device *kcs_bmc)
>  	struct serio *port;
>  
>  	priv = devm_kzalloc(kcs_bmc->dev, sizeof(*priv), GFP_KERNEL);
> +	if (!priv)
> +		return -ENOMEM;
>  
>  	/* Use kzalloc() as the allocation is cleaned up with kfree() via serio_unregister_port() */

The serio_unregister_port() calls serio_destroy_port() which calls
put_device(&serio->dev).  But I wasn't able to track it further than
that to the actual kfree().

Is there a trick to finding ->release() functions?

regards,
dan carpenter