Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp285181pxb;
        Wed, 8 Sep 2021 00:48:51 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJy4RhRKgOviGtEtKbTn1p5rjBLzbUP6LMqW/cRegnLzrxuBzcaA7+UX5nyGP5Snvyr1L+9A
X-Received: by 2002:a17:906:abcd:: with SMTP id kq13mr2714723ejb.195.1631087331031;
        Wed, 08 Sep 2021 00:48:51 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1631087331; cv=none;
        d=google.com; s=arc-20160816;
        b=t1Foc11o4u6D7mDyKYMCl5aRItkuuHSXJO6JvPpbd4+y7Cg9DCvOt2D6dfyKT01B2E
         ym+qehbBDuLOiOi0Qxwfyijv8jGm06DyJVhxMxdA9sHyMXwr3NtIkgQeyJLkyArF9LOC
         qi9zmcvIgntzNxM8r9zBXDacxkEtNHbOoTqti8dUiHW7crR4eiBmCCT5GGmxY0AkQ9lm
         Ydm5LDRToTI94vPDFl75+xBj+VKCu490NB+d+nAPEPrpk0eAzAgvaF5zJPaWtJme5Blb
         gf2wg2J8U+uky0Vqd4qni0Gg+xAl1rLQGJf16I0vQcpeW7mJN4vGDfkZri/0R0DHAqo4
         0LFA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=OrzGM9PLHfbyfeiU5N8A74VHnUlyeQDz1745rBQSmpE=;
        b=B1uWY5kOaCWFP7V72JWcjH061oI6o8Jmj2p5MtlkVunqw8aaDal4voqKYQS8J+LaHF
         gnIZwvPQ6lfZZvcoDFnqR/Q4Z7PZKBQlGfSZWKITK9AZEeUVTFGmXJuwjIOd+WaXCLeG
         OULO7ZDNGDjkIBEaAzoDeuzS7C5N5Z+IrlOCGt+mkdujEedJnlhkSaI7FEXf/pu3BUmN
         eOSdFuDtF0wxqX4oPZam1ErMZtLeCbmbL6hdrEDdAnrRqz36WED2KhkqG7IJ01d0LoaO
         QYpqW//3k9Ay0YIbS4Ggb2c8Oivq33ji1pKei8Z8t8VL98egp9Qnbc2ukXfxZ6b52gJH
         83Ww==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=JvLbZFDB;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id dr5si1680072ejc.33.2021.09.08.00.48.27;
        Wed, 08 Sep 2021 00:48:51 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=JvLbZFDB;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1347802AbhIHGum (ORCPT <rfc822;liuwu.linux@gmail.com>
        + 99 others); Wed, 8 Sep 2021 02:50:42 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38694 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1345785AbhIHGuk (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 8 Sep 2021 02:50:40 -0400
Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B779DC061575
        for <linux-kernel@vger.kernel.org>; Tue,  7 Sep 2021 23:49:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=OrzGM9PLHfbyfeiU5N8A74VHnUlyeQDz1745rBQSmpE=; b=JvLbZFDB8IlVYMmqnbPjeH0zpT
        RS6TMNs3DqCPi4wnv+3RN+BAWH5wMMsH5OIbUJGjC9c+FFCSx0qVUnY9l1pDwbtkGF0v1rdZSeqkv
        8XX7xKR06ZiLWC8KJX9Wc5cBfed6lBQRH62JfWIeV4NJjQStpPIefHWmFJFFjudwengFWX7O9+UKm
        JnPsIv35qqOOxV/brv/0P5TTjFwkO3aGrqtXxjiSYg3zvBlHIJhqDusKynHPkF+9LwnkgJSAZfb8p
        N72r4r40Aj7RwC/fkxH0CgbUafSPL2d56ee5y/Rj+rPHP+4/dH3Ce027JiYI5/vdK/Awy8PLopLbN
        sv0vmElA==;
Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux))
        id 1mNrNu-008ZoP-Gv; Wed, 08 Sep 2021 06:48:55 +0000
Date:   Wed, 8 Sep 2021 07:48:38 +0100
From:   Christoph Hellwig <hch@infradead.org>
To:     Jan Beulich <jbeulich@suse.com>
Cc:     Juergen Gross <jgross@suse.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 01/12] swiotlb-xen: avoid double free
Message-ID: <YThcxvBhQqOVX2X4@infradead.org>
References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com>
 <ce9c2adb-8a52-6293-982a-0d6ece943ac6@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ce9c2adb-8a52-6293-982a-0d6ece943ac6@suse.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by casper.infradead.org. See http://www.infradead.org/rpr.html
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 07, 2021 at 02:04:25PM +0200, Jan Beulich wrote:
> Of the two paths leading to the "error" label in xen_swiotlb_init() one
> didn't allocate anything, while the other did already free what was
> allocated.
> 
> Fixes: b82776005369 ("xen/swiotlb: Use the swiotlb_late_init_with_tbl to init Xen-SWIOTLB late when PV PCI is used")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Cc: stable@vger.kernel.org

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>