Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp286098pxb; Wed, 8 Sep 2021 00:50:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/51SjsVMaKIS+3VM7umANpNdj5DjvYjkxgTGDS9mGGwEiwGxtIthwnGWlJiBUVNcmWXJ9 X-Received: by 2002:a05:6402:6cf:: with SMTP id n15mr2473020edy.85.1631087434088; Wed, 08 Sep 2021 00:50:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631087434; cv=none; d=google.com; s=arc-20160816; b=uQccqUTlqDfy/FvdaRf7SXT0pE4MPGhOdtiI802bUbzeCTbw+o8LFPFDpvP8hyPr93 yZh6IgNj6EV084ssxkHG7p6+jFcttE1aZrk25OpDn1pibT4x1rO3lAbI1mCxfSCxMkb5 d2cBuopEVGnUHDFff9c1yblo07f0aHkN68eDZUvE5a4jQEVBwPSrlOj32UUFnYPHx6rw Y3jwGFzWN3TjpwZPnkzdf/glW8QXgpT7mkqkRaKawpf1SenJuAkuiZLdfgZKGzzZ6Lao zjpEMU0CHMgLJ5/bpRvbEn4fhpKc96Gtf3JxY+77gPMjbfYru0u08tScZ21411ffI1B4 KwTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gatW1BubQnKb2kduQto9Cf0sWBkeir64mglmf+pQf2Q=; b=sxggAjsXKdI+zPUpjEOMACxLHx+rNIpJLaZuttJQbnGfhoKal7kNZqkkAAJORX7/bj BM9+HvWD9ktPGibK86aXAM67vPMUvU9dFBleWgafLNSUUu9s8RHjT6hY/hSCF26dy0I5 X7WwBwPqQlb8qPTg09b9FOEhk5ZFI9SjrdV6fxHO+fwTT3ClF64MEGBo+/rOOjbo/ljz B6p1HTES5U8EAMQRj5PjwtxymppB4+HCJSHa7iZ6oIGYuikrL4i8sasosw2yFogFs2JI 1kx9/KQaO5Rf/FL/EBWYfwi8Wa+NsEOqGeKXJ5oZWmTvaNGich/5660y5iWhGdClizcu pAEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=k7G3Dc9d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nc22si1718391ejc.494.2021.09.08.00.50.11; Wed, 08 Sep 2021 00:50:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=k7G3Dc9d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234684AbhIHHGN (ORCPT + 99 others); Wed, 8 Sep 2021 03:06:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345947AbhIHHEt (ORCPT ); Wed, 8 Sep 2021 03:04:49 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B433C061575 for ; Wed, 8 Sep 2021 00:03:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gatW1BubQnKb2kduQto9Cf0sWBkeir64mglmf+pQf2Q=; b=k7G3Dc9dTikD/msbbkUkrK6bH/ rcD7O+3KeLMyQ1++oVllKlyi8fr3OzWCFSPglsQEwTuZYSOeBs1r73L3/drk5ceobljVtDfydSKFB j/domY+VTpfr9Pk9f5rNEQqFYIDkHP5jTSDi9iVT3CSZOC35ka5bQlKxSolhcWPXaq/1QfK21G+ih COU4O1kTW2U6YdQXei4QY2KiZAUUKvTqMlzEA/VevxT4QnIBgJt2vBtZgAO4rpNo8bQHCz2QyPe5C fe2/HGVSMq4ipo4jC45iFAjbTS29+lrORLywMIyJG16unTn6UIJAoJaoEX8vMVXeRptUArk8CdQ0M IkU/sUdQ==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNrbE-008aLp-HO; Wed, 08 Sep 2021 07:03:05 +0000 Date: Wed, 8 Sep 2021 08:02:24 +0100 From: Christoph Hellwig To: Jan Beulich Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 07/12] swiotlb-xen: drop leftover __ref Message-ID: References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> <7cd163e1-fe13-270b-384c-2708e8273d34@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7cd163e1-fe13-270b-384c-2708e8273d34@suse.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 07, 2021 at 02:06:55PM +0200, Jan Beulich wrote: > Commit a98f565462f0 ("xen-swiotlb: split xen_swiotlb_init") should not > only have added __init to the split off function, but also should have > dropped __ref from the one left. > > Signed-off-by: Jan Beulich Looks good, Reviewed-by: Christoph Hellwig