Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 8 Sep 2021 11:17:35 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     zhaoxiao <long870912@gmail.com>
Cc:     thierry.reding@gmail.com, lee.jones@linaro.org,
        linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pwm: ab8500: Don't check the return code of
 pwmchip_remove()
Message-ID: <20210908091735.yxyr7wqpbyirkw73@pengutronix.de>
References: <20210908060200.7876-1-long870912@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210908060200.7876-1-long870912@gmail.com>
User-Agent: NeoMutt/20180716
Precedence: bulk

Hello zhaoxiao,

On Wed, Sep 08, 2021 at 02:02:00PM +0800, zhaoxiao wrote:
> pwmchip_remove() returns always 0. Don't use the value to make it
> possible to eventually change the function to return void. Also the
> driver core ignores the return value of ab8500_pwm_remove()
> and considers the device removed anyhow. So returning early results
> in a resource leak.
> 
> Signed-off-by: zhaoxiao <long870912@gmail.com>

Can you please base your patches on top of linux-next? This patch is
invalid in the presence of 
https://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git/commit/?h=for-next&id=14ac9e17f9bd4bd0dfe18e384a3c2ca8dfbffcc8

So this is waste of your (and my) time :-\

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |