Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: skakit=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 08 Sep 2021 14:47:37 +0530
From:   skakit@codeaurora.org
To:     Stephen Boyd <swboyd@chromium.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>
Cc:     Andy Gross <agross@kernel.org>, Pavel Machek <pavel@ucw.cz>,
        Rob Herring <robh+dt@kernel.org>, mka@chromium.org,
        kgunda@codeaurora.org, linux-leds@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/3] leds: Add pm8350c support to Qualcomm LPG driver
In-Reply-To: <CAE-0n52Jb9nw9rbbQJrKNDQ_O2iCahDr8WLGkWORcNks9ptH-g@mail.gmail.com>
References: <1630924867-4663-1-git-send-email-skakit@codeaurora.org>
 <1630924867-4663-3-git-send-email-skakit@codeaurora.org>
 <CAE-0n52Jb9nw9rbbQJrKNDQ_O2iCahDr8WLGkWORcNks9ptH-g@mail.gmail.com>
Message-ID: <f35822d036988a1a6b6e4dcaa46373e7@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2021-09-08 01:50, Stephen Boyd wrote:
> Quoting satya priya (2021-09-06 03:41:06)
>> Add pm8350c compatible and lpg_data to the driver.
>> 
>> Signed-off-by: satya priya <skakit@codeaurora.org>
>> ---
>>  drivers/leds/rgb/leds-qcom-lpg.c | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>> 
>> diff --git a/drivers/leds/rgb/leds-qcom-lpg.c 
>> b/drivers/leds/rgb/leds-qcom-lpg.c
>> index 327e81a..6ee80d6 100644
>> --- a/drivers/leds/rgb/leds-qcom-lpg.c
>> +++ b/drivers/leds/rgb/leds-qcom-lpg.c
>> @@ -1275,9 +1275,19 @@ static const struct lpg_data pm8150l_lpg_data = 
>> {
>>         },
>>  };
>> 
>> +static const struct lpg_data pm8350c_pwm_data = {
>> +       .pwm_9bit_mask = BIT(2),
>> +
>> +       .num_channels = 1,
>> +       .channels = (struct lpg_channel_data[]) {
> 
> Can this be const struct lpg_channel_data? I think that will move it to
> rodata which is only a good thing.
> 

I agree.
@Bjorn, can we make it const struct?

>> +               { .base = 0xeb00 },
>> +       },
>> +};
>> +
>>  static const struct of_device_id lpg_of_table[] = {
>>         { .compatible = "qcom,pm8150b-lpg", .data = &pm8150b_lpg_data 
>> },
>>         { .compatible = "qcom,pm8150l-lpg", .data = &pm8150l_lpg_data 
>> },
>> +       { .compatible = "qcom,pm8350c-pwm", .data = &pm8350c_pwm_data 
>> },
>>         { .compatible = "qcom,pm8916-pwm", .data = &pm8916_pwm_data },
>>         { .compatible = "qcom,pm8941-lpg", .data = &pm8941_lpg_data },
>>         { .compatible = "qcom,pm8994-lpg", .data = &pm8994_lpg_data },