Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp343622pxb; Wed, 8 Sep 2021 02:31:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLmdZA4lqRrxQKnkHk1ceXTSmEhFi10/1q8yVGSD9hmPNOAiKCAkGYRixCTlSQ0s3/xXCm X-Received: by 2002:a17:906:1497:: with SMTP id x23mr3048338ejc.243.1631093466453; Wed, 08 Sep 2021 02:31:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631093466; cv=none; d=google.com; s=arc-20160816; b=O+GFtp+6++EDa4aZawY4py+NUmcC+bWtxc5JRqY1l1xzXE2aB+206oLCubH7fE0ae9 CETE/bp6oJ6rF3/0Sn6NPFU8R8YBQXnH4VEEXxzeC3YgmCc8mJeyTTrbuCjyitNf9I/0 mJLKZKCLQIB2mf/2pd1OQ5pCCaay8MtaGy/OiJ0K+AlKsWGrDpLluJApaeqajJ64Go/q nyl6il7uHeuJK53Ybkmn0ZS+QJHW8/wkX2Qa4aN91J6JD1Ec/KPDQPAtVGVxs0xILLKh YBswkQh182zc0emKRU2bUYRiWAnTtbc+bnMKfhK6ttCDS7Fxc/RHwh1r+nt4qBEo+gPx 5/gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=BIE/LIdFO8jY5B6XQFOTWQMi8dbTNeZ9iRgAJzUQFJU=; b=qBcpzIovEDIWnHlwE459mEydRvrttpOEASNdH6qDxMS57w/E06PGL5aW0fbh9lPnzS BjrBv0WzDUv5BzbkT2LydeOY8fcupkxp4iZaOFnMbVJqgJmoSVRaXSYwr8ajqAgau+g/ ETOAymrC6IqS1x+AJHiXKp3S4MjngEbs4CgPizV/7YpIv9SoKsDB3dDWz1/oqFQ9hJQD yzWqcG4hJ3FFr1zkpoFcG/T1li+LByzY+SsR8YHg201cNsJ34bN8EGlVDVuueoBUSqF0 AfWv08ZK4qeV/JPbIDV9ECw6numED3Ae9qqZlj9p6fzWX2csCmmEfH11sLtqB2avMrge LK3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=sj3hwvVE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h7si1594364ejo.631.2021.09.08.02.30.43; Wed, 08 Sep 2021 02:31:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=sj3hwvVE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348120AbhIHHLZ (ORCPT + 99 others); Wed, 8 Sep 2021 03:11:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348375AbhIHHLP (ORCPT ); Wed, 8 Sep 2021 03:11:15 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3CABC061575 for ; Wed, 8 Sep 2021 00:10:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BIE/LIdFO8jY5B6XQFOTWQMi8dbTNeZ9iRgAJzUQFJU=; b=sj3hwvVEXJG7RXFgHJKiWrl2DW PSMKQHTTMqu0a23Z7httVaAjEPT4AM/xssoAfAMFxEVJ6rBlvytzg+s4FehCm7M2Zxirf64YczMY7 12aopbnZx89CwC6n3lwGa5O0523gUpp+NyNoIRD2nC/aGJ3FvqwZHevdybiDOFcOFgaGILaXKVRNe Guo/1qOs4FIXJKtxXEZwQhH4ONEiYUG6xp7qxMxYlUPnI8paKE4dBt5vDzj/NFUNVslm6Yp2u200T CuTrCqt17eJo9fP2yxyZHTHqo9QXfN+KhClS4uoWVTEBVxSLfZlemZN6pP2UsIeLh8g8G0WXBkRNM kRaojG4w==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNrha-008aj6-H4; Wed, 08 Sep 2021 07:09:14 +0000 Date: Wed, 8 Sep 2021 08:08:58 +0100 From: Christoph Hellwig To: Jan Beulich Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 11/12] xen/pci-swiotlb: reduce visibility of symbols Message-ID: References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> <75591cef-95e8-c694-fd11-283800499e4e@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <75591cef-95e8-c694-fd11-283800499e4e@suse.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 07, 2021 at 02:11:14PM +0200, Jan Beulich wrote: > xen_swiotlb and pci_xen_swiotlb_init() are only used within the file > defining them, so make them static and remove the stubs. Otoh > pci_xen_swiotlb_detect() has a use (as function pointer) from the main > pci-swiotlb.c file - convert its stub to a #define to NULL. > > Signed-off-by: Jan Beulich Looks good, Reviewed-by: Christoph Hellwig