Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp376469pxb; Wed, 8 Sep 2021 03:20:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzghdtnuppdR2SAzZo5DFoRh3I+NRaIzMldJ7ZrMNDeyGXyfJXykOaG8CedMgAuhTdB3cAH X-Received: by 2002:a92:d102:: with SMTP id a2mr2175518ilb.162.1631096432391; Wed, 08 Sep 2021 03:20:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631096432; cv=none; d=google.com; s=arc-20160816; b=mwH47nDhZeTd2KmKDT/kK/s7OjtBDUmOox5W3G7pf4KyB0zrTzkdO6uo7howq0EOvE gk7BAqu4P7Ky00h9RAxZuk95ztoKIeTTMMhqgThr4Hdtbu8z1GW6aHtnwbY7A4Axsr6L UcFoHLatIdhrDrodxgq4TL9s+Tuamqpndh9bRLdjqrPddtb1+8Bpip6rI6OK882z+Jwd +kGGSOkmVDM2BxSAgnRNhYX4ttmgoCTFYn5nnODiRS/x0CLJJvFV24j5OMnsc+EvrHUK grzFB828nuE+0zG2TTOhRl39ynSO+lvDbE0sv5QeETb6Gu57yMriaGMjueSkZz2H0fJA Hu3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=NsblJRxrMYYpm2FlyO/JfPNHxop+1A6RjQx5vRn2TA0=; b=JK8CybU3zQafI0lXamw4EFZn0VG+VrlGXsIqtozEbXRgoZFSUY49sjHiq4GMDCM0kP 1RLnyUVX+DL1/VC5QGaYarOh/NTzvXGHpoGsvM3529/oQL/huFeVSN4rC0XT43u4ONV2 s6d+u96sJPDNonl4PoqUZ3QdLQqFFKgWSoD03Zv67pqex+Ng+C8sN6T1XHqOUN27JoGx 6z3JIuTBzAc/1rZVrCLkgUaipZ7OkQHOXGZAEVyyugxcddcDIb36NPB1Zrg8GSuzs0Db wM6NTHV4ElyJlurMWvKyTYuxFlR9PFBfAExROoZkvZuhe4cQvnqCYE8LMI+pX0Xie0UC sN9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b8si1704938ios.88.2021.09.08.03.20.21; Wed, 08 Sep 2021 03:20:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245323AbhIHKIJ (ORCPT + 99 others); Wed, 8 Sep 2021 06:08:09 -0400 Received: from mx3.molgen.mpg.de ([141.14.17.11]:56679 "EHLO mx1.molgen.mpg.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S232273AbhIHKIF (ORCPT ); Wed, 8 Sep 2021 06:08:05 -0400 Received: from [141.14.220.45] (g45.guest.molgen.mpg.de [141.14.220.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id B231161E5FE33; Wed, 8 Sep 2021 12:06:54 +0200 (CEST) Subject: Re: [PATCH] ACPI/PRM: Find PRMT table before parse it To: Aubrey Li Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Aubrey Li , "Rafael J. Wysocki" References: <1631066984-63501-1-git-send-email-aubrey.li@intel.com> From: Paul Menzel Message-ID: <79d42839-729e-559b-beda-8f1cdbc1e113@molgen.mpg.de> Date: Wed, 8 Sep 2021 12:06:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <1631066984-63501-1-git-send-email-aubrey.li@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Aubrey, Am 08.09.21 um 04:09 schrieb Aubrey Li: > Find and verify PRMT table before parse it, this eliminates a > warning on machines without PRMT table. > > [ 7.197173] ACPI: PRMT not present Please also add: Fixes: cefc7ca462 ("ACPI: PRM: implement OperationRegion handler for the PlatformRtMechanism subtype") > Signed-off-by: Aubrey Li > Tested-by: Paul Menzel > --- > drivers/acpi/prmt.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/prmt.c b/drivers/acpi/prmt.c > index 1f6007a..89c22bc 100644 > --- a/drivers/acpi/prmt.c > +++ b/drivers/acpi/prmt.c > @@ -288,10 +288,18 @@ static acpi_status acpi_platformrt_space_handler(u32 function, > > void __init init_prmt(void) > { > + struct acpi_table_header *tbl; > acpi_status status; > - int mc = acpi_table_parse_entries(ACPI_SIG_PRMT, sizeof(struct acpi_table_prmt) + > + int mc; > + > + status = acpi_get_table(ACPI_SIG_PRMT, 0, &tbl); > + if (ACPI_FAILURE(status)) > + return; > + > + mc = acpi_table_parse_entries(ACPI_SIG_PRMT, sizeof(struct acpi_table_prmt) + > sizeof (struct acpi_table_prmt_header), > 0, acpi_parse_prmt, 0); > + acpi_put_table(tbl); > /* > * Return immediately if PRMT table is not present or no PRM module found. > */ Thank you very much for preparing the patch. Kind regards, Paul