Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ACPI/PRM: Find PRMT table before parse it
To:     Aubrey Li <aubrey.li@intel.com>
Cc:     linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Aubrey Li <aubrey.li@linux.intel.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>
References: <1631066984-63501-1-git-send-email-aubrey.li@intel.com>
From:   Paul Menzel <pmenzel@molgen.mpg.de>
Message-ID: <79d42839-729e-559b-beda-8f1cdbc1e113@molgen.mpg.de>
Date:   Wed, 8 Sep 2021 12:06:54 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <1631066984-63501-1-git-send-email-aubrey.li@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Dear Aubrey,


Am 08.09.21 um 04:09 schrieb Aubrey Li:
> Find and verify PRMT table before parse it, this eliminates a
> warning on machines without PRMT table.
> 
> 	[    7.197173] ACPI: PRMT not present

Please also add:

Fixes: cefc7ca462 ("ACPI: PRM: implement OperationRegion handler for the 
PlatformRtMechanism subtype")

> Signed-off-by: Aubrey Li <aubrey.li@linux.intel.com>
> Tested-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
>   drivers/acpi/prmt.c | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/prmt.c b/drivers/acpi/prmt.c
> index 1f6007a..89c22bc 100644
> --- a/drivers/acpi/prmt.c
> +++ b/drivers/acpi/prmt.c
> @@ -288,10 +288,18 @@ static acpi_status acpi_platformrt_space_handler(u32 function,
>   
>   void __init init_prmt(void)
>   {
> +	struct acpi_table_header *tbl;
>   	acpi_status status;
> -	int mc = acpi_table_parse_entries(ACPI_SIG_PRMT, sizeof(struct acpi_table_prmt) +
> +	int mc;
> +
> +	status = acpi_get_table(ACPI_SIG_PRMT, 0, &tbl);
> +	if (ACPI_FAILURE(status))
> +		return;
> +
> +	mc = acpi_table_parse_entries(ACPI_SIG_PRMT, sizeof(struct acpi_table_prmt) +
>   					  sizeof (struct acpi_table_prmt_header),
>   					  0, acpi_parse_prmt, 0);
> +	acpi_put_table(tbl);
>   	/*
>   	 * Return immediately if PRMT table is not present or no PRM module found.
>   	 */

Thank you very much for preparing the patch.


Kind regards,

Paul