Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp399386pxb; Wed, 8 Sep 2021 03:55:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz0Apoa1t4+hbYtmWkq6/pNm0rS4+T74QqWe3TxqVvDlh6ETsXtr73VMxbvPuFTdi/joI4n X-Received: by 2002:a17:906:3012:: with SMTP id 18mr3503783ejz.136.1631098516823; Wed, 08 Sep 2021 03:55:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631098516; cv=none; d=google.com; s=arc-20160816; b=eRWdJmO9uiTyYreoPUB4Tpls//te9T1eRlI9192XXpjmz6u2zlK/fzQ+3arC4KSgtr 7yWEYX7kSjvtayGDI2NCnUB4/inmupWYsiaV248QRS5f/3ELqVheS9q36NBPHzTh8QTi sKvWYFQWsq7ETiDgKWf2WO+G33KjdmJIcagH2XgYx5Px6VdRqxO/RYgkBF4TlS7vhb6Q NmyKUj9DcFy93aciPo/puTbAg4N9yTVo4d2hnEPEcpBI4nNGCqwUqwpGfHjowV2JopER Q+9MUBlNYWMR0cbBhz271lGtnESMzFSHb8cox7PtqoiDMZ+crqiYg84zftuJuB06cJp3 Mkwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/c1i7MJmMtvpNZUmYoO8pHyXNL8x7+xg5ZYSPs97nbA=; b=s7gFHRLUMLL1EUiOD5GpJkLDJPLjf4MJu71RscVax3iXTnhBr7pYIm6Ue/BkxiVYB1 MlhU1S9cd9pHJjoLcNSah2SpL++LCxn852+KCj04/wxJc4rbn9lx/RVbbjaEWZ//OY4k 9d5vKUwXiE8mESWt2Swmf6UaH7qg2PCV7IMfbfnzMiDwVwzvE1uHirONeorGK07H9zaY MSSKs5jNSKsk+BdPPYltJ3XLQPbnaBioDOkuDB8vM7GtuHTzSG+9n9Wuq9B22fyvmL6K Sb8Nhe3fcB/gBKN02qFaLnW4nOrecIRKgKEhecz5tlWJgEskkBKfn0uZJxZ6iN120ea5 DT4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=jr+NflkN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 5si1653984ejl.332.2021.09.08.03.54.53; Wed, 08 Sep 2021 03:55:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=jr+NflkN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348975AbhIHKyG (ORCPT + 99 others); Wed, 8 Sep 2021 06:54:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348884AbhIHKyC (ORCPT ); Wed, 8 Sep 2021 06:54:02 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1D60C061575; Wed, 8 Sep 2021 03:52:54 -0700 (PDT) Received: from zn.tnic (p200300ec2f0efc002d1ac0b1b41b9169.dip0.t-ipconnect.de [IPv6:2003:ec:2f0e:fc00:2d1a:c0b1:b41b:9169]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 823EB1EC0246; Wed, 8 Sep 2021 12:52:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1631098372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=/c1i7MJmMtvpNZUmYoO8pHyXNL8x7+xg5ZYSPs97nbA=; b=jr+NflkNApcbMcE3x32XD/UX7p/0fqIF65IsSvGVzESGORog8godikPznZVkEHWAEfDZp/ 3cJpFWYdwvZIYVjJoVqIb18N+9kITRR9p/Hy2pBWEoAPDfgBtrObF1m218D0WEFw/Run5F lcaRmegenetKjtMzrdNH5JFrk8D+7M8= Date: Wed, 8 Sep 2021 12:52:45 +0200 From: Borislav Petkov To: Dave Hansen , Mike Rapoport Cc: x86@kernel.org, Andrew Morton , Andy Lutomirski , Dave Hansen , David Hildenbrand , Ingo Molnar , Jiri Olsa , Mike Rapoport , Oscar Salvador , Peter Zijlstra , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] x86/mm: fix kern_addr_valid to cope with existing but not present entries Message-ID: References: <20210819132717.19358-1-rppt@kernel.org> <35f4a263-1001-5ba5-7b6c-3fcc5f93cc30@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 08, 2021 at 12:35:21PM +0200, Borislav Petkov wrote: > So I did stare at this for a while, trying to make sense of it and David > Hildenbrand asked for a Fixes: tag in v1 review and from doing a bit of > git archeology I think it should be: > > c40a56a7818c ("x86/mm/init: Remove freed kernel image areas from alias mapping") > > because that thing added the clearing of the Present bit for the high > kernel image mapping of those areas. > > Right? Hmm, but that commit is in v4.19. Mike has added Cc: # 4.4+ Mike, why 4.4 and newer? Hmmm. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette