Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 8 Sep 2021 17:02:09 +0530
From:   Pratyush Yadav <p.yadav@ti.com>
To:     Parshuram Raju Thombare <pthombar@cadence.com>
CC:     "broonie@kernel.org" <broonie@kernel.org>,
        "lukas@wunner.de" <lukas@wunner.de>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jayshri Dajiram Pawar <jpawar@cadence.com>,
        Milind Parab <mparab@cadence.com>,
        Konrad Kociolek <konrad@cadence.com>
Subject: Re: [PATCH v3 1/2] spi: cadence: add dt-bindings documentation for
 Cadence XSPI controller
Message-ID: <20210908113207.6y6h6l23htngrea2@ti.com>
References: <1630499755-18751-1-git-send-email-pthombar@cadence.com>
 <1630499829-20059-1-git-send-email-pthombar@cadence.com>
 <20210903181722.ukarfanyew2b7yoz@ti.com>
 <CY4PR07MB2757DF7EFD862D67FBF648CBC1D49@CY4PR07MB2757.namprd07.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CY4PR07MB2757DF7EFD862D67FBF648CBC1D49@CY4PR07MB2757.namprd07.prod.outlook.com>
User-Agent: NeoMutt/20171215
Precedence: bulk

On 08/09/21 06:52AM, Parshuram Raju Thombare wrote:
> >This needs to be a "subclass" of the spi-controller.yaml binding.
> >
> >allOf:
> >  - $ref: spi-controller.yaml#
> 
> Isn't stating that validation need against spi-controller.yaml as well as
> this schema sufficient ? Can you please point an example how to make
> controller binding a "subclass" of spi-controller.yaml binding ?

I just showed you. You need to add the below lines:

allOf:
  - $ref: spi-controller.yaml#

See cdns,qspi-nor.yaml or nvidia,tegra210-quad.yaml or any of the 
multiple controller bindings we already have.

By "subclass" I did not mean a programming construct, I just meant it 
should logically be a subclass of the spi-controller.yaml binding, which 
can be done by the allOf.

> 
> >Node name should be flash@0.
> 
> I think spi-controller.yaml uses wildcard for the name of a device node,
> so anything in string@hexvalue: should work.

Sure, but mtd.yaml (which the SPI NOR binding depends on) requires it.

> 
> >> +            compatible = "spi-nor", "micron,mt35xu512";
> >
> >These compatibles are arbitrary and undocumented. You probably just need
> >"jedec,spi-nor". If you need anything else, you need to justify why.
> 
> Although just "spi-nor" also works, I agree to use "jedec, spi-nor" and drop
> device name.

Does it? I see "jedec,spi-nor" compatible documented, but not just 
"spi-nor". And I don't see "micron,mt35xu512" compatible documented 
anywhere either.

Anyway, please just use "jedec,spi-nor".

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.