Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 8 Sep 2021 16:51:15 +0530
From:   Pratyush Yadav <p.yadav@ti.com>
To:     Parshuram Raju Thombare <pthombar@cadence.com>
CC:     "broonie@kernel.org" <broonie@kernel.org>,
        "lukas@wunner.de" <lukas@wunner.de>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jayshri Dajiram Pawar <jpawar@cadence.com>,
        Milind Parab <mparab@cadence.com>,
        Konrad Kociolek <konrad@cadence.com>,
        Tudor Ambarus <tudor.ambarus@microchip.com>,
        Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH v3 2/2] spi: cadence: add support for Cadence XSPI
 controller
Message-ID: <20210908112113.smnwmayjb3jit3eg@ti.com>
References: <1630499755-18751-1-git-send-email-pthombar@cadence.com>
 <1630499858-20456-1-git-send-email-pthombar@cadence.com>
 <20210903185653.7vrfn4qfzvuiaiq2@ti.com>
 <CY4PR07MB275737A008CBB58C4B108D2FC1D49@CY4PR07MB2757.namprd07.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CY4PR07MB275737A008CBB58C4B108D2FC1D49@CY4PR07MB2757.namprd07.prod.outlook.com>
User-Agent: NeoMutt/20171215
Precedence: bulk

On 08/09/21 07:27AM, Parshuram Raju Thombare wrote:
> >Depends on SPI_MEM as well.
> 
> Ok
> 
> >I commented on this last time around as well. This does not look right
> >at all. A SPI MEM based driver should *not* need to know anything about
> >the subsystem driving it. That is the entire point of the API.
> >
> >The controller seems to be able to extract the read and write opcodes
> >from the SFDP on its own since you don't pass in that information to
> >cdns_xspi_nor_read(). It looks like it is tied very heavily to a NOR
> >flash, and I am not sure if it can really be used with a NAND flash, or
> >something else entirely.
> >
> >Which makes me wonder how we should handle controllers like these. I
> >don't think they fit in very well with the SPI MEM model, since they
> >can't execute arbitrary SPI MEM commands very well. At the same time we
> >are trying to get rid of mtd/spi-nor/controllers. Dunno...
> >
> >Mark, Tudor, Vignesh, any ideas?
> 
> Ok, then for now I will drop ACMD PIO mode and use only STIG mode.
> In STIG mode driver configures bus width and clock edge mode for
> command, address and data for each operation. 

But it would reduce performance by a lot, no? I think we should try to 
figure out how we can accomodate controllers like this before resorting 
to using the slower modes.

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.