Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: srivasam=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 0C46CC43460
Subject: Re: [PATCH] ASoC: dt-bindings: lpass: add binding headers for digital
 codecs
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com,
        broonie@kernel.org, robh+dt@kernel.org, plai@codeaurora.org,
        bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com,
        rohitkr@codeaurora.org, linux-arm-msm@vger.kernel.org,
        alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, swboyd@chromium.org,
        judyhsiao@chromium.org
References: <1630934854-14086-1-git-send-email-srivasam@codeaurora.org>
 <4a513810-ab33-006d-4bce-5e35702a51e0@linaro.org>
From:   Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
Organization: Qualcomm India Private Limited.
Message-ID: <689316cf-7de7-6702-6e82-ee52d786a602@codeaurora.org>
Date:   Wed, 8 Sep 2021 18:35:10 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <4a513810-ab33-006d-4bce-5e35702a51e0@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

Thanks for your time and valuable suggestions Srini!!

On 9/8/2021 3:11 PM, Srinivas Kandagatla wrote:
>
>
> On 06/09/2021 14:27, Srinivasa Rao Mandadapu wrote:
>> +#define LPASS_CDC_DMA_RX0 6
>
> You are only adding RX0, what happens to RX1.. RX7
>
> TBH, skipping other entries for ex CDC_DMA_RX will end up with sparse 
> numbering.
>
> Please add all the entries for CDC_DMA_RX and other ports as well.
>
> Like:
>
> #define LPASS_CDC_DMA_RX0    6
> #define LPASS_CDC_DMA_RX1    7
> #define LPASS_CDC_DMA_RX2    8
> #define LPASS_CDC_DMA_RX3    9
> #define LPASS_CDC_DMA_RX4    10
> #define LPASS_CDC_DMA_RX5    11
> #define LPASS_CDC_DMA_RX6    12
> #define LPASS_CDC_DMA_RX7    13
>
>
Okay. Will add and Share new patch.
>> +#define LPASS_CDC_DMA_TX3 7
>> +#define LPASS_CDC_DMA_VA0 8
> You mean VA_TX0?
>
Yes. Will change accordingly.
>
>> +#define LPASS_MAX_PORTS 9
> We really do not need this in bindings.
> You could add this is some of the driver header files instead.
>
Okay Will remove.
> --srini
>> +

-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.