Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] xen/balloon: use a kernel thread instead a workqueue
To:     Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org
Cc:     Stefano Stabellini <sstabellini@kernel.org>,
        Jan Beulich <jbeulich@suse.com>
References: <20210827123206.15429-1-jgross@suse.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
Message-ID: <8b13525b-0075-f4c1-8900-1be151e85e3e@oracle.com>
Date:   Wed, 8 Sep 2021 10:47:16 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
In-Reply-To: <20210827123206.15429-1-jgross@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MkJ5L3ZWQlVGNEg3UHNNMmlPSUZPVFArNHMrVnNPODJGK1JhVVIwZVF1d0V3?=
 =?utf-8?B?MkN0clJFcGo5RE96dUp4MUpSUEpqY2gvUjI1SUF3Sy9FV0RxV3BGNHZTbnBt?=
 =?utf-8?B?RUxlei9NbjE5Snl4dkdaQ2hCVnplK2M0aEE0ZVV3TGxwaWVCbk50Y0xWM01P?=
 =?utf-8?B?cjlLL245a0RKQm0yK2J4TDVmOWNENnpiR3JBQzBreVRUTXNBRFRhNTlDa0xK?=
 =?utf-8?B?aWdwN29sSXZwOUJSWW1MUFcxZEFTK3V2Zi93NEpCazN2NVhKQ1dkSWRPNUc0?=
 =?utf-8?B?d2dYdW9GNkZuUi9mYzZsUmVrZTN3aWlmdGFQSU9qRzVFWmRETHE5Q3liY2k1?=
 =?utf-8?B?ajNZTEdQWTZTWG8rZys0Sis1ME5NNUhaR3oxeDhROGd2cEl2cnkycjhDdjUy?=
 =?utf-8?B?RGRCTmtiNzF6VDIrdkVobTF4ZFFRTExGQmlQdHZjNlczam8vbUgzeU55c2dH?=
 =?utf-8?B?NjRZU2N5aFcvTjJWOU5TMlU3TSt4bXlLQnF0SnI3eEY2ZWYxakNLKzc0UnBz?=
 =?utf-8?B?V0VWWXZuQkxwaEpQRnlyZURUZzQxa1pVQVNPRnRsNTFPek5mOVdBUWRtSXZZ?=
 =?utf-8?B?dzdIUjZsZXdSQXlyU1I5NDZZazVOVnc4NVZ2Z0lRaksvNjJWb1VGVW53dWRl?=
 =?utf-8?B?ZnA3ZFo3MnErNmJJWkkzZUF6cGI0TjVVNEEyM1FtemtIdVlCb1c3dHhGL05E?=
 =?utf-8?B?NnRuVERvYkFQV0U0QjhYVllDaVREektRQTNyVU9VdUliYS82ckM0cm8rWStG?=
 =?utf-8?B?R2JjRmgvbzhLeEg5anlkbjFTT0pFVUw0bWViMWtjQVhCdFQxV1JJR1hRUE4z?=
 =?utf-8?B?MDU1V25rS2JHYWdMenlNN2Njd2ZwOWtVd0JydmNLMVlnSXhOcE9EbmhiNlNZ?=
 =?utf-8?B?WjBPbXdwajNrSHZKUEtNRnI5ZUtVRk1RNzduNTJNYmduNHFzOWl0V2txcmh4?=
 =?utf-8?B?RGErWHJuRXVpUG92ZTZ4YWxCWktZTHRFQ0Q3UnBrMHhKWDljNm5ZSFhYSE4r?=
 =?utf-8?B?T2F0SHZKdWNCT0kwMnBWTkhOaTNCeXFZN1E4YkM4aUU4enFoNmx5NTRtcHpQ?=
 =?utf-8?B?eE1uYlllTTEyUHl4eXlNWDFqUE9hOS9Zb3U1L29mc3JxeGdJMHkwem9ETE9I?=
 =?utf-8?B?TkxMaXBMcWJxUTRweXFkNHllSVZwRGh6QWJRUXBDUEYzdnpXcFFqZVBHUE9I?=
 =?utf-8?B?Z1JHTWZ6YTRIZmhvd0R4Q2wwRDRreXFwNG0waUl1WDRBc2hwVXA1OWFYc3Zx?=
 =?utf-8?B?QUQxZ3IrYzJhYnJxOGlJUjhUeEdqZWMwdVBDVXJzaHh0c1pvY050Z0c5UGdm?=
 =?utf-8?B?UFBaSEJEQ2IySjRPaE40VEJHLzN3amdkMy95SytjQ3FkOGNKOVZXR0VyMnlS?=
 =?utf-8?B?VXlRUFJaVlJUMVp1Qzh4eWlva0NkbWc5NU9ITW9kTVQwL0RSRERCMWNRRkxk?=
 =?utf-8?B?UDMraG5EdDd0Y0RveEtCK2dTdzlybzkwLzlVOTBJTTZCMmVqWmRGTEVHK1NX?=
 =?utf-8?B?ZDdmdzJRamdxVHJkdDdIdEl6a2lxNXdGWDZsbW11SEI2cU9Ja1BsbjloMkVu?=
 =?utf-8?B?cTI5R1h5eDFhNmRCMXZZaTU0aFgrOEh4ODdXdWFmUWEvdTNhSEFXS0lzaDBo?=
 =?utf-8?B?SE5DT3p4TzJxcFJ6eE0xYis4QmlSdExObDArWTZpZStDamNCU0dpc2d6MDFk?=
 =?utf-8?B?d0tMSTlRUlRBaUIrR0J6eVg5NkRlS0hFbWwvYkNjcG4xSzBrOVhscTd4WVpL?=
 =?utf-8?Q?FBF1L+Ot1A+yPuUk3olo65lVPmwiEpKXE0yTSqC?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a4b69cbd-c1db-4cf1-f73f-08d972d78f72
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 14:47:20.1350
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: khy0cw4NWpFnEzRq0OsL64g6kqQsGAjnGhdF4JjTDWB+fF0ExqenXFanSbWAgjWDwvgU80bTT04zobNjFrzYKh1Jbz3Fuk16QK3OwNH9JcQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4399
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10100 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0
 mlxlogscore=999 malwarescore=0 spamscore=0 mlxscore=0 suspectscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109030001 definitions=main-2109080093
X-Proofpoint-GUID: PHKTu_8mP6F-M0kgjuqQT4dIkupBdrip
X-Proofpoint-ORIG-GUID: PHKTu_8mP6F-M0kgjuqQT4dIkupBdrip
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/27/21 8:32 AM, Juergen Gross wrote:
> +static bool balloon_thread_cond(enum bp_state state, long credit)
> +{
> +	if (state != BP_EAGAIN)
> +		credit = 0;
> +
> +	return current_credit() != credit || kthread_should_stop();
> +}
> +
> +/*
> + * As this is a kthread it is guaranteed to run as a single instance only.
>   * We may of course race updates of the target counts (which are protected
>   * by the balloon lock), or with changes to the Xen hard limit, but we will
>   * recover from these in time.
>   */
> -static void balloon_process(struct work_struct *work)
> +static int balloon_thread(void *unused)
>  {
>  	enum bp_state state = BP_DONE;
>  	long credit;
> +	unsigned long timeout;
> +
> +	set_freezable();
> +	for (;;) {
> +		if (state == BP_EAGAIN)
> +			timeout = balloon_stats.schedule_delay * HZ;
> +		else
> +			timeout = 3600 * HZ;
> +		credit = current_credit();
>  
> +		wait_event_interruptible_timeout(balloon_thread_wq,
> +				 balloon_thread_cond(state, credit), timeout);


Given that wait_event_interruptible_timeout() is a bunch of nested macros do we need to worry here about overly aggressive compiler optimizing out 'credit = current_credit()'?


-boris