Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Tejun Heo <htejun@gmail.com>
Date:   Wed, 8 Sep 2021 06:29:38 -1000
From:   Tejun Heo <tj@kernel.org>
To:     Zhang Qiao <zhangqiao22@huawei.com>
Cc:     linux-kernel@vger.kernel.org, juri.lelli@redhat.com,
        mingo@redhat.com, peterz@infradead.org, vincent.guittot@linaro.org
Subject: Re: [PATCH] kernel/sched: Fix sched_fork() access an invalid
 sched_task_group
Message-ID: <YTjk8oiFa5EfDPn9@slm.duckdns.org>
References: <20210826112635.7404-1-zhangqiao22@huawei.com>
 <YSztujInfNNXkG5/@hirez.programming.kicks-ass.net>
 <YS0WF0sxr0ysb6Za@mtj.duckdns.org>
 <1f0cd867-9c6d-4e22-cadd-06af9f852f7a@huawei.com>
 <YS60T2bfLpxb6SUY@slm.duckdns.org>
 <128d52ab-b4ee-65f8-e0a3-2796ef43a98b@huawei.com>
 <YS+uEmQRmQqAbkmG@slm.duckdns.org>
 <3df62791-d123-db9b-ec9c-092c47a941cc@huawei.com>
 <YTea0kK9yL5+GoKt@slm.duckdns.org>
 <be0bdf5a-479c-51bb-6d51-42739c11710d@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <be0bdf5a-479c-51bb-6d51-42739c11710d@huawei.com>
Precedence: bulk

Hello,

On Wed, Sep 08, 2021 at 07:32:06PM +0800, Zhang Qiao wrote:
> I will update this patch by following the steps below:
> 1)rename cgroup_subsys->fork() to cgroup_subsys->post_fork();
> 2)add cgroup_subsys->fork() and the cpu_cgroup_fork() callback like this:
> 
> void cpu_cgroup_fork(struct task_struct *task) {
> ....
> 	p->sched_task_group = task_group(current);
> 	__set_task_cpu(p, smp_processor_id());
> 	if (p->sched_class->task_fork)
> 		p->sched_class->task_fork(p);
> ....
> 
> 
> 3)call cgroup_subsys->fork() after cgroup_can_fork().
> 
> Do you have any suggestion?

I'm not following why it needs to shuffle the callbacks. Can't you just
relocate the fectching of task_group after can_fork?

Thanks.

-- 
tejun