Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp724952pxb; Wed, 8 Sep 2021 10:48:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqi8k/1mgQnQpo8yuiP2h5tlwNh/v53QJDTgTGxJcs4Z/v2c8JpJc8kVwbGCE0tXJGxQfD X-Received: by 2002:a92:3f01:: with SMTP id m1mr789994ila.105.1631123290427; Wed, 08 Sep 2021 10:48:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631123290; cv=none; d=google.com; s=arc-20160816; b=nI1phfLaWy706sDEcvZc7pL76+vind7/+dwxY6/Gy+MLaYqQR4fKv5TwpULNh0AmxW AeT4Fe1Cc0xVglNrI0maxjbPHI3Kvsv92xsRB17gb/MSndbqHGWBSnvapb+rNgceo6r+ Qg9GJDjLlmj8U4NUXGamc2kdGKaQfQMim5dkXsI7hXGbe0bL5yOLwKmGHfmJH/vgMDvf MLJnfF8v1WZzYkqIjnZtBpjXwJV1QeMUjE8J+MwduzD0KOZx5QpQ+hgw8NRoJqN1YL+Z OjaWkB01gg/PvTGEhcQyr72BkwEWVqqyOVc5c1dNFkZxXmuiwfwqBGGp36nMBikAheM9 nCSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject; bh=kvUcgTUH5gifXf7oieAv85FksYENkECL+5rg4rgV/rE=; b=0ZT+G1Y0R6pDvTr/TI/ikgUTqmoqreHMtcXAyGn+njPM57AxTXXv8oQxJRvwEYCiMp acB5nndsBXzokQ9OqBj2FeRJW207RChTb5nOjQWWqZCB7B3rknbieXUdjEZFNT2OYj00 CkFN+qdgz04XNxJU3tsFes53rPXpBmHJbCX28xwaxbRrvl/RepLT0SCSIjjwrVVsNjVx bs5iWCTk+e5h+mdT9if+/HrzWW2QaNzJ9+7vBA2Au5Xf2Iukpc6ecWZ24UmofydTsxEC 8bjeKJbZwSht9dbjlVLgyvBjfwveOH/ZlQSuURII5+1YKf/LD7QgqdzSeZn1dll+WF6G wuhw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u3si3063889iom.82.2021.09.08.10.47.55; Wed, 08 Sep 2021 10:48:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348539AbhIHQxT (ORCPT + 99 others); Wed, 8 Sep 2021 12:53:19 -0400 Received: from mga07.intel.com ([134.134.136.100]:2633 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350090AbhIHQxQ (ORCPT ); Wed, 8 Sep 2021 12:53:16 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10101"; a="284243498" X-IronPort-AV: E=Sophos;i="5.85,278,1624345200"; d="scan'208";a="284243498" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2021 09:50:01 -0700 X-IronPort-AV: E=Sophos;i="5.85,278,1624345200"; d="scan'208";a="513327436" Received: from smithrya-mobl.amr.corp.intel.com (HELO [10.209.26.226]) ([10.209.26.226]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2021 09:50:00 -0700 Subject: Re: [PATCH v4 5/6] x86/sgx: Hook sgx_memory_failure() into mainline code To: "Luck, Tony" , Jarkko Sakkinen , Sean Christopherson Cc: "Zhang, Cathy" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" References: <20210728204653.1509010-1-tony.luck@intel.com> <20210827195543.1667168-1-tony.luck@intel.com> <20210827195543.1667168-6-tony.luck@intel.com> <49fccddbbf92279f575409851a9c682495146ad8.camel@kernel.org> <681d530d72de842c8bf43733c11f3c3f2ebf8c6e.camel@kernel.org> <25db682402d14c34af9ba525cffe85c5@intel.com> <848905ffa20cf234446b16682cbbcf1e56853950.camel@kernel.org> <40da1a9a7d5f41bb9b82ea2cbebce73a@intel.com> <250de8f97efe2458afc39f080c3ef6a55f42623c.camel@kernel.org> <9ee70d2db97c4f719fd23d68741069db@intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <0ef0a180-ff10-1c43-476a-41953fe2383c@intel.com> Date: Wed, 8 Sep 2021 09:49:58 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <9ee70d2db97c4f719fd23d68741069db@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/7/21 5:59 PM, Luck, Tony wrote: > +#ifdef CONFIG_X86_SGX > +int arch_memory_failure(unsigned long pfn, int flags); > +#define arch_memory_failure arch_memory_failure > + > +bool arch_is_platform_page(u64 paddr); > +#define arch_is_platform_page arch_is_platform_page > +#endif > > and in include/linux/mm.h > > +#ifndef arch_memory_failure > +static inline int arch_memory_failure(unsigned long pfn, int flags) > +{ > + return -ENXIO; > +} > +#endif > +#ifndef arch_is_platform_page > +static inline bool arch_is_platform_page(u64 paddr) > +{ > + return false; > +} > +#endif > > Dave: Is that what you wanted? If so I can fold these bits back into the > appropriate bits of the series. Address other comments. and post v5. Looks good to me. These can *also* be done with a config ARCH_HAS_SPECIAL_MEMORY_FAILURE bool in mm/Kconfig.h, and then: select ARCH_HAS_SPECIAL_MEMORY_FAILURE in the SGX Kconfig instead of the ifndef's. I prefer the configs personally because they are less ambiguous and can't be screwed up my missing #includes or weird #include ordering problems. But, some folks prefer to avoid polluting the CONFIG_* space. That's just pure personal preference though. Either way is fine.