Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] dmaengine: idxd: Use list_move_tail instead of
 list_del/list_add_tail
To:     Bixuan Cui <cuibixuan@huawei.com>, linux-kernel@vger.kernel.org,
        dmaengine@vger.kernel.org
Cc:     vkoul@kernel.org, john.wanghui@huawei.com
References: <20210908092826.67765-1-cuibixuan@huawei.com>
From:   Dave Jiang <dave.jiang@intel.com>
Message-ID: <54e2f5a5-9593-85f8-e00a-8638de5bbc60@intel.com>
Date:   Wed, 8 Sep 2021 09:43:08 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20210908092826.67765-1-cuibixuan@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 9/8/2021 2:28 AM, Bixuan Cui wrote:
> Using list_move_tail() instead of list_del() + list_add_tail()
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>

Thanks!

Acked-by: Dave Jiang <dave.jiang@intel.com>


> ---
>   drivers/dma/idxd/irq.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c
> index ca88fa7a328e..79fcfc4883e4 100644
> --- a/drivers/dma/idxd/irq.c
> +++ b/drivers/dma/idxd/irq.c
> @@ -221,8 +221,7 @@ static void irq_process_work_list(struct idxd_irq_entry *irq_entry)
>   
>   	list_for_each_entry_safe(desc, n, &irq_entry->work_list, list) {
>   		if (desc->completion->status) {
> -			list_del(&desc->list);
> -			list_add_tail(&desc->list, &flist);
> +			list_move_tail(&desc->list, &flist);
>   		}
>   	}
>