Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp753041pxb; Wed, 8 Sep 2021 11:27:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyv2JjucyDr1yctI8nH9ak0qivOH+Tle/V8ceQoFqFrPnmcZzaMArkn8UvZ9aWa1xGSEwNZ X-Received: by 2002:a17:906:5384:: with SMTP id g4mr1278551ejo.27.1631125645377; Wed, 08 Sep 2021 11:27:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631125645; cv=none; d=google.com; s=arc-20160816; b=GYHmE6RYaswsjyPHcTc4Q2mq57bt6PuwugNGaLbvyqhhGhHvjmQ0OpSbjvEtCg+DsL XUi5UVpOyWzeLUoMEW6WGkV82UiTrjyjM8xDVNCFdvwukDWSYoLrK9I5TeK5Dko5palG oDhPrZ0oaHbnF3H38a/olGnjaqfaKh/d0GVNYWZLJXINbk+NEVcBUg9+8/cUUlo179lj OM7UtLDqkoloVq+5I6Rt1Ul+7BrcUiT59VX5lYek5/5c/Q5qdY1ANLy4dU+pD0f5Cwny 6U5Gu7oePZqBTLs3w7dz645Z8xp2665iiemTm+SrkP1tcGcfkjHMA2a2Qo6txcG6sGR5 Eoeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=FlE0qMHbL5+xBmP2RU91kwGqsR+DkDaJdTbdBQ5TmKk=; b=LeC0Akv04hWa6d2arncHyVAd7SM/prZNVDVt+IK2u0xrYYzRbNvz2waEOg6Z/1tSmS 3I0kJqhdsNs/HOA6eykt+AX+EyMG+npXhlPTMLBIictBlA2JfZ32hIL5rAOQD2cV/exR B4qZWoXpcpR6g1RsEzXY+OvJXmn1FK9EY4+NXiK2qbUYvQCWayQ9kc+izADSeQjFIZNu WhYkzefRI3noyixU6QSt56RtS9PVjDBbM8H4V55GZ704zhnOCiSneSzjdUxlwhOwWYbB w16UJ8kfmpEt+FYQDguZdpwf1xpnPzdYrDBeBAjfq8XOMTLG3+QOR6k7wQqaoXo9K5C7 r8RA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=o48JoJtH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id sb9si3046670ejb.363.2021.09.08.11.26.56; Wed, 08 Sep 2021 11:27:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=o48JoJtH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349790AbhIHSZ7 (ORCPT + 99 others); Wed, 8 Sep 2021 14:25:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233322AbhIHSZ6 (ORCPT ); Wed, 8 Sep 2021 14:25:58 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2110EC061575; Wed, 8 Sep 2021 11:24:50 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id q26so4618606wrc.7; Wed, 08 Sep 2021 11:24:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FlE0qMHbL5+xBmP2RU91kwGqsR+DkDaJdTbdBQ5TmKk=; b=o48JoJtHkBYjPAO44vHE1FRjZeflq+UFvLIUFRuK1vqw6gOsuLlMpBzWH0hQmIVvfw tF9Y96/la7KKN6+zBA6ax4Ptwrw4SDNMgMettvE9Xewh+Jge7x2+dN2VCE0Y/B2CpB4u jSnvc5EM21arIvJ0lM/RjaZ9qdGYyWkfR3IGocHrkDfYLo9zDn4gz/jX0l9/gpwAQ4Kk 22cbe+e5TZ3nKqT27XZsz58S27CoTClzbNejH4iIw7miZKyI1EaldbpTEfr2lOtgv+Gd pMoosNRfOEpLH814Y6XE/3mO1TNqqSL5yJMOWr79YNPgxyG3ulyjn3l4HasxK6OTlrjX DA4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FlE0qMHbL5+xBmP2RU91kwGqsR+DkDaJdTbdBQ5TmKk=; b=ZLlTQQHmq405lgHEOrcYlrRIwt8RCRS/peSOax56bs66L4VZLaWegNxBD/YxEe3h5C 8PzjVvxCdRldLz98+U39DG8i71ruBtp5biuoLnpqf+PH9OAwVdVeabOwFXtajgxGpeFm nKdNrZNRr/e2fndxwX37YIU5Wgh+YpXkf9A37NXBl2kuwQgjyJSaF01cnmOuoaLiDuEU G1XP/HMQ6QZb3x+gCwok6C2uveF9Rn6eSBjKaBv/pU8Q7Xlvctf6NHXYLGZqseg8Xr7c SuYETTM4YiJT2F55i+rZUpxmfUYfKnor5wO6JfbwDCAiiSs5YbU/Tv4sck1IEH1cz0MP PWrA== X-Gm-Message-State: AOAM531mtzguiMG7QrUwUt7MmA/Q25gQ2CTyarrsBv8PtYzClWmSShch syMijsqKEdMKvJW4qc8UJlaHz5uw9a6xGQ== X-Received: by 2002:adf:e606:: with SMTP id p6mr5619132wrm.231.1631125488779; Wed, 08 Sep 2021 11:24:48 -0700 (PDT) Received: from kista.localnet (cpe-86-58-29-253.static.triera.net. [86.58.29.253]) by smtp.gmail.com with ESMTPSA id s14sm2580837wmc.25.2021.09.08.11.24.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Sep 2021 11:24:48 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Yong Deng , Mauro Carvalho Chehab , Maxime Ripard , Chen-Yu Tsai , "open list:CSI DRIVERS FOR ALLWINNER V3s" , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:ARM/Allwinner sunXi SoC support" , open list , Ondrej Jirman Cc: Ondrej Jirman Subject: Re: [PATCH] media: sun6i-csi: Allow the video device to be open multiple times Date: Wed, 08 Sep 2021 20:24:47 +0200 Message-ID: <1694867.cU3HQo44PE@kista> In-Reply-To: <20210908105609.1823449-1-megous@megous.com> References: <20210908105609.1823449-1-megous@megous.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ondrej! Dne sreda, 08. september 2021 ob 12:56:09 CEST je Ondrej Jirman napisal(a): > Previously it was possible, but a recent fix for uninitialized > `ret` variable broke this behavior. > > v4l2_fh_is_singular_file() check is there just to determine > whether the power needs to be enabled, and it's not a failure > if it returns false. > > Fixes: ba9139116bc0538 ("media: sun6i-csi: add a missing return code") Only 12 characters for SHA-1 ID > Signed-off-by: Ondrej Jirman Otherwise: Reviewed-by: Jernej Skrabec Best regards, Jernej