Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 08/19] cpufreq: amd: add boost mode support for amd-pstate
To:     Huang Rui <ray.huang@amd.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        Borislav Petkov <bp@suse.de>, Ingo Molnar <mingo@kernel.org>,
        linux-pm@vger.kernel.org
Cc:     Deepak Sharma <deepak.sharma@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Mario Limonciello <mario.limonciello@amd.com>,
        Jinzhou Su <Jinzhou.Su@amd.com>,
        Xiaojian Du <Xiaojian.Du@amd.com>,
        linux-kernel@vger.kernel.org, x86@kernel.org
References: <20210908150001.3702552-1-ray.huang@amd.com>
 <20210908150001.3702552-9-ray.huang@amd.com>
From:   "Fontenot, Nathan" <Nathan.Fontenot@amd.com>
Message-ID: <a2718365-5975-5c91-350f-fe9098b4de7b@amd.com>
Date:   Wed, 8 Sep 2021 13:24:54 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <20210908150001.3702552-9-ray.huang@amd.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?STJ6cVlNRkU3My8xUTY4TnA2aTIrMjN4OE5GWW9aVzA0NTVpeE04QXBjRXFS?=
 =?utf-8?B?VDd5M1krb055akd1NTA0anlxK1dQUnpvWWVCMzF4M3NIREFhSUVOOGVGRDZI?=
 =?utf-8?B?NlhNUllUdS9UYkhuQU9uTU5xcHZYK0NrVUZvYUlJdklwWEUrMzVTUlpVRHdL?=
 =?utf-8?B?NGlSRVU5Z01pb0hvOUlDSG9KK3FSSGhoL0dUSFZjamh3bHdZaHlrL0FaK0lw?=
 =?utf-8?B?cEJhTG9aemZrcXlUTk1udVZ1aGtNY1VlWi9lRU94K01IZGhFZzFKODVNVXBH?=
 =?utf-8?B?Y0hGc0Z2ZnREaVI0RlQzQ3lBUm1PbDJzbTR2VEVVaEtUUVlHVjg4UlVaOE5M?=
 =?utf-8?B?TTdCZndYSEh0QUZTOWdUVHg2SWhuNlQxaWpseTM1VVdtTFkxUWYrSHp2bU1K?=
 =?utf-8?B?d09xSUhQVUJZZm82UzFaZEhjNzl6YUIraU4zVGxMVnZ6Z2tYalhiVUQvUDd2?=
 =?utf-8?B?a0hpQlFDTU04QnF6a09ndDlBU3d0WDdZM29meUQyd0tUUlFZZmFOTGxJNzJh?=
 =?utf-8?B?LzJlN3BxNTFMcU03NnJLSHV6NGlEZ3g1TTVYbkNiaUtHd0N0UEQyYTJKeTg3?=
 =?utf-8?B?QmU4VVh1eDVBdG1TWml6ZXJkMVROcFZscVdiTFNmWE5NZWduazVSV0VUb3lt?=
 =?utf-8?B?OW4wQUE2R3hYSzFQZ0F1T3dXaHBYUnlHQzN1VFlaWFBiUFRFWFhpa1lLd1FF?=
 =?utf-8?B?ekkvMldSY1c5QkF1clJnTDFCaENSa0hXd3E1aXErVjRJR1ZqeG0xZnBQdlR2?=
 =?utf-8?B?M2NqaDNGUXFYVC9RYWVVUVdiOTU3bUVWbG9vQlhNNDlQVnpkK0t6djBWSGdF?=
 =?utf-8?B?T3p3d2lRdTdDR2owNVdGZGxScUhOOGZacndGVkZNSldWZWZqQVM4RDcyQlY3?=
 =?utf-8?B?NW80dzVNYnE0ZWVqNUp4VU5KSTh1UmdmZHlvNHZaZHRTQ0c2cURUY2x1M2tk?=
 =?utf-8?B?cUNwVXBFbW9QOXdyaHBFMXJmcGJYWXJSYzNkNHJzaUVDZUpUSlhkcHFOMExE?=
 =?utf-8?B?bjlXSnpZa0ZEKzdWZllTZVMveWRGNFNHLzkrUFVMU2FUQmhsNm82VGZ2dVdP?=
 =?utf-8?B?OHV0OXR1MkU5WGJydkV2UkMzODFtNS9mdms1c3RJU0gxdE1nbnhEMHEvV2VR?=
 =?utf-8?B?bW1lSTVMNGpNa0xHQld0cDJ6c3ZSOTBhQUtjR0c5ZW5iSE45Wmk3dXVvL0R1?=
 =?utf-8?B?dmYxck5Jd2RKZDZNS2d6aGpHZktSTFFaTFJMcUgrWjFUdXMwS253WnhCTXl2?=
 =?utf-8?B?K082c3MyeUo0cXBYY2h6QTV2aklKdHJjUzkrZWh5RzJPYm9TZld4TTN6bHBq?=
 =?utf-8?B?T09RZnZPOEh3aTVFTEExbm9ONWdyeWk2MzkrZUR4V0dSemZwNndKdlZpdDYx?=
 =?utf-8?B?cUk0dGYrcTdDL2R5cGdVbjZVRmI2ZkE0aklZTFFUSXd0VlFYQTJlTjRBTFkw?=
 =?utf-8?B?RVc3TFo0V1lxS1hKRTNCZUlrVm9XUlk0Y3p4MjI0cmFUYmVEZ1ptZENNM3Ir?=
 =?utf-8?B?Y2V6Z3FPekVTT08reEFDdk1uUjJVd2czWENTSEJockZNTldmUFM5cFg1Smoy?=
 =?utf-8?B?SmlPcVNJdnZ6am9Gek9aM2d5MmhJbnBHcGp3SmpIMytBRHg4cDJjT1JrTENk?=
 =?utf-8?B?TVdoWldVMnlBTThjSEtzd0tURUUrSWRMOEtqbUt0bXpMang3R1RjeTNydHZI?=
 =?utf-8?B?ZUpPYmJacEVJcFRWRFo4RDErY2ZRdCtjaGN1Z0NBL1ZhRnNtQjB5ZlF4OStY?=
 =?utf-8?Q?RmmhRQMHJ9Ll8Xpy5f+Ik7NsBkeaup+sT9KvzRF?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f2766f2e-7870-4c2e-3392-08d972f5f703
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB4720.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 18:24:58.7871
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fB4B5Uf9+CwQjnvJttURmpAV6XMiaoYX9Oqj3be/UAm8PK49nVB3marsDk+MihSRHxpGPBhJMiD2l4dltEcFOQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2576
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/8/2021 9:59 AM, Huang Rui wrote:
> If the sbios supports the boost mode of amd-pstate, let's switch to
> boost enabled by default.
> 
> Signed-off-by: Huang Rui <ray.huang@amd.com>
> ---
>  drivers/cpufreq/amd-pstate.c | 50 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 50 insertions(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index ea965a122431..67a9a117f524 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -75,6 +75,8 @@ struct amd_cpudata {
>  	u32	min_freq;
>  	u32	nominal_freq;
>  	u32	lowest_nonlinear_freq;
> +
> +	bool	boost_supported;
>  };
>  
>  struct amd_pstate_perf_funcs {
> @@ -229,6 +231,19 @@ amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf,
>  				      max_perf, fast_switch);
>  }
>  
> +static bool amd_pstate_boost_supported(struct amd_cpudata *cpudata)
> +{
> +	u32 highest_perf, nominal_perf;
> +
> +	highest_perf = READ_ONCE(cpudata->highest_perf);
> +	nominal_perf = READ_ONCE(cpudata->nominal_perf);
> +
> +	if (highest_perf > nominal_perf)
> +		return true;
> +
> +	return false;
> +}
> +
>  static int amd_pstate_verify(struct cpufreq_policy_data *policy)
>  {
>  	cpufreq_verify_within_cpu_limits(policy);
> @@ -402,6 +417,37 @@ static int amd_get_lowest_nonlinear_freq(struct amd_cpudata *cpudata)
>  	return lowest_nonlinear_freq * 1000;
>  }
>  
> +static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state)
> +{
> +	struct amd_cpudata *cpudata = policy->driver_data;
> +	int ret;
> +
> +	if (!cpudata->boost_supported) {
> +		pr_err("Boost mode is not supported by this processor or SBIOS\n");
> +		return -EINVAL;
> +	}
> +
> +	if (state)
> +		policy->cpuinfo.max_freq = cpudata->max_freq;
> +	else
> +		policy->cpuinfo.max_freq = cpudata->nominal_freq;
> +
> +	policy->max = policy->cpuinfo.max_freq;
> +
> +	ret = freq_qos_update_request(&cpudata->req[1],
> +				      policy->cpuinfo.max_freq);
> +	if (ret < 0)
> +		return ret;
> +
> +	return 0;
> +}
> +
> +static void amd_pstate_boost_init(struct amd_cpudata *cpudata)
> +{
> +	cpudata->boost_supported = true;
> +	amd_pstate_driver.boost_enabled = true;
> +}
> +
>  static int amd_pstate_init_freqs_in_cpudata(struct amd_cpudata *cpudata,
>  					    u32 max_freq, u32 min_freq,
>  					    u32 nominal_freq,
> @@ -504,6 +550,9 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
>  
>  	policy->driver_data = cpudata;
>  
> +	if (amd_pstate_boost_supported(cpudata))
> +		amd_pstate_boost_init(cpudata);

Is there any reason to not merge amd_pstate_boost_supported() and
amd_pstate_boost_init() into a single function? I don't see that
amd_pstate_boost_supported() is called anywhere else.

-Nathan

> +
>  	return 0;
>  
>  free_cpudata3:
> @@ -535,6 +584,7 @@ static struct cpufreq_driver amd_pstate_driver = {
>  	.fast_switch    = amd_pstate_fast_switch,
>  	.init		= amd_pstate_cpu_init,
>  	.exit		= amd_pstate_cpu_exit,
> +	.set_boost	= amd_pstate_set_boost,
>  	.name		= "amd-pstate",
>  };
>  
> -- 
> 2.25.1
>