Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Daniel Jordan <daniel.m.jordan@oracle.com>
To:     Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>
Cc:     Josh Don <joshdon@google.com>, linux-kernel@vger.kernel.org,
        Daniel Jordan <daniel.m.jordan@oracle.com>
Subject: [PATCH] sched/fair: Fix se_is_idle() for !FAIR_GROUP_SCHED
Date:   Wed,  8 Sep 2021 16:39:46 -0400
Message-Id: <20210908203946.1261798-1-daniel.m.jordan@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qOaZnx9HenwwRj8/a++7GjH1YA52P/9iebqKcIz1mILKxot0M1RfeY32Ln/y?=
 =?us-ascii?Q?LGn3lPisKPcgneMosDmzjIP+WoxmoCR0dxHKsQM/gI+n2reIbJTuGKfjCwwf?=
 =?us-ascii?Q?VALG7cM3/mQ8EWtFptS6MACs/BSnjN9Y8brq46msO3BUft3D2yoUO+l0+2/4?=
 =?us-ascii?Q?glvHdGGx7h1vrilnvjknYwTgNo8qxgbM34ekkU/Jn7l2ogBUxw6Bb8YAO3vG?=
 =?us-ascii?Q?K5/ZJRQTZqX1m/7ZBNMAbwWameJboMRHW/UWBreiSWskQ92R7ZixA6bijyhe?=
 =?us-ascii?Q?EslcR1sVzgxiiPsJXEi5NqT2buiG8zBa1Tzf45jAsj5Vs6Y3njW8AnwRsG5p?=
 =?us-ascii?Q?nlcI6QqX0MPiJ/1Occ+PXGw9nmjaZS9wXCUGcOPytesxU06ivyak2ufpBACX?=
 =?us-ascii?Q?Yx2hdXfnOJO9EFPjz137DCQbbQR7CRw3aOk2/nv3q1yF1tSYLaKp5IcsiXnI?=
 =?us-ascii?Q?dhbnRz89Nm+myYc9tMI6qzVMeUWfti6ATcG4cwx8QjjT3EoS8HrvN4S6p86s?=
 =?us-ascii?Q?uRiija4Jgw5sbz4wEi4qLJRZ6NUOs3JNXnbaNNyBkTg9aI/dtfS5k2J80pnz?=
 =?us-ascii?Q?yuPvyv70jBvCEXW+Yt7Oy2iCkSGxDVnCYQDlmt0xB/pr+Nbo1ZH60tglFTUr?=
 =?us-ascii?Q?5sPqn97UG4JrxnxoJcds8Zr4EEqpO4JBacSlTIv46LmICPKLgAXvXhzpi8bD?=
 =?us-ascii?Q?4+AFGmRFhvwBTkuswPil6UX8HsQckMRrLf3WQaS+KpaHbiGUYphGMK6WxQpo?=
 =?us-ascii?Q?McYEKuoDyfijQNoVg2ynBYcEFjrkutUwPvkkXTQhlU4l9T5wsvGFuBaCp/Ow?=
 =?us-ascii?Q?DixQVnYfxSpdTzXKVCUDdgNy1PGCgJQwhWpsJD/viBTUzzGhcGcXP/H/nHMx?=
 =?us-ascii?Q?bQAGPxclyMDaeAAmbT06OJeszg3xlsT57DStriB3dFQh4p6l3r86wbOaQlPN?=
 =?us-ascii?Q?zhBkJBJnGw0pYapMo62K0ZnkhoP+NCUZxfYvDqvUZE+xRVO/Tsj2is3Wdqbt?=
 =?us-ascii?Q?4K2iZyxHf+dI69cql8DPmHSXUvIJcY+ceZ5Ncelk0KiwGOgjtoORiMuQKYyz?=
 =?us-ascii?Q?9SDtAwtvx7M//CZb9NjP4WT2JD27IqyBqyTiUCfdK7hKabafj/8gfS3gdbGX?=
 =?us-ascii?Q?qtJc50SnxVPvS2e7fW3QFI6p1Y9USfpvV19YzHSpHOJIReMl76YTfjRGh5oI?=
 =?us-ascii?Q?pkK/Qi9v7mcgw61ws7OReKdAD7MyU1gs0ldazsHBZwnrIk7HQsKABUsinv10?=
 =?us-ascii?Q?rPbS3s+3LgOWMZCohc46km9lu0cwnDF9kYZBOeEh+Uj84t63g+ygxYkwKltL?=
 =?us-ascii?Q?KhJ3QY9iqrO90GI1qayJ0Cju?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 194f570f-a11a-4d2f-6b8d-08d97308d4ed
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2966.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 20:40:02.1286
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FFOOqS3/hHdTYXhFYwRmLk8s9vW6ykzG0SnJqW91c3FDx5RRSwd5ltk3ZPMJOVURyPrRejoGQaJjFKQPa6WMrA5rgIyaCmgQmOiZXDjjYMg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3416
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10101 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0
 malwarescore=0 mlxscore=0 spamscore=0 bulkscore=0 mlxlogscore=999
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109030001 definitions=main-2109080129
X-Proofpoint-ORIG-GUID: 5HRgZhfBa_rSZaBCi2IZIR0hBkL9DqAB
X-Proofpoint-GUID: 5HRgZhfBa_rSZaBCi2IZIR0hBkL9DqAB
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

se_is_idle() unconditionally returns 0 for !FAIR_GROUP_SCHED.

Check whether the task is SCHED_IDLE instead so buddies aren't set for
such tasks, as was the behavior before 304000390f88.

Fixes: 304000390f88 ("sched: Cgroup SCHED_IDLE support")
Signed-off-by: Daniel Jordan <daniel.m.jordan@oracle.com>
---
 kernel/sched/fair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index ff69f245b939..8b22665bc18e 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -497,7 +497,7 @@ static int cfs_rq_is_idle(struct cfs_rq *cfs_rq)
 
 static int se_is_idle(struct sched_entity *se)
 {
-	return 0;
+	return task_has_idle_policy(task_of(se));
 }
 
 #endif	/* CONFIG_FAIR_GROUP_SCHED */

base-commit: ac08b1c68d1b1ed3cebb218fc3ea2c07484eb07d
-- 
2.32.0