Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 8 Sep 2021 16:38:28 -0400
From:   Daniel Jordan <daniel.m.jordan@oracle.com>
To:     Josh Don <joshdon@google.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Paul Turner <pjt@google.com>,
        Oleg Rombakh <olegrom@google.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Steve Sistare <steven.sistare@oracle.com>,
        Tejun Heo <tj@kernel.org>, Rik van Riel <riel@surriel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/4] sched: cgroup SCHED_IDLE support
Message-ID: <20210908203828.5tljgqezi6nqywi2@oracle.com>
References: <20210820010403.946838-1-joshdon@google.com>
 <20210820010403.946838-2-joshdon@google.com>
 <20210902012206.cm6flytlp63c2h5v@oracle.com>
 <CABk29NuoNRu0SnEEqC8zhJROndCSRhfsE2xkhO98WP_wTTDuCA@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CABk29NuoNRu0SnEEqC8zhJROndCSRhfsE2xkhO98WP_wTTDuCA@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7dpPkQGEgzqknhqd67jxSn5cJQaqaQL+5czOl7RD8op2SNLTQL4/UGhkFj14?=
 =?us-ascii?Q?hysa7cqjtOSD4WYHZe+CwJpVk8gEA85IFtbVoUfc8chxT/lBnXA8+f7V5IVR?=
 =?us-ascii?Q?gEotna7LPFYvx4hMMf1uZXpE7HAXtT6NrX/W0f+w1h7omOaI2c3/DbkRhDyM?=
 =?us-ascii?Q?VOKpj7LRYPaFJmFXH5kbOdvywMez3QWVeZBbN5dgpss/2MatzpzLBayf8NCg?=
 =?us-ascii?Q?SVml+YZvXotG7mzUjJWd1vM5YnCJ6gErMxAWIEDtaJOs6+0jaNzD4P5dPHTW?=
 =?us-ascii?Q?3KddiwhB33kS/s2+koPZ5CRYXOmZHW4KPR7EvZPrRFZDlmJCCdSiDxMjCKWm?=
 =?us-ascii?Q?eXx0KiGo6X5cb/wfUgNvNBOzsqBtjRIfSORRMR5KfYpl0WyuFMVS8PVK1csj?=
 =?us-ascii?Q?zkA+akt8tQU4KumPzySnlOv9lGUYS8N+osn0ka4Oq3cN/+q8twQq0unHEiII?=
 =?us-ascii?Q?SfREANDZala+cr5fWnSQGPWny1tGDGkKziDH914I9jFHwKuCjTSHk7P3EqWs?=
 =?us-ascii?Q?UapK72mnN1j1mSwHBZ8RaM+has7SaxFzxilYv/KgJH8reo7qKnni+AqMBXFD?=
 =?us-ascii?Q?5hiTJf6qgW7Bj/o2NP8D22OKyDIEscJu4Zv16LYpYbwBuJSqV9Cas+EFYuIx?=
 =?us-ascii?Q?YlqN/hYrTUlRvq+eAWcRJFrJFNVDHTUHMf/3iQbIsZ+4289fqK/HChaRTTEu?=
 =?us-ascii?Q?58u+Yrx69uYLdi/jFf+7RJg4OhhzPNQb7SFDU3M8oUobMoLDJDLGH9LW3ZYm?=
 =?us-ascii?Q?xq4d1BttxxuBAlDesQadtiCXW4Ijn7JYm0uPrziRh40R6g4E69m3MolJYcjR?=
 =?us-ascii?Q?wM+szWRXQGS0f6YNCp+RRTjWF65CnA9UntEShS1C9u444fUmVz1LwRlYuPI8?=
 =?us-ascii?Q?FOSdWDI6fa2V9263nybkh7/CSyQnsAGf3a54ABBKkdH/bCP+ufQk6jJQ1Oy9?=
 =?us-ascii?Q?Laacdm9/k7Si8bQh2Ji9wObll53YcvpnGGNrJyZxrhzfqa3Em3leTbm89fjx?=
 =?us-ascii?Q?Os3eZZeQ0/DwymA7mMvhwu8raC4WRIv7u+I93jFt9EOUHG7qd1zYmJvDUTCR?=
 =?us-ascii?Q?+8ArUcx5ZNIZDeMkMd/+v/YR2VV3a/NeEbT9LVlRRP2WDyhZWrQfSpTrlc3x?=
 =?us-ascii?Q?8qFGQcbjaH7DhreRfKpqVzt1NyLOlWOUjviFrindkkmA0NFnw4//A9QG6zYS?=
 =?us-ascii?Q?GHfON81fLbmDkkL7SM+zopWx40vcqo8bgEIZN4BHmlaSf0yXwheib7SJYgBo?=
 =?us-ascii?Q?riEP5+ini7yxic5H8EyAJdqUBF9qizUfnoC0NoSjmUqFaBVWYSZpWXgyjJXb?=
 =?us-ascii?Q?0H/4J3+BJLE8GGoACnGjpHsL?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a84f8841-884e-470f-6900-08d97308a023
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2966.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 20:38:33.5622
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZGfamKah4CczurQ6KdY1EUTaxNuvlUuC47if0CG3zI8GmZ271R0D8IMzc/QhQNgRpcCfKd+mdHyiXTlpEoxmptVaFi5G4fhUY4hnq7CwnAc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5470
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10101 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0
 malwarescore=0 spamscore=0 mlxscore=0 phishscore=0 mlxlogscore=999
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109030001 definitions=main-2109080129
X-Proofpoint-GUID: DsW_ZSJJgf-Lh1psie86yoZTHkRXBw_w
X-Proofpoint-ORIG-GUID: DsW_ZSJJgf-Lh1psie86yoZTHkRXBw_w
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 02, 2021 at 06:21:09PM -0700, Josh Don wrote:
> On Wed, Sep 1, 2021 at 6:22 PM Daniel Jordan <daniel.m.jordan@oracle.com> wrote:
> >
> > On Thu, Aug 19, 2021 at 06:04:00PM -0700, Josh Don wrote:
> > > +static int se_is_idle(struct sched_entity *se)
> > > +{
> > > +     return 0;
> > > +}
> >
> > I'm thinking !FAIR_GROUP_SCHED is a rare thing to behold?  So not a big
> > deal, but I think this wants to be
> >
> >         return task_has_idle_policy(task_of(se));
> >
> > so buddies aren't set for SCHED_IDLE.
> 
> Good point. Peter has merged this one already, do you want to send a patch?

Sure, here it comes.