Date: Sat, 9 Dec 2006 11:49:50 +0900
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, clameter@engr.sgi.com, apw@shadowen.org
Subject: Re: [RFC] [PATCH] virtual memmap on sparsemem v3 [3/4] static
 virtual mem_map
Message-Id: <20061209114950.307d57ca.kamezawa.hiroyu@jp.fujitsu.com>
In-Reply-To: <20061208163020.4650bbaa.akpm@osdl.org>
References: <20061208155608.14dcd2e5.kamezawa.hiroyu@jp.fujitsu.com>
	<20061208160708.c263a393.kamezawa.hiroyu@jp.fujitsu.com>
	<20061208163020.4650bbaa.akpm@osdl.org>
Organization: Fujitsu
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1038
Lines: 32

On Fri, 8 Dec 2006 16:30:20 -0800
Andrew Morton <akpm@osdl.org> wrote:

> > +#ifdef CONFIG_SPARSEMEM_VMEMMAP_STATIC
> > +#include <linux/mm_types.h>
> > +extern struct page mem_map[];
> > +#else
> >  extern struct page* mem_map;
> >  #endif
> > +#endif
> 
> This looks rather unpleasant - what went wrong here?
> 
definition of 'struct page' is necessary before declearing array[]. (for gcc-4.0)

> Would prefer to unconditionally include the header file - conditional inclusions
> like this can cause compile failures when someone changes a config option.  They
> generally raise the complexity level.
>
Okay.
Now, forward declearation of 'struct page' is in mmzone.h. 
I'll remove it and include mm_types.h instead of it.
If someone says "Don't do that", I'll look for anothere way.

-Kame


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/