Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp258995pxb; Wed, 8 Sep 2021 23:43:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9cu5VnEHdOSjfKGd24kl+Jd2sSG/Gjq8q61ioUzB/5zCMAmABbyMthmvHXNPzeiN8hDR8 X-Received: by 2002:a05:6e02:b41:: with SMTP id f1mr377773ilu.269.1631169808157; Wed, 08 Sep 2021 23:43:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631169808; cv=none; d=google.com; s=arc-20160816; b=GU2C6UHmlMVmOW4M39nPA37N1N3FLqGFsjkXET0qdbeBtUdwscjQXqLmVAPgPkcDEl P7QrEn2at4U3E2FyITtnR7OSEW/mi1ohTqpsgxdKlE4JeeSitUuKznr8WBMyIgI2aQSU 8Ma7qIhxoM07csGwRsBHXpq7jj4ZjroWw1cPpzrevH9L87PPL+7cO99IFW+MlFtDLECk tEOk1R8nh7+RvPGqSAwQaKoxLkhWvWCKhGkggpDaBniG9Fy55Uf8OvS0t6eQAbqPbzau SWbGKVIAPOHGn3GqplGDtVHZ2pAk5zmTK1JsD6fzaGJxeBbMLJSKP25V69McF6zeAiHK tOuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from :dkim-signature; bh=w8ba3lprUH64+lF9MNZzR+xLhmjlZzEh1UyopCn96mQ=; b=w1Nrh6uuSLGX4HYcSO8BOUjRx9VEo14wFOHIgE6bIfhf4cy97QzbUJm49BZ9a2qVYM AdGqcX773vJB+kA3J2wVbw9dyzILghrz4+N5d6pe4QPRGVK2T3r1vyRplTFMImFnElBR S5q345JUmfxr7yhzpIcaSVcLXaNRLxvk5yaYhO1X4CELDikcxD7ydBrFkdjTGIJBbRoD 49rF8hi7BcvdSCiHH/EJECGkKo1FWOtMQahliheLIIphbnl9vw85KPoYwfS5Y4PkACr9 Q6iTLq/sbzJ6dQ0z2rdKupv+Dk0peVhkVMmGgDBacJhOQWHYUrsytC+VZjrNvUzKPAaR 3ARQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=w8LclNiw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w14si1034172ill.17.2021.09.08.23.43.16; Wed, 08 Sep 2021 23:43:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=w8LclNiw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350461AbhIIGnU (ORCPT + 99 others); Thu, 9 Sep 2021 02:43:20 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:37342 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233833AbhIIGnR (ORCPT ); Thu, 9 Sep 2021 02:43:17 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1896g5fq057002; Thu, 9 Sep 2021 01:42:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1631169725; bh=w8ba3lprUH64+lF9MNZzR+xLhmjlZzEh1UyopCn96mQ=; h=From:To:CC:Subject:Date; b=w8LclNiwep/bp0TisxVbmw8FKOjkMBmEKsCkWQGujPi+2jAQ9aIlyYFRVzEJ06ESX zYg7nx6QvZHOJ2++bjuwdONyqLQnuOG5aUGNPmDNPOHmQtRcH+pT1zDqRHMIMLFJAz vOSQ2RvhnasibULUc25YKGlSd2tT06u4fpaENCEw= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1896g4QN127481 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 9 Sep 2021 01:42:04 -0500 Received: from DLEE108.ent.ti.com (157.170.170.38) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Thu, 9 Sep 2021 01:42:04 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Thu, 9 Sep 2021 01:42:04 -0500 Received: from a0393678-lt.ent.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1896g04P062945; Thu, 9 Sep 2021 01:42:01 -0500 From: Kishon Vijay Abraham I To: Greg Kroah-Hartman , Mathias Nyman , Alan Stern CC: , , , Kishon Vijay Abraham I , Subject: [PATCH v4 0/3] Fix cold plugged USB device on certain PCIe USB cards Date: Thu, 9 Sep 2021 12:11:57 +0530 Message-ID: <20210909064200.16216-1-kishon@ti.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cold plugged USB device was not detected on certain PCIe USB cards (like Inateck card connected to AM64 EVM or connected to J7200 EVM). Re-plugging the USB device always gets it enumerated. This issue was discussed in https://lore.kernel.org/r/772e4001-178e-4918-032c-6e625bdded24@ti.com and https://bugzilla.kernel.org/show_bug.cgi?id=214021 So the suggested solution is to register both root hubs along with the second hcd for xhci. RFC Patch series can be found at [1] v1 Patch series can be found at [3] v2 Patch series can be found at [4] v3 Patch series can be found at [5] Changes from RFC: 1) Mathias identified potential issues with the RFC patch [2] and suggested the solution to use HCD flags. This series implements it. Changes from v1: 1) Fixed code comments pointed out by Alan Stern 2) Renamed the HCD flag variable to "HCD_FLAG_DEFER_RH_REGISTER" from "HCD_FLAG_DEFER_PRI_RH_REGISTER" Changes from v2: 1) Fixed issue in error path handling pointed by Alan Changes from v3: 1) Fix un-initialized variable usb_remove_hcd() and did some cleanup suggested by Alan [1] -> https://lore.kernel.org/linux-usb/20210824105302.25382-1-kishon@ti.com/ [2] -> https://lore.kernel.org/linux-usb/06693934-28f2-d59e-b004-62cabd3f9e8e@linux.intel.com [3] -> https://lore.kernel.org/r/20210825105132.10420-1-kishon@ti.com [4] -> https://lore.kernel.org/r/20210826111426.751-1-kishon@ti.com [5] -> https://lore.kernel.org/r/20210908145146.GB603644@rowland.harvard.edu Kishon Vijay Abraham I (3): usb: core: hcd: Add support for deferring roothub registration xhci: Set HCD flag to defer primary roothub registration usb: core: hcd: Modularize HCD stop configuration in usb_stop_hcd() drivers/usb/core/hcd.c | 68 +++++++++++++++++++++++++++-------------- drivers/usb/host/xhci.c | 1 + include/linux/usb/hcd.h | 2 ++ 3 files changed, 48 insertions(+), 23 deletions(-) -- 2.17.1