Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp291886pxb; Thu, 9 Sep 2021 00:40:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyV6mZyZDMZ+JN2GoTvCqF22oGW8DVhShEkw6okj3bQXGYg6SxsCy7pTYspG9knUOR7gjbp X-Received: by 2002:a05:6e02:154a:: with SMTP id j10mr1383139ilu.79.1631173252630; Thu, 09 Sep 2021 00:40:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631173252; cv=none; d=google.com; s=arc-20160816; b=fxxmUz1TXRCw8RbgJy+t5C94HEvFs2GyuApdPzg3hDsvZ6i2wNcVsBpfmXJtexVHnV 7hcVlD4Otas8dgVXAqDwwWYgyrZQU2rDB+A23Lf2SFI4EO6kgqTtvxuGOUQWOvhP/I9H COeGmfe8czdq1vyoxeHizvtL6k8mZb19I4FIU4wCu3+kYu83TmzJkdbezEwt/YYMYAdm K6AD9MG7fbnoPcYutgbiQ818sk9fxlfVDI0VI4Cxl3QCQ1bGB3S1f8OuHA3j0lvBC54i K61TOYSV0kVseSILdU6KZ799ikWoiYouIfXkEXXdLyrXvmGBLL0oPbPeN7cv97O2z4jO nQdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=I90CQpS29Sp9VbaTD6Xv0o9jZPVLcTtCWrnNuqjv3s4=; b=F3cKSFEfwp2bgLPBp2WayQ9fVimHHFe3IeqZ/RHPM33OD0qnXKYIwXUSzjXcp6rOJI yTm7kzZwM65+bB4enborEnUJyLlUVMMCQcQ4b2AsLvt3xbLjW4MRa7Y4XWQeZax+Nq0b 4Ayi7iAngz2ymm9FKQpxCBaxmWlR540wVL0nvlAXrxTmxExXgMyBRl01ZpNs4aA7pBCU Yoqq2vOdoXUPQtJHrbCcUG7akYvMKIOaz6QTT4Oer6PQRKK9Cl0o4XHzmRbuu6kRXH0W TLmGsmjhNcYTE2Xsoao1y/MPnG+bHseazSdOv2SfOX7W2APoJ7AKb14ycTlA8yNOONPx ZcBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZlJF3N0o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a125si973993jaa.90.2021.09.09.00.40.38; Thu, 09 Sep 2021 00:40:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZlJF3N0o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352683AbhIIHjX (ORCPT + 99 others); Thu, 9 Sep 2021 03:39:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:39392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352685AbhIIHjR (ORCPT ); Thu, 9 Sep 2021 03:39:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CB45360F11; Thu, 9 Sep 2021 07:38:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631173088; bh=vo4h+QM6tQHpCYEs4sGKe7sRj2Lwu8JlfkoPGTG9aHM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZlJF3N0olCr6Lf1H8a4RC3LzAiEx+lrs8jFgglonpXObd2bRcaynvZ8PzChrp2C05 tjhSHS9f8V0kDPGtRVPhnA+CezAEJEZXlY2vlAnhoK5Cx1mMbw2Xer5kuu6/Y1XNaP 9mbGwbAIOZ5ujPZKOLTcz5047G15xcWApEXEKKpU= Date: Thu, 9 Sep 2021 08:38:13 +0200 From: Greg Kroah-Hartman To: Neal Liu Cc: Alan Stern , Tony Prisk , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tao Ren , BMC-SW@aspeedtech.com Subject: Re: [PATCH v3] usb: ehci: handshake CMD_RUN instead of STS_HALT Message-ID: References: <20210909063652.17282-1-neal_liu@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210909063652.17282-1-neal_liu@aspeedtech.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 09, 2021 at 02:36:52PM +0800, Neal Liu wrote: > For Aspeed, HCHalted status depends on not only Run/Stop but also > ASS/PSS status. > Handshake CMD_RUN on startup instead. > > Signed-off-by: Neal Liu > Acked-by: Alan Stern > Reviewed-by: Tao Ren > Tested-by: Tao Ren > > --- > drivers/usb/host/ehci-hcd.c | 11 ++++++++++- > drivers/usb/host/ehci-platform.c | 6 ++++++ > drivers/usb/host/ehci.h | 1 + > 3 files changed, 17 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c > index 10b0365f3439..01c022e46aa2 100644 > --- a/drivers/usb/host/ehci-hcd.c > +++ b/drivers/usb/host/ehci-hcd.c > @@ -634,7 +634,16 @@ static int ehci_run (struct usb_hcd *hcd) > /* Wait until HC become operational */ > ehci_readl(ehci, &ehci->regs->command); /* unblock posted writes */ > msleep(5); > - rc = ehci_handshake(ehci, &ehci->regs->status, STS_HALT, 0, 100 * 1000); > + > + /* For Aspeed, STS_HALT also depends on ASS/PSS status. > + * Skip this check on startup. > + */ > + if (ehci->is_aspeed) > + rc = ehci_handshake(ehci, &ehci->regs->command, CMD_RUN, > + 1, 100 * 1000); > + else > + rc = ehci_handshake(ehci, &ehci->regs->status, STS_HALT, > + 0, 100 * 1000); > > up_write(&ehci_cf_port_reset_rwsem); > > diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c > index c70f2d0b4aaf..c3dc906274d9 100644 > --- a/drivers/usb/host/ehci-platform.c > +++ b/drivers/usb/host/ehci-platform.c > @@ -297,6 +297,12 @@ static int ehci_platform_probe(struct platform_device *dev) > "has-transaction-translator")) > hcd->has_tt = 1; > > + if (of_device_is_compatible(dev->dev.of_node, > + "aspeed,ast2500-ehci") || > + of_device_is_compatible(dev->dev.of_node, > + "aspeed,ast2600-ehci")) > + ehci->is_aspeed = 1; > + > if (soc_device_match(quirk_poll_match)) > priv->quirk_poll = true; > > diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h > index 80bb823aa9fe..fdd073cc053b 100644 > --- a/drivers/usb/host/ehci.h > +++ b/drivers/usb/host/ehci.h > @@ -219,6 +219,7 @@ struct ehci_hcd { /* one per controller */ > unsigned need_oc_pp_cycle:1; /* MPC834X port power */ > unsigned imx28_write_fix:1; /* For Freescale i.MX28 */ > unsigned spurious_oc:1; > + unsigned is_aspeed:1; > > /* required for usb32 quirk */ > #define OHCI_CTRL_HCFS (3 << 6) > -- > 2.17.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot