Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 07 Sep 2021 07:16:21 +0200
Message-ID: <s5hmtopeziy.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Tong Zhang <ztong0001@gmail.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Leon Romanovsky <leon@kernel.org>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] ALSA: vx222: fix null-ptr-deref
In-Reply-To: <20210907014746.1445278-1-ztong0001@gmail.com>
References: <20210907014746.1445278-1-ztong0001@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 07 Sep 2021 03:47:45 +0200,
Tong Zhang wrote:
> 
> a recent refactor created a null pointer vx in snd_vx222_probe().
> The vx pointer should have been populated in snd_vx222_create() as
> suggested in earlier version, otherwise vx->core.ibl.size will throw an
> error.
> 
> [    1.298398] BUG: kernel NULL pointer dereference, address: 00000000000001d8
> [    1.316799] RIP: 0010:snd_vx222_probe+0x155/0x290 [snd_vx222]
> 
> Fixes: 3bde3359aa16 ("ALSA: vx222: Allocate resources with device-managed APIs")
> Signed-off-by: Tong Zhang <ztong0001@gmail.com>

Thanks, applied.


Takashi