Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp336952pxb; Thu, 9 Sep 2021 02:01:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/xuDaeFP4VURx2tzuQ9bBJnBG4++xWWtF6mA7NCrJSlNa64oPCzNlWrH3PTI23g+Me4e1 X-Received: by 2002:a02:1dc9:: with SMTP id 192mr1963214jaj.92.1631178107239; Thu, 09 Sep 2021 02:01:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631178107; cv=none; d=google.com; s=arc-20160816; b=e8FoqMnRn+Q/xLDSqd1hVIqWKyQWsnRhe+uR56k6wT6LkwTigpxvZYJp9BH4aWOwgv zwAKvbqxbGfGyy90A5NuRmvYiP+Lfb1SAannfb+aJbgSoaNNO+kiHR5vHPaW9tF/bFlb uL+eNC8cTtqv6b9ZxSUJt8zTTFR1WclP0/jA9QTSjBXEWrDhXREHQU2qDm8T7OXrmVvU 0BNpcTOv/tSezXvAx2ZG4GhrU5hsIXpICTo7zwyn0i3rQKIyrtYG0LPCc/u5DZxLFGGw fQ+3sYwge8VUmEE+uj7O03L0QYgaQvzSEsRIo8Pjksxq6f+y0YvNpdTjSsN6t816r+FM RyuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=mgHTQ90s9HWS/Qk890ZTM6YCqjPaHTKmNEtm7/wK76E=; b=wk3yYxqJSH8eJnfq+t4bQZ9VPrB8/WGSDhbFFXa4chy2A2evnQrgyJ22VwuBkws0Q8 vyUcOTSHQOJTaUUYsa9I3S4/ctJHHoVgNGbEjGrS8F0HYeObZbHtOJZb+Tuu1aYlMP0b SGUZTQxMJg7oLpqgCraX4zjEmF0jeV1Wmdoy8uAIHvEHL0rFD7Evt2v65UbpRU5aRYaj CeoFifDaUI5pfgCVGF7HqGs1fyqM1nmXYBatVPn6H0XCOGAa1V5r3Eu5Om9ITx0LK5qT /L71iJvXF6+tmBu5wHJqWCIiL9uzc+IUwnHzy90ZDLs5jOnP9qvMoi+hKCB0Uq/BmjgZ 2ceQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g3si1046668ile.29.2021.09.09.02.01.33; Thu, 09 Sep 2021 02:01:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232139AbhIIJB7 (ORCPT + 99 others); Thu, 9 Sep 2021 05:01:59 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:19019 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231281AbhIIJB6 (ORCPT ); Thu, 9 Sep 2021 05:01:58 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4H4tCy73dqzbmFN; Thu, 9 Sep 2021 16:56:46 +0800 (CST) Received: from dggpeml500017.china.huawei.com (7.185.36.243) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Thu, 9 Sep 2021 17:00:48 +0800 Received: from huawei.com (10.175.103.91) by dggpeml500017.china.huawei.com (7.185.36.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Thu, 9 Sep 2021 17:00:48 +0800 From: Yang Yingliang To: , CC: Subject: [PATCH] n64cart: fix return value check in n64cart_probe() Date: Thu, 9 Sep 2021 17:06:08 +0800 Message-ID: <20210909090608.2989716-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500017.china.huawei.com (7.185.36.243) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In case of error, the function devm_platform_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: d9b2a2bbbb4d ("block: Add n64 cart driver") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- drivers/block/n64cart.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/n64cart.c b/drivers/block/n64cart.c index c84be0028f63..26798da661bd 100644 --- a/drivers/block/n64cart.c +++ b/drivers/block/n64cart.c @@ -129,8 +129,8 @@ static int __init n64cart_probe(struct platform_device *pdev) } reg_base = devm_platform_ioremap_resource(pdev, 0); - if (!reg_base) - return -EINVAL; + if (IS_ERR(reg_base)) + return PTR_ERR(reg_base); disk = blk_alloc_disk(NUMA_NO_NODE); if (!disk) -- 2.25.1