Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 9 Sep 2021 12:01:51 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Larry Finger <Larry.Finger@lwfinger.net>
Cc:     phil@philpotter.co.uk, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Remove conditionals
 CONFIG_88EU_{AP_MODE,P2P}
Message-ID: <YTnbj+1fLVav5fyN@kroah.com>
References: <20210908050109.1279-1-Larry.Finger@lwfinger.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210908050109.1279-1-Larry.Finger@lwfinger.net>
Precedence: bulk

On Wed, Sep 08, 2021 at 12:01:09AM -0500, Larry Finger wrote:
> These two conditional compile symbols are explicitly defined.
> As a result, their included code is always compiled. They could be
> converted to Kconfig symbols; however, my experience with this driver
> in a GitHub repo is that many users of the device have it built into
> a SOC or SBC that they wish to use as an access point. As a result,
> CONFIG_88EU_APMODE would need to be selected. Thus it should be built in.
> 
> There have also been many users the wish to establish peer-to-peer
> networks with this device. For this reason, I am also proposing that
> CONFIG_88EU_P2P be automatically included.
> 
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>

Makes sense.  If this really does need to be split up in the future, it
can be done better without all of this #ifdef mess in the .c files.

thanks,

greg k-h