Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com;
Date:   Thu, 9 Sep 2021 18:12:48 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Fontenot, Nathan" <Nathan.Fontenot@amd.com>
CC:     "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        "Borislav Petkov" <bp@suse.de>, Ingo Molnar <mingo@kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH 08/19] cpufreq: amd: add boost mode support for amd-pstate
Message-ID: <20210909101248.GE3702717@hr-amd>
References: <20210908150001.3702552-1-ray.huang@amd.com>
 <20210908150001.3702552-9-ray.huang@amd.com>
 <a2718365-5975-5c91-350f-fe9098b4de7b@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <a2718365-5975-5c91-350f-fe9098b4de7b@amd.com>
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2021 10:13:47.2729
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 520be7cd-dafa-4b79-acd1-08d9737a832d
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT010.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1338
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 09, 2021 at 02:24:54AM +0800, Fontenot, Nathan wrote:
> On 9/8/2021 9:59 AM, Huang Rui wrote:
> > If the sbios supports the boost mode of amd-pstate, let's switch to
> > boost enabled by default.
> > 
> > Signed-off-by: Huang Rui <ray.huang@amd.com>
> > ---
> >  drivers/cpufreq/amd-pstate.c | 50 ++++++++++++++++++++++++++++++++++++
> >  1 file changed, 50 insertions(+)
> > 
> > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> > index ea965a122431..67a9a117f524 100644
> > --- a/drivers/cpufreq/amd-pstate.c
> > +++ b/drivers/cpufreq/amd-pstate.c
> > @@ -75,6 +75,8 @@ struct amd_cpudata {
> >  	u32	min_freq;
> >  	u32	nominal_freq;
> >  	u32	lowest_nonlinear_freq;
> > +
> > +	bool	boost_supported;
> >  };
> >  
> >  struct amd_pstate_perf_funcs {
> > @@ -229,6 +231,19 @@ amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf,
> >  				      max_perf, fast_switch);
> >  }
> >  
> > +static bool amd_pstate_boost_supported(struct amd_cpudata *cpudata)
> > +{
> > +	u32 highest_perf, nominal_perf;
> > +
> > +	highest_perf = READ_ONCE(cpudata->highest_perf);
> > +	nominal_perf = READ_ONCE(cpudata->nominal_perf);
> > +
> > +	if (highest_perf > nominal_perf)
> > +		return true;
> > +
> > +	return false;
> > +}
> > +
> >  static int amd_pstate_verify(struct cpufreq_policy_data *policy)
> >  {
> >  	cpufreq_verify_within_cpu_limits(policy);
> > @@ -402,6 +417,37 @@ static int amd_get_lowest_nonlinear_freq(struct amd_cpudata *cpudata)
> >  	return lowest_nonlinear_freq * 1000;
> >  }
> >  
> > +static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state)
> > +{
> > +	struct amd_cpudata *cpudata = policy->driver_data;
> > +	int ret;
> > +
> > +	if (!cpudata->boost_supported) {
> > +		pr_err("Boost mode is not supported by this processor or SBIOS\n");
> > +		return -EINVAL;
> > +	}
> > +
> > +	if (state)
> > +		policy->cpuinfo.max_freq = cpudata->max_freq;
> > +	else
> > +		policy->cpuinfo.max_freq = cpudata->nominal_freq;
> > +
> > +	policy->max = policy->cpuinfo.max_freq;
> > +
> > +	ret = freq_qos_update_request(&cpudata->req[1],
> > +				      policy->cpuinfo.max_freq);
> > +	if (ret < 0)
> > +		return ret;
> > +
> > +	return 0;
> > +}
> > +
> > +static void amd_pstate_boost_init(struct amd_cpudata *cpudata)
> > +{
> > +	cpudata->boost_supported = true;
> > +	amd_pstate_driver.boost_enabled = true;
> > +}
> > +
> >  static int amd_pstate_init_freqs_in_cpudata(struct amd_cpudata *cpudata,
> >  					    u32 max_freq, u32 min_freq,
> >  					    u32 nominal_freq,
> > @@ -504,6 +550,9 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
> >  
> >  	policy->driver_data = cpudata;
> >  
> > +	if (amd_pstate_boost_supported(cpudata))
> > +		amd_pstate_boost_init(cpudata);
> 
> Is there any reason to not merge amd_pstate_boost_supported() and
> amd_pstate_boost_init() into a single function? I don't see that
> amd_pstate_boost_supported() is called anywhere else.
> 

Sounds reasonable. Will update it in V2 as well.

Thanks,
Ray