Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp405701pxb; Thu, 9 Sep 2021 03:46:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlylllN1KBMBUaGixk4Gi854iSdXZrKpqqL1NZ0InJfhPuz+f9OyGq3d2G5cGV+whEXB1n X-Received: by 2002:a92:c248:: with SMTP id k8mr1744379ilo.78.1631184394735; Thu, 09 Sep 2021 03:46:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631184394; cv=none; d=google.com; s=arc-20160816; b=SGC8tIBNZ3M1FLvb+Yti6QPfdM89afyC3xwzcsScq5TMfVH7gk2dEe/LE3QTFPWm9A cgq5+KcpOV7rOPqJD4TFMmwr/bdqPJEXowx4rV/DQCwXcCeVHYlnJYH75FWgt65h7Ms0 UlmAMlzsZXXtDVm8x6q5e2ryPRys8R39Sc/qCm9zZwTWKjzzx3RA2KpgnQqlPgvMkTRa uT22PH0UnVOTZRS/vMtoaOZDpmBIcr45uNaqU5GvHF/Kpy5KLt/6Yc+dF/RLO4me9mzb SHD02bxmLic//nGtuls2k1IoTTVbAyxQnhCaNH+ryZ5pTLdy+K/d3p/38MJdHOrxNS7t ntiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=2anM/ZbPy6i25eNR9NW1BBBJS1d08PRuyDbsiqAMPTg=; b=FTeJtfyyCVn2QHoY5aWr3LqJmn/rNLKXV/OGVpOHwNk605NltoX173Z8iljmHkklcM eVPEdGIsAIyi3p7t088EvyigHJPp+onwoQRQaE0wrueLeF3/E7F5gyzw0A0CrVmhU6fw ypD3BIqt3LB1pi0fHKoICEgBghWKBbaHWWUCU51WgKCWvihdAbf3+AZqHqDn9gpPT2Zo 7rUbTVLddo+aNDAZ0E+2PNBtJQXFpYm8o7Dwe6dKMQF2EqcXfNabVdBFjsI6/D9wHhc1 koX0ukB4DdYC0pYYrDwJbwddN98QgDE5LDI/Qqf4RA1BpCokxMneqAgaaMfh+BBObrEA aopg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=omGA+tKY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z14si1363935ilq.148.2021.09.09.03.46.21; Thu, 09 Sep 2021 03:46:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=omGA+tKY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234261AbhIIKqK (ORCPT + 99 others); Thu, 9 Sep 2021 06:46:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233654AbhIIKqK (ORCPT ); Thu, 9 Sep 2021 06:46:10 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D72B2C061575 for ; Thu, 9 Sep 2021 03:45:00 -0700 (PDT) Received: from zn.tnic (p200300ec2f0e4500a512d950ff073124.dip0.t-ipconnect.de [IPv6:2003:ec:2f0e:4500:a512:d950:ff07:3124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 29BA91EC04EC; Thu, 9 Sep 2021 12:44:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1631184295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=2anM/ZbPy6i25eNR9NW1BBBJS1d08PRuyDbsiqAMPTg=; b=omGA+tKYR5akh5u03TZoPcZRf9uRod1Dry1cD4AVwHZWZVna0RoWAYD1LcJvUqRiqC1cLJ D9qXonE7fj0qOX6F0mPWNKzkWSPZuHOUH6wgETnggIaVhBhcYEKwmZPm2xqRQejsNseZuu IbOGiSO13OU0/4M5GVMOmEEe0UdiuyI= Date: Thu, 9 Sep 2021 12:44:46 +0200 From: Borislav Petkov To: Luming Yu Cc: Jinhua Wu , the arch/x86 maintainers , zelin.deng@linux.alibaba.com, jiayu.ni@linux.alibaba.com, Andi Kleen , Luming Yu , fan.du@intel.com, artie.ding@linux.alibaba.com, "Luck, Tony" , Thomas Gleixner , LKML , pawan.kumar.gupta@linux.intel.com, "Yu, Fenghua" , "H. Peter Anvin" , ricardo.neri-calderon@linux.intel.com, Peter Zijlstra Subject: Re: [PATCH] perf: optimize clear page in Intel specified model with movq instruction Message-ID: References: <1631177151-53723-1-git-send-email-wujinhua@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 09, 2021 at 06:34:40PM +0800, Luming Yu wrote: > do you mean jump label would not be replaced to nop when its key is enabled? > so we could not use it in certain functions? > I don't understand exactly what "ain't gonna happen" It means, you need to use an X86_FEATURE_ bit because I won't accept a static key. But do the benchmarks first. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette