Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Neal Liu <neal_liu@aspeedtech.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Alan Stern <stern@rowland.harvard.edu>,
        Tony Prisk <linux@prisktech.co.nz>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Tao Ren <rentao.bupt@gmail.com>, BMC-SW <BMC-SW@aspeedtech.com>
Subject: RE: [PATCH v3] usb: ehci: handshake CMD_RUN instead of STS_HALT
Thread-Topic: [PATCH v3] usb: ehci: handshake CMD_RUN instead of STS_HALT
Thread-Index: AQHXpUTHQLNMzg5Z5UqQTztzogOWBqubP/yAgABJ3iA=
Date:   Thu, 9 Sep 2021 11:13:15 +0000
Message-ID: <HK0PR06MB32027203A59270D0A30A855680D59@HK0PR06MB3202.apcprd06.prod.outlook.com>
References: <20210909063652.17282-1-neal_liu@aspeedtech.com>
 <YTmr1TCOhV39WQXQ@kroah.com>
In-Reply-To: <YTmr1TCOhV39WQXQ@kroah.com>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZWXjV5QSNIt0LAngwAQA0wUWSHBaHphFZkVlMmJiIP8Os+5KmGA1S23QJtdL?=
 =?us-ascii?Q?vQvuhVA+wWXcmBrt0s/ska8PX/7yPrAwdAdR+a4hYyS2wbD1TFGv0ZfTktja?=
 =?us-ascii?Q?SuXCMEKboyPk/fE+ZQnRGZINs/I5DhADXGECNNf2xjcXtgh/cjYYkVfNCvyD?=
 =?us-ascii?Q?S/yr9FHXJ++v3z514ba2pJ5ZmRlqXMi89BLiRVOKxZtHQaYaRV7Jv8xFEBdQ?=
 =?us-ascii?Q?DNx29aqY2UgfvblujFtmCgjkroUzaLdOwEK3ibRzJpZGDdJL4cOBs2xuuYeB?=
 =?us-ascii?Q?lRNkO2QyMq0Zar/acPNT803PkVeZk6ULa6VcP7r8bwC2KCJpSEQcX7NtngdE?=
 =?us-ascii?Q?oEeyv9vIglr0yjuvNuOzRYEDvdoQsuiNGWiofVhWppa02j4+K9oqi1tBr8mB?=
 =?us-ascii?Q?yUkxRGnQFlW2UgQ985LwL6sAzTvQd2JNj8GYxu6msOrVXDqwxrYVgK60Qs34?=
 =?us-ascii?Q?BGqiWYY+31hYkvMq8mHECwqTgsmXYqIlCjMl1aBUvSDUF1ett4QOYIlOqDXk?=
 =?us-ascii?Q?oCDUV54MTX67xpwzbQ4KTU7zXxgY5SJy2FxZHGrsAmhynqFxTd2p5O+k99z5?=
 =?us-ascii?Q?6K5R0fUxDrVqWHPX5mArvA8zA/1loOOglyHDET2riHoZ/1YM1KA+SByXsj49?=
 =?us-ascii?Q?K5k0aoESLc6X9zSm3oJLNxF+G4Ii2MjkW0Rs1MAfcUJgPv+T2q2PS4uI2lev?=
 =?us-ascii?Q?lPe6ITj3wzB3/JLvVzkof68GZuTvpBRV/kt7Rot58B+sDzMROS6VoblYka5v?=
 =?us-ascii?Q?lDF/+MdgDesdJj3HtLwDFPBbRGyt7S3zwChg7opbdU9fzaj3f/EttR5GqJDz?=
 =?us-ascii?Q?l/eOTU/KePOSM+dbVueBkUpL+0fZUsBEr7MKVymXq0eENgQ1wdF2qNrhY1yA?=
 =?us-ascii?Q?41AS6CNTCDUpo2zsF3ESJcNmKlW8lJE8AcL/vlSacNHfM4xF9qe3T26mgMKg?=
 =?us-ascii?Q?B6Iyl/SOsdaVBVut8wQxKCm85iYKzUE+w/jfFglTC4LO36mPHmvVSiEaxays?=
 =?us-ascii?Q?u1KJwzvXur51PlZ768q+DtjX1/J0cse8EZde20ZGosQu++T3N+530yI2HoA5?=
 =?us-ascii?Q?/scVsq5DLfuR2P4l6U+HN5JERnNUoeZMT6yWH5P6kvj2Er0ajThBvgGFeorr?=
 =?us-ascii?Q?BE0N+QaUcFwIVO/1spI0DQrZ42J/u9v7ZOfYOZe3854WGbGVsRzWkZUn6yTr?=
 =?us-ascii?Q?jG0zhceVRlHTj437ZFgeVaffNDg8kE+aSfDGHnprbCLZxilgqtF3B+O2l8vq?=
 =?us-ascii?Q?m91QweERMzWDXFrzwxOqm0CrXVyH+AWYupkG3/5+vEEdZQFlUvfLJ/mDVCVG?=
 =?us-ascii?Q?Lv8pdX59pf3uvYzhPUxDaiqL?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3202.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2090bdfa-a867-40ab-eae2-08d97382d223
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2021 11:13:15.6099
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bbeWmiCn6Z6S/RJFy077BUfsjV/qXXfKMVp8iqy9syN6HsK9g7Gr4lCqN0jHl0mwTENBOCms1IOEkPJEtFgcng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2579
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Sent: Thursday, September 9, 2021 2:38 PM
> To: Neal Liu <neal_liu@aspeedtech.com>
> Cc: Alan Stern <stern@rowland.harvard.edu>; Tony Prisk
> <linux@prisktech.co.nz>; linux-usb@vger.kernel.org;
> linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Tao R=
en
> <rentao.bupt@gmail.com>; BMC-SW <BMC-SW@aspeedtech.com>
> Subject: Re: [PATCH v3] usb: ehci: handshake CMD_RUN instead of STS_HALT
>=20
> On Thu, Sep 09, 2021 at 02:36:52PM +0800, Neal Liu wrote:

Fix STS_HALT handshake failure for Aspeed 2500/2600 platform.

Change since v2:
- Use my "real" name for both the Signed-off-by: line and the From: line.

Change since v1:
- Handshake CMD_RUN status on startup instead of easily skip it.

---
> > For Aspeed, HCHalted status depends on not only Run/Stop but also
> > ASS/PSS status.
> > Handshake CMD_RUN on startup instead.
> >
> > Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
> > Acked-by: Alan Stern <stern@rowland.harvard.edu>
> > Reviewed-by: Tao Ren <rentao.bupt@gmail.com>
> > Tested-by: Tao Ren <rentao.bupt@gmail.com>
> >
> > ---
> >  drivers/usb/host/ehci-hcd.c      | 11 ++++++++++-
> >  drivers/usb/host/ehci-platform.c |  6 ++++++
> >  drivers/usb/host/ehci.h          |  1 +
> >  3 files changed, 17 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> > index 10b0365f3439..01c022e46aa2 100644
> > --- a/drivers/usb/host/ehci-hcd.c
> > +++ b/drivers/usb/host/ehci-hcd.c
> > @@ -634,7 +634,16 @@ static int ehci_run (struct usb_hcd *hcd)
> >  	/* Wait until HC become operational */
> >  	ehci_readl(ehci, &ehci->regs->command);	/* unblock posted writes */
> >  	msleep(5);
> > -	rc =3D ehci_handshake(ehci, &ehci->regs->status, STS_HALT, 0, 100 * 1=
000);
> > +
> > +	/* For Aspeed, STS_HALT also depends on ASS/PSS status.
> > +	 * Skip this check on startup.
> > +	 */
> > +	if (ehci->is_aspeed)
> > +		rc =3D ehci_handshake(ehci, &ehci->regs->command, CMD_RUN,
> > +				    1, 100 * 1000);
> > +	else
> > +		rc =3D ehci_handshake(ehci, &ehci->regs->status, STS_HALT,
> > +				    0, 100 * 1000);
> >
> >  	up_write(&ehci_cf_port_reset_rwsem);
> >
> > diff --git a/drivers/usb/host/ehci-platform.c
> > b/drivers/usb/host/ehci-platform.c
> > index c70f2d0b4aaf..c3dc906274d9 100644
> > --- a/drivers/usb/host/ehci-platform.c
> > +++ b/drivers/usb/host/ehci-platform.c
> > @@ -297,6 +297,12 @@ static int ehci_platform_probe(struct
> platform_device *dev)
> >  					  "has-transaction-translator"))
> >  			hcd->has_tt =3D 1;
> >
> > +		if (of_device_is_compatible(dev->dev.of_node,
> > +					    "aspeed,ast2500-ehci") ||
> > +		    of_device_is_compatible(dev->dev.of_node,
> > +					    "aspeed,ast2600-ehci"))
> > +			ehci->is_aspeed =3D 1;
> > +
> >  		if (soc_device_match(quirk_poll_match))
> >  			priv->quirk_poll =3D true;
> >
> > diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h index
> > 80bb823aa9fe..fdd073cc053b 100644
> > --- a/drivers/usb/host/ehci.h
> > +++ b/drivers/usb/host/ehci.h
> > @@ -219,6 +219,7 @@ struct ehci_hcd {			/* one per controller */
> >  	unsigned		need_oc_pp_cycle:1; /* MPC834X port power */
> >  	unsigned		imx28_write_fix:1; /* For Freescale i.MX28 */
> >  	unsigned		spurious_oc:1;
> > +	unsigned		is_aspeed:1;
> >
> >  	/* required for usb32 quirk */
> >  	#define OHCI_CTRL_HCFS          (3 << 6)
> > --
> > 2.17.1
> >
>=20
> Hi,
>=20
> This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
> a patch that has triggered this response.  He used to manually respond
> to these common problems, but in order to save his sanity (he kept
> writing the same thing over and over, yet to different people), I was
> created.  Hopefully you will not take offence and will fix the problem
> in your patch and resubmit it so that it can be accepted into the Linux
> kernel tree.
>=20
> You are receiving this message because of the following common error(s)
> as indicated below:
>=20
> - You did not specify a description of why the patch is needed, or
>   possibly, any description at all, in the email body.  Please read the
>   section entitled "The canonical patch format" in the kernel file,
>   Documentation/SubmittingPatches for what is needed in order to
>   properly describe the change.
>=20
> - This looks like a new version of a previously submitted patch, but you
>   did not list below the --- line any changes from the previous version.
>   Please read the section entitled "The canonical patch format" in the
>   kernel file, Documentation/SubmittingPatches for what needs to be done
>   here to properly describe this.
>=20
> If you wish to discuss this problem further, or you have questions about
> how to resolve this issue, please feel free to respond to this email and
> Greg will reply once he has dug out from the pending patches received
> from other developers.
>=20
> thanks,
>=20
> greg k-h's patch email bot

Do you prefer fixing canonical patch format inline or sending new patch v4?
I added more description and the changes from previous version.

Thanks

-Neal