Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp436809pxb;
        Thu, 9 Sep 2021 04:34:09 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxW2xjOwNNOJvFWTNbYM1VL2sxjZ4KFmTCPDahzjM95SIklkzE+b0pSRG+ORJyMbyvB8tvi
X-Received: by 2002:a17:906:e117:: with SMTP id gj23mr2892784ejb.301.1631187249369;
        Thu, 09 Sep 2021 04:34:09 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1631187249; cv=none;
        d=google.com; s=arc-20160816;
        b=jTdnpr+XLaY4xC/WhVEPt94N/cudGAmGS+dTogGhf33OaM3NdtkQibM1LAGTHTKhih
         Xk21ngcQxUy+gN5vcJbDLNGyQyPWFXCzHzSPClsg3qNhtk233nkMM0htVNYZ0EZQGPmH
         OlGFB7bpZhZbXY0eXRoBvBDAe1Gv19Ml/NmRdyXbMwahvgb756NCZdLvU2pp6Qu9TNlI
         4tHSdiwTATRsq+Qisg2f5wJgFjFg0jRNd2rMh0wd8IDwKheGtZvZNUgcoaAUoC2gujH1
         0a71b2Zkn0hbkb5G1vQFJskryfWKAKJu3xj1zEIAkZqVyHjWbKNK7h6X30XM1TGxUsFt
         kHbQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=BfKEljguWPXGr4e3LXDH03SVJxLaZjb+EKBRx/u+o70=;
        b=0zjuoEcRU/jW9eeuZtYjDsl7+D3x+P7qfut292L37GgWxByuXz2OVtfTmDV24U0RqV
         n/bLmuJEBy39Biecp4fjm1U58hkA+tQL9BFtbHB4n+WlVdoi/L/v6swwa0ToJ62D5JhI
         DVuPZGdpdepZAkuUh3ukgBn1s2izl7jd6kLzmTzqoacbQTCWdmJQwfHRgB9ypBPX/Yyr
         6hIo0AQBBwmvnYAacMmMjxn61JXEPTPlq/9ARGq4FX/7NZkD/+46UubL8MEnIamAt+d6
         ogaqv8G5kWoBE1TsEz+VdsynsknWvczOPmxkUTnIwXZYCK2B+3OJfBgPKwU96sOdbkOB
         Zfzg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=EwatQv8p;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id h25si1573926edv.624.2021.09.09.04.33.44;
        Thu, 09 Sep 2021 04:34:09 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=EwatQv8p;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S235537AbhIILdD (ORCPT <rfc822;liyi.pear@gmail.com> + 99 others);
        Thu, 9 Sep 2021 07:33:03 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33892 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S234507AbhIILdC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Sep 2021 07:33:02 -0400
Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46706C061575;
        Thu,  9 Sep 2021 04:31:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=BfKEljguWPXGr4e3LXDH03SVJxLaZjb+EKBRx/u+o70=; b=EwatQv8pZFD06Pjcvm9Srfbpyf
        7yQTt9GjXjYiPICNt37b2mmQcExhyIkRlhUhtkBnEtH+9hUUhEIEb6H48USmxOGfbe0P/8dgOF7Il
        Rl7Sw4l8LVK6tFFsnAR6Ddzzy581bGk9BIdKoVE6V2cuOUAyWlLgSL9YiWvCObd2GLi6csVj1Gvq4
        LwyE9T+pNdLDopS66+PHKs0b74tGXRGnvMxdoKzeJoo0uPkeRXBPwoZGrycyke3wmtlrpYeDyRN9Q
        n6LBpZItlDI292lHeaOkidFObb16Q64qUEGQ2heZDvnVgx6KRPKF6T9fDcLWAuCOAv6F0nWhcnmY/
        WV2NfEUg==;
Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux))
        id 1mOIGT-009lZE-Mp; Thu, 09 Sep 2021 11:30:51 +0000
Date:   Thu, 9 Sep 2021 12:30:45 +0100
From:   Christoph Hellwig <hch@infradead.org>
To:     Andreas Gruenbacher <agruenba@redhat.com>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Christoph Hellwig <hch@infradead.org>,
        "Darrick J. Wong" <djwong@kernel.org>, Jan Kara <jack@suse.cz>,
        Matthew Wilcox <willy@infradead.org>, cluster-devel@redhat.com,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH v7 16/19] iomap: Add done_before argument to iomap_dio_rw
Message-ID: <YTnwZU8Q0eqBccmM@infradead.org>
References: <20210827164926.1726765-1-agruenba@redhat.com>
 <20210827164926.1726765-17-agruenba@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210827164926.1726765-17-agruenba@redhat.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by casper.infradead.org. See http://www.infradead.org/rpr.html
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

What about just passing done_before as an argument to
iomap_dio_complete? gfs2 would have to switch to __iomap_dio_rw +
iomap_dio_complete instead of iomap_dio_rw for that, and it obviously
won't work for async completions, but you force sync in this case
anyway, right?