Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp448754pxb; Thu, 9 Sep 2021 04:50:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJySb+DbsfL80JydQjlwAK/G/CLZYXaNWcgtrV1plNaGII32dIedfyWKY3sc7pE424dimAxA X-Received: by 2002:aa7:ca19:: with SMTP id y25mr2745947eds.197.1631188253477; Thu, 09 Sep 2021 04:50:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631188253; cv=none; d=google.com; s=arc-20160816; b=PetrjU+mv9/FVqOshU24xWAxB6wtjOoih3Cp/iWaUSrTVDT7S8n/tR6dzqKEaTqPWz JTqCFKLIzXxTzQMqejI8qyUpp/h6xgLYn5SeqYR0t6C/OmWxjk8awwRwFsWO9I8GOVzH 3zdZvAB8WFGLzmpZo3KqDvhUch4UbIdwKCQEv7HTAlFLSQUgk0VsNVXOHJ41yuPXzAsw HLUm8NAm3A63ER2V5gfvcNiNfKOh+hloPmigqdilhQk/9vvreNUWSp3Vfx5cGLXVltzm oJK5dUjQ+7VyELyyI/mvyabADNazk3NHcxpBp9G1WRlVaCpxE+cxejs2cJWv+l/rrMxn TsGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qkR8/lFE4qX6Yfxtg39KQi7HwwylAw7lLpb3zOs5GHo=; b=m9YU24JDAtXbwGhV9OdgvYuYdMTmecQ0nlZVqgsCfX9bOcTph7gEfR4cd3CMcCl/Zc fZLI6PqgH2gaz0i8AMxHbW1udF36H0teZ1vfcAeKlNFYBxigyJEchH7YP1ajX2OUFIti S6BLaTc3Hb0YjsR63R1ufOj6ysmh+ExNC8hQQ8fW+LWCZ9B+MtgC1kDpPrIavRkRz7K3 Gb4Zbp8oQGd0/l55xd0Tq9a4oWlGVLx5qPHWQ+EagDtKIlNcM4aQEP+xY1SsorrJVwb8 3dHAzw9zmp7V9ufNSiovxcf0tRlGQZ+9A/WYpEYs9UlQJkR8VZLPQ79YXnnLO6fB4YCT I1RA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=a3g60+ng; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d17si1587443edx.448.2021.09.09.04.50.28; Thu, 09 Sep 2021 04:50:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=a3g60+ng; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236764AbhIILt5 (ORCPT + 99 others); Thu, 9 Sep 2021 07:49:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:47268 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241770AbhIILrw (ORCPT ); Thu, 9 Sep 2021 07:47:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 71CF4611EF; Thu, 9 Sep 2021 11:43:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631187800; bh=HJfAW2t0hTonjZ5FlDW4q1tk06LyhkwoiHH4zkem0bc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a3g60+ngxWFunZ5cN96bxkSNYKlru4Okb52qesRkio9C/IDuf6ucOX+i1kGb/nMzo 1g7AJafyL7g2QfaXVd/AWVYjVbiT0galZGnUtgZXXroux5Za7oYRLOebjcS36LYsd5 68BtG4sUE1/5BSQB+7p10NMv+/DkwlLLVA8MBo5g+Bq6laJPYkdcUOVs7Wu8rb1eF8 Yo1ajdCEi/22uJzzv4Uz/pb0Fsm462DlIfMVLxovyeJzTfE+MS2KOQfHP6GzO+QyA9 OR8ogEvoOQnkh2H+yCWtG5JRpf6lJLgds0VLxYvi7S4dBWaiUeiQrW3pc3Z/Wo/jiG 89GOQTXkyM9ZA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ioana Ciornei , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.14 104/252] dpaa2-switch: do not enable the DPSW at probe time Date: Thu, 9 Sep 2021 07:38:38 -0400 Message-Id: <20210909114106.141462-104-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210909114106.141462-1-sashal@kernel.org> References: <20210909114106.141462-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ioana Ciornei [ Upstream commit 042ad90ca7ce70f35dc5efd5b2043d2f8aceb12a ] We should not enable the switch interfaces at probe time since this is trigged by the open callback. Remove the call dpsw_enable() which does exactly this. Signed-off-by: Ioana Ciornei Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c index 98cc0133c343..5ad5419e8be3 100644 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c @@ -3231,12 +3231,6 @@ static int dpaa2_switch_probe(struct fsl_mc_device *sw_dev) ðsw->fq[i].napi, dpaa2_switch_poll, NAPI_POLL_WEIGHT); - err = dpsw_enable(ethsw->mc_io, 0, ethsw->dpsw_handle); - if (err) { - dev_err(ethsw->dev, "dpsw_enable err %d\n", err); - goto err_free_netdev; - } - /* Setup IRQs */ err = dpaa2_switch_setup_irqs(sw_dev); if (err) -- 2.30.2