Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 09 Sep 2021 13:50:15 +0200
Message-ID: <s5hr1dy7ytk.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Sasha Levin <sashal@kernel.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        alsa-devel@alsa-project.org
Subject: Re: [PATCH AUTOSEL 5.14 166/252] ALSA: hda: Drop workaround for a hang at shutdown again
In-Reply-To: <20210909114106.141462-166-sashal@kernel.org>
References: <20210909114106.141462-1-sashal@kernel.org>
        <20210909114106.141462-166-sashal@kernel.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 09 Sep 2021 13:39:40 +0200,
Sasha Levin wrote:
> 
> From: Takashi Iwai <tiwai@suse.de>
> 
> [ Upstream commit 8fc8e903156f42c66245838441d03607e9067381 ]
> 
> The commit 0165c4e19f6e ("ALSA: hda: Fix hang during shutdown due to
> link reset") modified the shutdown callback of the HD-audio controller
> for working around a hang.  Meanwhile, the actual culprit of the hang
> was identified to be the leftover active codecs that may interfere
> with the powered down controller somehow, but we took a minimal fix
> approach for 5.14, and that was the commit above.
> 
> Now, since the codec drivers go runtime-suspend at shutdown for 5.15,
> we can revert the change and make sure that the full runtime-suspend
> is performed at shutdown of HD-audio controller again.  This patch
> essentially reverts the commit above to restore the behavior.
> 
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=214045
> Link: https://lore.kernel.org/r/20210817075630.7115-1-tiwai@suse.de
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Sasha Levin <sashal@kernel.org>

Please drop this, it's not for 5.14.
As stated in the commit log, the fundamental fix was merged in 5.15
that obsoletes the workaround, but it isn't included in 5.14.


thanks,

Takashi