Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp453095pxb; Thu, 9 Sep 2021 04:57:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyoZ/CycLxqtA7eBbhbCFk5JjatWVKDdFQ1IfzynPsFa7szpVVD4z+hpBLprCmsmJFZkqCx X-Received: by 2002:a02:cc53:: with SMTP id i19mr2467456jaq.124.1631188659004; Thu, 09 Sep 2021 04:57:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631188658; cv=none; d=google.com; s=arc-20160816; b=mCV9gTuEfmGSIeRWODBCrPLBkcBM38ZlReWoRCQrPZxX1sA5zFaVCefHaWu1BZBYKb QsVwQ2mucYpb13Oq40Utk4dNyn091W4I7vqRe/vjNAUr+HB4q3rGz6+luj8gGhRm4R/u HOocW1uov45wEPC5vLCH8Jjh6C1bjhngdJj3Ehg/Azngx4fg30vbwYT6qM0tQxzkDi51 u+UoRMP5JxSORDgMheafSYDQzVGhT5YqkRbd1Mx5mQby6kWyXbY7OywwrYQ8gto2pOIQ E5PCsBe+mltEs3ZlQXN+s0T56/3kq4lpRp0S+GYP5Amd5zkP9d/bUTxqp9z9I/N3ZPur eG5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2nZm0Hi+BQqvAsFzx5nivzMzUrkNgEwylj1HbXPxG50=; b=rK39qu0PsBG86eYLDer+1WTF86e8eMHsiLob+5JrocIBrnjzlpFLwbUCe19izPfsjJ sSUm9oU0WQiYgdEFwTH8r4+P6Ca7EhZ/ocratijIyQsqfyZO0dnay53/wzqAXhcEmS0A gEqfD8m691KzRuaZLkHAOEmw1SKj5RdAAt5pi1JHXhiKUSnPCklrOG9To/RLyVn+/jmF JyDvYoR9atx+B5zkm579Qe0N5wVsX5ugVPJpGqr7FX5QbTU0KpdhmhlphYLjXzVH2obF tIY0kRmmAwsYV3qrGZl8uwJA/oU7dmBvLc3n58EVjseYXGdkUeoby+5LEBiaB0XTWryv wTWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JH4tjT1U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c32si1588762jaa.44.2021.09.09.04.57.25; Thu, 09 Sep 2021 04:57:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JH4tjT1U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240309AbhIIL5t (ORCPT + 99 others); Thu, 9 Sep 2021 07:57:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:34406 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244321AbhIILyc (ORCPT ); Thu, 9 Sep 2021 07:54:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9F9EA611C3; Thu, 9 Sep 2021 11:44:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631187891; bh=ZMGrjSMZimhJuSbuiJ/hE2EWyRHaKnHeNyrA6L3KprY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JH4tjT1U6IH7LKoZFDlveoqjLM9sydAz4Pb7bPaH1BZs+90mLmg4k0zOZfYVvW/it ll8tL313XNp/xitWpoMsKkDQ27EUF8guhP5B5EMqTrsplSvf0jmb1c1G6fw+0K7bU5 KoRVESeSQnJbpm1JKBK3oJlESHpnJLkIfaQ7EF6JpLl1jwBstdTF6j7oYfaptCeS3B ldtg1WgS4Sg2EjyXU2pArBymJysVs0426zxhwC6OxPX5KK4kqSg8iN4ozBCt1GfNZU 0WacOb6scSBpgWFyoSJQq2F4+I3mgtSFBUyAem5XiEfV16ozzD93o4Uou88FWVHJXn a/HAPhu7lp5qw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Brandon Wyman , Guenter Roeck , Sasha Levin , linux-hwmon@vger.kernel.org Subject: [PATCH AUTOSEL 5.14 172/252] hwmon: (pmbus/ibm-cffps) Fix write bits for LED control Date: Thu, 9 Sep 2021 07:39:46 -0400 Message-Id: <20210909114106.141462-172-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210909114106.141462-1-sashal@kernel.org> References: <20210909114106.141462-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Brandon Wyman [ Upstream commit 76b72736f574ec38b3e94603ea5f74b1853f26b0 ] When doing a PMBus write for the LED control on the IBM Common Form Factor Power Supplies (ibm-cffps), the DAh command requires that bit 7 be low and bit 6 be high in order to indicate that you are truly attempting to do a write. Signed-off-by: Brandon Wyman Link: https://lore.kernel.org/r/20210806225131.1808759-1-bjwyman@gmail.com Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin --- drivers/hwmon/pmbus/ibm-cffps.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/pmbus/ibm-cffps.c b/drivers/hwmon/pmbus/ibm-cffps.c index 5668d8305b78..df712ce4b164 100644 --- a/drivers/hwmon/pmbus/ibm-cffps.c +++ b/drivers/hwmon/pmbus/ibm-cffps.c @@ -50,9 +50,9 @@ #define CFFPS_MFR_VAUX_FAULT BIT(6) #define CFFPS_MFR_CURRENT_SHARE_WARNING BIT(7) -#define CFFPS_LED_BLINK BIT(0) -#define CFFPS_LED_ON BIT(1) -#define CFFPS_LED_OFF BIT(2) +#define CFFPS_LED_BLINK (BIT(0) | BIT(6)) +#define CFFPS_LED_ON (BIT(1) | BIT(6)) +#define CFFPS_LED_OFF (BIT(2) | BIT(6)) #define CFFPS_BLINK_RATE_MS 250 enum { -- 2.30.2