Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 09 Sep 2021 13:53:02 +0200
Message-ID: <s5ho8927yox.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Sasha Levin <sashal@kernel.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        alsa-devel@alsa-project.org
Subject: Re: [PATCH AUTOSEL 5.14 132/252] ALSA: pci: cs46xx: Fix set up buffer type properly
In-Reply-To: <20210909114106.141462-132-sashal@kernel.org>
References: <20210909114106.141462-1-sashal@kernel.org>
        <20210909114106.141462-132-sashal@kernel.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 09 Sep 2021 13:39:06 +0200,
Sasha Levin wrote:
> 
> From: Takashi Iwai <tiwai@suse.de>
> 
> [ Upstream commit 4d9e9153f1c64d91a125c6967bc0bfb0bb653ea0 ]
> 
> CS46xx driver switches the buffer depending on the number of periods,
> and in some cases it switches to the own buffer without updating the
> buffer type properly.  This may cause a problem with the mmap on
> exotic architectures that require the own mmap call for the coherent
> DMA buffer.
> 
> This patch addresses the potential breakage by replacing the buffer
> setup with the proper macro.  It also simplifies the source code,
> too.
> 
> Link: https://lore.kernel.org/r/20210809071829.22238-4-tiwai@suse.de
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Sasha Levin <sashal@kernel.org>

This change is superfluous for 5.14.  Please drop.


thanks,

Takashi