Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp475724pxb; Thu, 9 Sep 2021 05:25:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxc2AmfRxDhaR7hiAzbzpnu4ZPiR3nfyjsO9PZZgYp2N0XFZae6SLXFHDiJf8dPnBzLofqv X-Received: by 2002:a17:906:e88:: with SMTP id p8mr3071299ejf.103.1631190344101; Thu, 09 Sep 2021 05:25:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631190344; cv=none; d=google.com; s=arc-20160816; b=w2k0Zk61xaMArjEYfVHFaaZ5jly+0R31tyxOMCIi4udNgB/YTTBmPyI8LkMiSubW13 0bWe5sOKsDJ+KH020vM6ZNKtzokONNjiXAVm7T8Ghac1Ti4tWuqffaZZBSTVthiRl97S MbJpO+KSIfePXetYm5VjKomYCAKpIuV82PgcT8CydaHptg80lhDqsyH4FQCXEZIGbNV8 AWNoqa/vSNfHysqLVk+jqhnXTQDswpspxsVBhXId161TZgb5rtkokLA6sp8k+loNSd1a z57s5KLna63cIDkujojMWO9qm17AnJpcYqw5tkJdHr9XWIxkJKmrYohd0lxDegAbCi4o yUPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=qlH1lR0/shhxJ53PG3SzFiA/puHTw3lxe0DkStCeWKA=; b=IeLJaEVlVVeW+N+fRRoTkelle+ZcS2+tm3uQxrFnEFmgBTWIVYkBZHTda781LoCQBt q6Xwb48+JFK7BHwZ6gBnGlzU2vIoMJqACd+TvYECzUc/rxsnrAq28eZt6ehVuVFhqpGb lD5Vgnig3j5ryPaTBVKR3zG5xtfMXxVfYLxRgEOtlTXTaUzOoWt1YtxvlvlBzZx+KLa1 IX/a22d8yH4FOAbZJz2dMPtRkA30xQ/b3f8Cs7BUHUmCgJ4JRm84BqkF/uEGuA6xm27q xKsD+ENmzyXvkiiq/pne+iYZJx9gc6NnlsujguCqd4Qaf1YRXkbyQHmBOaC05k6kvhOi d8Dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=0rrCGvHz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 18si1563836ejj.568.2021.09.09.05.25.17; Thu, 09 Sep 2021 05:25:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=0rrCGvHz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243429AbhIIMV5 (ORCPT + 99 others); Thu, 9 Sep 2021 08:21:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:52734 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348555AbhIIMMO (ORCPT ); Thu, 9 Sep 2021 08:12:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EA41661A4E; Thu, 9 Sep 2021 11:48:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631188132; bh=/QI+BRvDB+1wIbje5a8x8kgwfLi5dRyIuCwEUMJ67Uc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0rrCGvHzXq4q4P3wRbIPfFdZj9aoF9xeWh+QVHYOtkYUMxcQckD/vmyNkpTr8OuMG 33EhjEWIYevpzewX5QQtfFPAQYO0NpH30f/XC4si7SVH+pMmivhYpl2AYPpkA2z4FD Zybdev5tXrSDqGn3sLsrHYRp1loN5/lRdWq4zVQ8= Date: Thu, 9 Sep 2021 13:48:49 +0200 From: Greg Kroah-Hartman To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Phillip Potter , kernel test robot , linux-staging@lists.linux.dev Subject: Re: [PATCH AUTOSEL 5.14 044/252] staging: rtl8188eu: remove rtw_wx_set_rate handler function Message-ID: References: <20210909114106.141462-1-sashal@kernel.org> <20210909114106.141462-44-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210909114106.141462-44-sashal@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 09, 2021 at 07:37:38AM -0400, Sasha Levin wrote: > From: Phillip Potter > > [ Upstream commit ac5951a6e3d50cfa861ea83baa2ec15d994389cb ] > > Remove rtw_wx_set_rate handler function, which currently handles the > SIOCSIWRATE wext ioctl. This function (although containing a lot of > code) set nothing outside its own local variables, and did nothing other > than call a now removed debugging statement repeatedly. Removing it and > leaving its associated entry in rtw_handlers as NULL is therefore the > better option. Removing this function also fixes a kernel test robot > warning. > > Reported-by: kernel test robot > Signed-off-by: Phillip Potter > Link: https://lore.kernel.org/r/20210625191658.1299-1-phil@philpotter.co.uk > Signed-off-by: Greg Kroah-Hartman > Signed-off-by: Sasha Levin > --- > .../staging/rtl8188eu/os_dep/ioctl_linux.c | 75 ------------------- > 1 file changed, 75 deletions(-) This whole driver is now gone in 5.15-rc1, so no need for doing anything like this for older kernels. Please drop this patch from all branches. thanks, greg k-h