Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp571319pxb; Thu, 9 Sep 2021 07:21:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzYmSJLHYRVRqeZ6YDlsx7VF1ANHIhkZYRSXzALAbvy2GqKg1MJPHJe3590u5pi/4qCd2NY X-Received: by 2002:a92:c8d2:: with SMTP id c18mr2517446ilq.121.1631197286339; Thu, 09 Sep 2021 07:21:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631197286; cv=none; d=google.com; s=arc-20160816; b=yUCBMKX5wYpEKltvSrvFFulwXXAX/g31+Zf3QmDFHEkTDCJlcn3tLwuDQg1gSmjX33 xfDdg0gqr3+7rucbBuThtzn0WF0kWS3RPAIsJLx9nnEuk0rTs9dkfYMtvb2NJyt8cHzI jf7Vys+RJFW0KMxjuaidqVNjCTAO6isZVuIp15ErP4YyT4fRgxUgBL2fRCKqJrgiv0bt LHe9ZRD2Uq7iOCrVlZ4XWf7VibKM1WB4I4oVoa8tREe2gedgKfCBcS21Tuzstr0O+TSC q6w+GFja53H14RkDEdz7nfuNppoEArwZKRfNdOyBnKyJ7A0OG2Izni5bKEBqfdYub5Fa NyVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=gPbmP5OYCk3pZuf75KqV5gSYDzljR3Z2Mm9WPnd4Bk4=; b=eRd4UHxGf5Y0ntwH+YwXEkhlvcI166D1R9Zis0NmRBrzHG3De0EQ09/74KuiarE8Yg nVLjB8tK0bV+Tqn2Ag65VaoNIzdBW53fJk5MDfmz7a4Z1g+x2rsk7j1m4c1L7O72Wwwk eoab/QdEeKuxJo75Kg4D7lKLNITwB4NohfbYyr/7idq2H8Jd+byfhXeCXfp0+sDImriQ /HlOUyWv7ttvo1mXdwv7Ku0tv4hNaNfxVUcgzSWiwhoS1A7Qt9p3AGjStjmvfWGSo/cA Vpp+Pu3nu0Iif9f5OWuTjCa3ORPFj0EeBNMUPxDW4/OuSyGFNSzRT3RcMwy3GVBdPBVG IDsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=mOwcyAdj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o16si1696433ilh.153.2021.09.09.07.21.05; Thu, 09 Sep 2021 07:21:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=mOwcyAdj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241150AbhIIOUr (ORCPT + 99 others); Thu, 9 Sep 2021 10:20:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238789AbhIIOUn (ORCPT ); Thu, 9 Sep 2021 10:20:43 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59D71C028BF4; Thu, 9 Sep 2021 05:45:49 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id h16so3445580lfk.10; Thu, 09 Sep 2021 05:45:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gPbmP5OYCk3pZuf75KqV5gSYDzljR3Z2Mm9WPnd4Bk4=; b=mOwcyAdjD6ycDn1sjpwVp4EgAvANh85SbnkohQwhEbeJaW7A+Fz5GKSMFnHtJrouNe p44Zj/D9JVKGBYVhVQ+rnBCfbx8EDNo2/VAVNH0DRlyhiTLC10qDe6vqWlUQwTEWGqXs 86Mn46JNLdTZzmY6+ogR2CNh58AMdntTAbBApv3S+Fnf/oaB3nKHt3o9Dm0Uh0dFXC/j nkzZ5TXXgqoCjSOWaK/GHcGhvefYjZZqFMlggeKHtlR7lbzSvhNUMdn1Zmx+go6zuts2 WuH5x0A6q92yEOX5fPrjZxWdFTgPewLdf0KmCYf78MIJDpGiCJkEnQjaRfsahoSKzFNc gU4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gPbmP5OYCk3pZuf75KqV5gSYDzljR3Z2Mm9WPnd4Bk4=; b=wpKzWOSaRNgFZb37G4Vjk5kegGI3HAuC9th3u7VCwNsThHA7umPDzk0PsldEtKMoib ZKAvyNlESUpC8AxSHXibzu51XXhxRekEuZV1w7nvStJAToNDxyoP36liMhA48q9+/lv5 4OpG6zIJrCO8zcbnWB5H6yCBYz24X7Xtx/8kVq+MitexzHXF7IWVAKOZJV3jEt9FdZ6N fzoNth6r1Ttzz99x0f6hxnGL6HAQpgP+3gj7fTk4iQeMOSZ7IwHXpBPTfWFmXHJRfTBq hyDKo3LDR5118FE/cQvDRwP1pORxUu14gr34WzXQuHQvj65S6t6Isruj2pdQCVbCVO/v vMtw== X-Gm-Message-State: AOAM531J1p04pBPospK4oT5OPA/e3IaZJTZt/ufAkmwZN/wk8kaaV5Z7 fWOZqajneKpitybRfcUTlcOBFHLsejw= X-Received: by 2002:ac2:5923:: with SMTP id v3mr2173632lfi.459.1631191547269; Thu, 09 Sep 2021 05:45:47 -0700 (PDT) Received: from [192.168.2.145] (46-138-3-129.dynamic.spd-mgts.ru. [46.138.3.129]) by smtp.googlemail.com with ESMTPSA id d24sm193710ljj.8.2021.09.09.05.45.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Sep 2021 05:45:46 -0700 (PDT) Subject: Re: [PATCH AUTOSEL 5.14 133/252] spi: tegra20-slink: Improve runtime PM usage To: Mark Brown , Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-spi@vger.kernel.org, linux-tegra@vger.kernel.org References: <20210909114106.141462-1-sashal@kernel.org> <20210909114106.141462-133-sashal@kernel.org> <20210909123751.GA5176@sirena.org.uk> From: Dmitry Osipenko Message-ID: Date: Thu, 9 Sep 2021 15:45:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210909123751.GA5176@sirena.org.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 09.09.2021 15:37, Mark Brown пишет: > On Thu, Sep 09, 2021 at 07:39:07AM -0400, Sasha Levin wrote: >> From: Dmitry Osipenko >> >> [ Upstream commit e4bb903fda0e9bbafa1338dcd2ee5e4d3ccc50da ] >> >> The Tegra SPI driver supports runtime PM, which controls the clock >> enable state, but the clk is also enabled separately from the RPM >> at the driver probe time, and thus, stays always on. Fix it. >> >> Runtime PM now is always available on Tegra, hence there is no need to >> check the RPM presence in the driver anymore. Remove these checks. > > This feels new featureish to me - it'll give you runtime PM where > previously there was none. > Apparently all patches which have a word 'fix' in commit message are auto-selected. I agree that it's better not to port this patch.